Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2487/?format=api
https://patches.dpdk.org/api/patches/2487/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421941756-30948-1-git-send-email-nhorman@tuxdriver.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421941756-30948-1-git-send-email-nhorman@tuxdriver.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421941756-30948-1-git-send-email-nhorman@tuxdriver.com", "date": "2015-01-22T15:49:13", "name": "[dpdk-dev,v8,1/4] compat: Add infrastructure to support symbol versioning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "72e4189392671ef9e573c9674e31b8110193cb29", "submitter": { "id": 32, "url": "https://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421941756-30948-1-git-send-email-nhorman@tuxdriver.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2487/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A86CC5A9E;\n\tThu, 22 Jan 2015 16:49:26 +0100 (CET)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id B88BE5A9C\n\tfor <dev@dpdk.org>; Thu, 22 Jan 2015 16:49:24 +0100 (CET)", "from hmsreliant.think-freely.org\n\t([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1YEK0U-00065q-Qk; Thu, 22 Jan 2015 10:49:22 -0500" ], "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "dev@dpdk.org", "Date": "Thu, 22 Jan 2015 10:49:13 -0500", "Message-Id": "<1421941756-30948-1-git-send-email-nhorman@tuxdriver.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>", "References": "<1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Subject": "[dpdk-dev] [PATCH v8 1/4] compat: Add infrastructure to support\n\tsymbol versioning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add initial pass header files to support symbol versioning.\n\nSigned-off-by: Neil Horman <nhorman@tuxdriver.com>\nCC: Thomas Monjalon <thomas.monjalon@6wind.com>\nCC: \"Richardson, Bruce\" <bruce.richardson@intel.com>\nCC: \"Gonzalez Monroy, Sergio\" <sergio.gonzalez.monroy@intel.com>\n\n---\nChange Notes:\nV2)\n\tMoved ifeq to _INSTALL target\n\nV3)\n\tUndo V2 changes and make librte_compat use the rte.install.mk file\ninstead\n\nv4)\n\tchanged --version-script to accept SRCDIR in this patch at per request\n\tdocumented versioning macros\n\tcleaned up macro parameter consistency\n\tconverted SA macro to RTE_STR macro\n\tfixed copyright\n---\n lib/Makefile | 1 +\n lib/librte_compat/Makefile | 38 +++++++++++++\n lib/librte_compat/rte_compat.h | 117 +++++++++++++++++++++++++++++++++++++++++\n mk/rte.lib.mk | 4 ++\n 4 files changed, 160 insertions(+)\n create mode 100644 lib/librte_compat/Makefile\n create mode 100644 lib/librte_compat/rte_compat.h", "diff": "diff --git a/lib/Makefile b/lib/Makefile\nindex 0ffc982..d617d81 100644\n--- a/lib/Makefile\n+++ b/lib/Makefile\n@@ -31,6 +31,7 @@\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+DIRS-y += librte_compat\n DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_eal\n DIRS-$(CONFIG_RTE_LIBRTE_MALLOC) += librte_malloc\n DIRS-$(CONFIG_RTE_LIBRTE_RING) += librte_ring\ndiff --git a/lib/librte_compat/Makefile b/lib/librte_compat/Makefile\nnew file mode 100644\nindex 0000000..0bab870\n--- /dev/null\n+++ b/lib/librte_compat/Makefile\n@@ -0,0 +1,38 @@\n+# BSD LICENSE\n+#\n+# Copyright(c) 2013 Neil Horman <nhorman@tuxdriver.com>\n+# All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions\n+# are met:\n+#\n+# * Redistributions of source code must retain the above copyright\n+# notice, this list of conditions and the following disclaimer.\n+# * Redistributions in binary form must reproduce the above copyright\n+# notice, this list of conditions and the following disclaimer in\n+# the documentation and/or other materials provided with the\n+# distribution.\n+# * Neither the name of Intel Corporation nor the names of its\n+# contributors may be used to endorse or promote products derived\n+# from this software without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+# \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+\n+# install includes\n+SYMLINK-y-include := rte_compat.h\n+\n+include $(RTE_SDK)/mk/rte.install.mk\ndiff --git a/lib/librte_compat/rte_compat.h b/lib/librte_compat/rte_compat.h\nnew file mode 100644\nindex 0000000..d7cc176\n--- /dev/null\n+++ b/lib/librte_compat/rte_compat.h\n@@ -0,0 +1,117 @@\n+/*-\n+ * BSD LICENSE\n+ *\n+ * Copyright(c) 2010 Neil Horman <nhorman@tuxdriver.com>.\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions\n+ * are met:\n+ *\n+ * * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ * * Redistributions in binary form must reproduce the above copyright\n+ * notice, this list of conditions and the following disclaimer in\n+ * the documentation and/or other materials provided with the\n+ * distribution.\n+ * * Neither the name of Intel Corporation nor the names of its\n+ * contributors may be used to endorse or promote products derived\n+ * from this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#ifndef _RTE_COMPAT_H_\n+#define _RTE_COMPAT_H_\n+#include <rte_common.h>\n+\n+#ifdef RTE_BUILD_SHARED_LIB\n+\n+/*\n+ * Provides backwards compatibility when updating exported functions.\n+ * When a symol is exported from a library to provide an API, it also provides a\n+ * calling convention (ABI) that is embodied in its name, return type,\n+ * arguments, etc. On occasion that function may need to change to accomodate\n+ * new functionality, behavior, etc. When that occurs, it is desireable to\n+ * allow for backwards compatibility for a time with older binaries that are\n+ * dynamically linked to the dpdk. To support that, the __vsym and\n+ * VERSION_SYMBOL macros are created. They, in conjunction with the\n+ * <library>_version.map file for a given library allow for multiple versions of\n+ * a symbol to exist in a shared library so that older binaries need not be\n+ * immediately recompiled. Their use is outlined in the following example:\n+ * Assumptions: DPDK 1.(X) contains a function int foo(char *string)\n+ * DPDK 1.(X+1) needs to change foo to be int foo(int index)\n+ *\n+ * To accomplish this:\n+ * 1) Edit lib/<library>/library_version.map to add a DPDK_1.(X+1) node, in which\n+ * foo is exported as a global symbol.\n+ *\n+ * 2) rename the existing function int foo(char *string) to \n+ * \tint __vsym foo_v18(char *string)\n+ *\n+ * 3) Add this macro immediately below the function\n+ * \tVERSION_SYMBOL(foo, _v18, 1.8);\n+ *\n+ * 4) Implement a new version of foo.\n+ * \tchar foo(int value, int otherval) { ...}\n+ *\n+ * 5) Mark the newest version as the default version\n+ * \tBIND_DEFAULT_SYMBOL(foo, 1.9);\n+ *\n+ */\n+\n+/* \n+ * Macro Parameters:\n+ * b - function base name\n+ * e - function version extension, to be concatenated with base name\n+ * n - function symbol version string to be applied\n+ */\n+\n+/*\n+ * VERSION_SYMBOL\n+ * Creates a symbol version table entry binding symbol <b>@DPDK_<n> to the internal\n+ * function name <b>_<e>\n+ */ \n+#define VERSION_SYMBOL(b, e, n) __asm__(\".symver \" RTE_STR(b) RTE_STR(e) \", \"RTE_STR(b)\"@DPDK_\"RTE_STR(n))\n+\n+/*\n+ * BASE_SYMBOL\n+ * Creates a symbol version table entry binding unversioned symbol <b> \n+ * to the internal function <b>_<e>\n+ */ \n+#define BASE_SYMBOL(b, e) __asm__(\".symver \" RTE_STR(b) RTE_STR(e) \", \"RTE_STR(b)\"@\")\n+\n+/*\n+ * BNID_DEFAULT_SYMBOL\n+ * Creates a symbol version entry instructing the linker to bind references to\n+ * symbol <b> to the internal symbol <b>_<e>\n+ */\n+#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(\".symver \" RTE_STR(b) RTE_STR(e) \", \"RTE_STR(b)\"@@DPDK_\"RTE_STR(n))\n+#define __vsym __attribute__((used))\n+\n+#else\n+/*\n+ * No symbol versioning in use\n+ */\n+#define VERSION_SYMBOL(b, e, v)\n+#define __vsym\n+#define BASE_SYMBOL(b, n)\n+#define BIND_DEFAULT_SYMBOL(b, v)\n+\n+/*\n+ * RTE_BUILD_SHARED_LIB=n\n+ */\n+#endif\n+\n+\n+#endif /* _RTE_COMPAT_H_ */\ndiff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex 81bf8e1..1d3b646 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -40,8 +40,12 @@ VPATH += $(SRCDIR)\n \n ifeq ($(RTE_BUILD_SHARED_LIB),y)\n LIB := $(patsubst %.a,%.so,$(LIB))\n+\n+CPU_LDFLAGS += --version-script=$(SRCDIR)/$(EXPORT_MAP)\n+\n endif\n \n+\n _BUILD = $(LIB)\n _INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB)\n _CLEAN = doclean\n", "prefixes": [ "dpdk-dev", "v8", "1/4" ] }{ "id": 2487, "url": "