Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2476/?format=api
{ "id": 2476, "url": "https://patches.dpdk.org/api/patches/2476/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421914598-2747-11-git-send-email-cunming.liang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421914598-2747-11-git-send-email-cunming.liang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421914598-2747-11-git-send-email-cunming.liang@intel.com", "date": "2015-01-22T08:16:33", "name": "[dpdk-dev,v1,10/15] log: fix the gap to support non-EAL thread", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f159fb9d5456679f6078c6c26b77022b0fb0060c", "submitter": { "id": 46, "url": "https://patches.dpdk.org/api/people/46/?format=api", "name": "Cunming Liang", "email": "cunming.liang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421914598-2747-11-git-send-email-cunming.liang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2476/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 909335A9C;\n\tThu, 22 Jan 2015 09:17:40 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 5397D5A9F\n\tfor <dev@dpdk.org>; Thu, 22 Jan 2015 09:17:33 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 22 Jan 2015 00:14:31 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 22 Jan 2015 00:17:31 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0M8HSDl005504;\n\tThu, 22 Jan 2015 16:17:28 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0M8HQvp002873; Thu, 22 Jan 2015 16:17:28 +0800", "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0M8HQEW002869; \n\tThu, 22 Jan 2015 16:17:26 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,447,1418112000\"; d=\"scan'208\";a=\"640850287\"", "From": "Cunming Liang <cunming.liang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 22 Jan 2015 16:16:33 +0800", "Message-Id": "<1421914598-2747-11-git-send-email-cunming.liang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421914598-2747-1-git-send-email-cunming.liang@intel.com>", "References": "<1417589628-43666-1-git-send-email-cunming.liang@intel.com>\n\t<1421914598-2747-1-git-send-email-cunming.liang@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 10/15] log: fix the gap to support non-EAL\n\tthread", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For those non-EAL thread, *_lcore_id* is invalid and probably larger than RTE_MAX_LCORE.\nThe patch adds the check and allows only EAL thread using EAL per thread log level and log type.\nOthers shares the global log level.\n\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n lib/librte_eal/common/eal_common_log.c | 17 +++++++++++++++--\n lib/librte_eal/common/include/rte_log.h | 5 +++++\n 2 files changed, 20 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex cf57619..e8dc94a 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -193,11 +193,20 @@ rte_set_log_type(uint32_t type, int enable)\n \t\trte_logs.type &= (~type);\n }\n \n+/* Get global log type */\n+uint32_t\n+rte_get_log_type(void)\n+{\n+\treturn rte_logs.type;\n+}\n+\n /* get the current loglevel for the message beeing processed */\n int rte_log_cur_msg_loglevel(void)\n {\n \tunsigned lcore_id;\n \tlcore_id = rte_lcore_id();\n+\tif (lcore_id >= RTE_MAX_LCORE)\n+\t\treturn rte_get_log_level();\n \treturn log_cur_msg[lcore_id].loglevel;\n }\n \n@@ -206,6 +215,8 @@ int rte_log_cur_msg_logtype(void)\n {\n \tunsigned lcore_id;\n \tlcore_id = rte_lcore_id();\n+\tif (lcore_id >= RTE_MAX_LCORE)\n+\t\treturn rte_get_log_type();\n \treturn log_cur_msg[lcore_id].logtype;\n }\n \n@@ -265,8 +276,10 @@ rte_vlog(__attribute__((unused)) uint32_t level,\n \n \t/* save loglevel and logtype in a global per-lcore variable */\n \tlcore_id = rte_lcore_id();\n-\tlog_cur_msg[lcore_id].loglevel = level;\n-\tlog_cur_msg[lcore_id].logtype = logtype;\n+\tif (lcore_id < RTE_MAX_LCORE) {\n+\t\tlog_cur_msg[lcore_id].loglevel = level;\n+\t\tlog_cur_msg[lcore_id].logtype = logtype;\n+\t}\n \n \tret = vfprintf(f, format, ap);\n \tfflush(f);\ndiff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h\nindex db1ea08..f83a0d9 100644\n--- a/lib/librte_eal/common/include/rte_log.h\n+++ b/lib/librte_eal/common/include/rte_log.h\n@@ -144,6 +144,11 @@ uint32_t rte_get_log_level(void);\n void rte_set_log_type(uint32_t type, int enable);\n \n /**\n+ * Get the global log type.\n+ */\n+uint32_t rte_get_log_type(void);\n+\n+/**\n * Get the current loglevel for the message being processed.\n *\n * Before calling the user-defined stream for logging, the log\n", "prefixes": [ "dpdk-dev", "v1", "10/15" ] }