Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2468/?format=api
{ "id": 2468, "url": "https://patches.dpdk.org/api/patches/2468/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EC6D6@SHSMSX104.ccr.corp.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EC6D6@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EC6D6@SHSMSX104.ccr.corp.intel.com", "date": "2015-01-22T07:44:47", "name": "[dpdk-dev,v8,3/4] i40e: support of controlling hash functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b3638ed7b3f59582c3f6a711807bd32ddfbc845", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EC6D6@SHSMSX104.ccr.corp.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2468/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2468/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 59A495A73;\n\tThu, 22 Jan 2015 08:45:10 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id DCCCD5A37\n\tfor <dev@dpdk.org>; Thu, 22 Jan 2015 08:45:07 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 21 Jan 2015 23:42:05 -0800", "from pgsmsx108.gar.corp.intel.com ([10.221.44.103])\n\tby orsmga001.jf.intel.com with ESMTP; 21 Jan 2015 23:45:02 -0800", "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n\tPGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 22 Jan 2015 15:44:53 +0800", "from shsmsx104.ccr.corp.intel.com ([169.254.5.231]) by\n\tSHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id\n\t14.03.0195.001; Thu, 22 Jan 2015 15:44:47 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,447,1418112000\"; d=\"scan'208\";a=\"640835466\"", "From": "\"Zhang, Helin\" <helin.zhang@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash\n\tfunctions", "Thread-Index": "AQHQNIddreyrne8OmU6CnvUS5U4J5JzLw2aA", "Date": "Thu, 22 Jan 2015 07:44:47 +0000", "Message-ID": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EC6D6@SHSMSX104.ccr.corp.intel.com>", "References": "<1417176852-12345-1-git-send-email-helin.zhang@intel.com>\n\t<1417486760-24459-1-git-send-email-helin.zhang@intel.com>\n\t<1417486760-24459-4-git-send-email-helin.zhang@intel.com>\n\t<3554949.i7emeOiECJ@xps13>", "In-Reply-To": "<3554949.i7emeOiECJ@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi Thomas\n\nI have sent out v9 of this patch set, with adopting your comments. Thank you very much!\n\n> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Tuesday, January 20, 2015 3:54 PM\n> To: Zhang, Helin\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash\n> functions\n> \n> Hi Helin,\n> \n> 2014-12-02 10:19, Helin Zhang:\n> > Hash filter control has been implemented for i40e. It includes\n> > getting/setting,\n> > - global hash configurations (hash function type, and symmetric\n> > hash enable per flow type)\n> > - symmetric hash enable per port\n> >\n> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n> > ---\n> > lib/librte_ether/rte_eth_ctrl.h | 63 ++++++++\n> > lib/librte_pmd_i40e/i40e_ethdev.c | 294\n> > +++++++++++++++++++++++++++++++++++++-\n> > 2 files changed, 355 insertions(+), 2 deletions(-)\n> \n> Please, could you split ethdev and i40e parts while keeping Konstantin's ack?\nI have split it into two patches. Please forgive my typo (splitted->split) in changes logs\nwhich will not occur in commits.\nDo I need ask Konstantin to send out his Acked-by again? Or we can just add it?\nThe only differences is just as below.\n\n\n> \n> [...]\n> > + * Each bit in valid_bit_mask[] indicates if the coresponding bit in\n> \n> Typo: corresponding\nThanks, it is corrected in v9.\n\n> \n> [...]\n> > +\t/** Bit mask indicates if the coresponding bit is valid */\n> \n> Same typo\nThanks, it is corrected in v9.\n\n> \n> [...]\n> > +\t/** Details of hash filter infomation */\n> \n> Typo: information\nThanks, it is corrected in v9.\n\n> \n> > +\tunion {\n> > +\t\t/* For RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT */\n> > +\t\tuint8_t enable;\n> > +\t\t/* Global configurations of hash filter */\n> > +\t\tstruct rte_eth_hash_global_conf global_conf;\n> > +\t} info;\n> \n> Why these comments are not doxygen'ed?\nThanks, it is enabled in v9.\n\n> \n> Sorry for nitpicking, that's the last review pass ;)\nDon't worry, it is not nitpicking from my point of view. I really appreciate your hard works!\nThank you!\n\nRegards,\nHelin\n\n> --\n> Thomas", "diff": "--- a/lib/librte_ether/rte_eth_ctrl.h\n+++ b/lib/librte_ether/rte_eth_ctrl.h\n@@ -485,7 +485,7 @@ enum rte_eth_hash_function {\n * include symmetric hash enable per flow type and hash function type.\n * Each bit in sym_hash_enable_mask[] indicates if the symmetric hash of the\n * coresponding flow type is enabled or not.\n- * Each bit in valid_bit_mask[] indicates if the corresponding bit in\n+ * Each bit in valid_bit_mask[] indicates if the coresponding bit in\n * sym_hash_enable_mask[] is valid or not. For the configurations gotten, it\n * also means if the flow type is supported by hardware or not.\n */\n@@ -493,7 +493,7 @@ struct rte_eth_hash_global_conf {\n enum rte_eth_hash_function hash_func; /**< Hash function type */\n /** Bit mask for symmetric hash enable per flow type */\n uint32_t sym_hash_enable_mask[RTE_SYM_HASH_MASK_ARRAY_SIZE];\n- /** Bit mask indicates if the corresponding bit is valid */\n+ /** Bit mask indicates if the coresponding bit is valid */\n uint32_t valid_bit_mask[RTE_SYM_HASH_MASK_ARRAY_SIZE];\n };\n \n@@ -502,12 +502,12 @@ struct rte_eth_hash_global_conf {\n * type of 'RTE_ETH_FILTER_HASH' and its operations.\n */\n struct rte_eth_hash_filter_info {\n- enum rte_eth_hash_filter_info_type info_type; /**< Information type */\n- /** Details of hash filter information */\n+ enum rte_eth_hash_filter_info_type info_type; /**< Information type. */\n+ /** Details of hash filter infomation */\n union {\n- /** For RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT */\n+ /* For RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT */\n uint8_t enable;\n- /** Global configurations of hash filter */\n+ /* Global configurations of hash filter */\n struct rte_eth_hash_global_conf global_conf;\n } info;\n };\n", "prefixes": [ "dpdk-dev", "v8", "3/4" ] }