Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2457/?format=api
{ "id": 2457, "url": "https://patches.dpdk.org/api/patches/2457/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421912219-1946-2-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421912219-1946-2-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421912219-1946-2-git-send-email-helin.zhang@intel.com", "date": "2015-01-22T07:36:55", "name": "[dpdk-dev,v9,1/5] i40e: use constant as the default hash keys", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "21523a01fbb346a3b7cffb7b2ce7c5512bd84c4b", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421912219-1946-2-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2457/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F3E115A9F;\n\tThu, 22 Jan 2015 08:37:13 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 97BEF1288\n\tfor <dev@dpdk.org>; Thu, 22 Jan 2015 08:37:09 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 21 Jan 2015 23:34:07 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Jan 2015 23:37:06 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0M7b43R009296;\n\tThu, 22 Jan 2015 15:37:04 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0M7b2Lt001987; Thu, 22 Jan 2015 15:37:04 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0M7b2kM001983; \n\tThu, 22 Jan 2015 15:37:02 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,447,1418112000\"; d=\"scan'208\";a=\"665671630\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 22 Jan 2015 15:36:55 +0800", "Message-Id": "<1421912219-1946-2-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421912219-1946-1-git-send-email-helin.zhang@intel.com>", "References": "<1417486760-24459-1-git-send-email-helin.zhang@intel.com>\n\t<1421912219-1946-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v9 1/5] i40e: use constant as the default hash\n\tkeys", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Calculating the default RSS hash keys at run time is not needed\nat all, and may have race conditions. The alternative is to use\narray of random values which were generated manually as the\ndefault hash keys.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex b47a3d2..48bc34d 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -73,7 +73,7 @@\n /* Maximun number of VSI */\n #define I40E_MAX_NUM_VSIS (384UL)\n \n-/* Default queue interrupt throttling time in microseconds*/\n+/* Default queue interrupt throttling time in microseconds */\n #define I40E_ITR_INDEX_DEFAULT 0\n #define I40E_QUEUE_ITR_INTERVAL_DEFAULT 32 /* 32 us */\n #define I40E_QUEUE_ITR_INTERVAL_MAX 8160 /* 8160 us */\n@@ -200,9 +200,6 @@ static int i40e_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t\t\tvoid *arg);\n static void i40e_configure_registers(struct i40e_hw *hw);\n \n-/* Default hash key buffer for RSS */\n-static uint32_t rss_key_default[I40E_PFQF_HKEY_MAX_INDEX + 1];\n-\n static struct rte_pci_id pci_id_i40e_map[] = {\n #define RTE_PCI_DEV_ID_DECL_I40E(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"rte_pci_dev_ids.h\"\n@@ -5039,9 +5036,12 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n \t}\n \tif (rss_conf.rss_key == NULL || rss_conf.rss_key_len <\n \t\t(I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t)) {\n-\t\t/* Calculate the default hash key */\n-\t\tfor (i = 0; i <= I40E_PFQF_HKEY_MAX_INDEX; i++)\n-\t\t\trss_key_default[i] = (uint32_t)rte_rand();\n+\t\t/* Random default keys */\n+\t\tstatic uint32_t rss_key_default[] = {0x6b793944,\n+\t\t\t0x23504cb5, 0x5bea75b6, 0x309f4f12, 0x3dc0a2b8,\n+\t\t\t0x024ddcdf, 0x339b8ca0, 0x4c4af64a, 0x34fac605,\n+\t\t\t0x55d85839, 0x3a58997d, 0x2ec938e1, 0x66031581};\n+\n \t\trss_conf.rss_key = (uint8_t *)rss_key_default;\n \t\trss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *\n \t\t\t\t\t\t\tsizeof(uint32_t);\n", "prefixes": [ "dpdk-dev", "v9", "1/5" ] }