Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/24542/?format=api
{ "id": 24542, "url": "https://patches.dpdk.org/api/patches/24542/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1495639634-74846-8-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1495639634-74846-8-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1495639634-74846-8-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2017-05-24T15:27:09", "name": "[dpdk-dev,07/12] cryptodev: release device if PCI device probing fails", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5fd216d7c6f233820b46c77fa3d205a48a1e259f", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1495639634-74846-8-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/24542/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/24542/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 327F69951;\n\tWed, 24 May 2017 17:27:23 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 5F6147D02\n\tfor <dev@dpdk.org>; Wed, 24 May 2017 17:27:06 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 May 2017 08:27:06 -0700", "from silpixa00381631.ir.intel.com (HELO\n\tsilpixa00381631.ger.corp.intel.com) ([10.237.222.122])\n\tby fmsmga004.fm.intel.com with ESMTP; 24 May 2017 08:27:04 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,386,1491289200\"; d=\"scan'208\";a=\"265893713\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com,\n\tthomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Wed, 24 May 2017 16:27:09 +0100", "Message-Id": "<1495639634-74846-8-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>", "References": "<1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 07/12] cryptodev: release device if PCI device\n\tprobing fails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Call rte_cryptodev_pmd_release_device() if probing a\nPCI crypto device, instead of accessing the variables\ndirectly. This will be useful when rte_cryptodev_pci_probe()\ngets moved to a separate file.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n lib/librte_cryptodev/rte_cryptodev.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 2a84ee6..056ad56 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -540,9 +540,12 @@ rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev)\n \tif (cryptodev == NULL)\n \t\treturn -EINVAL;\n \n-\tret = rte_cryptodev_close(cryptodev->data->dev_id);\n-\tif (ret < 0)\n-\t\treturn ret;\n+\t/* Close device only if device operations have been set */\n+\tif (cryptodev->dev_ops) {\n+\t\tret = rte_cryptodev_close(cryptodev->data->dev_id);\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\t}\n \n \tcryptodev->attached = RTE_CRYPTODEV_DETACHED;\n \tcryptodev_globals.nb_devs--;\n@@ -603,8 +606,8 @@ rte_cryptodev_pci_probe(struct rte_pci_driver *pci_drv,\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\trte_free(cryptodev->data->dev_private);\n \n-\tcryptodev->attached = RTE_CRYPTODEV_DETACHED;\n-\tcryptodev_globals.nb_devs--;\n+\t/* free crypto device */\n+\trte_cryptodev_pmd_release_device(cryptodev);\n \n \treturn -ENXIO;\n }\n", "prefixes": [ "dpdk-dev", "07/12" ] }