Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/24536/?format=api
{ "id": 24536, "url": "https://patches.dpdk.org/api/patches/24536/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1495639634-74846-2-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1495639634-74846-2-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1495639634-74846-2-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2017-05-24T15:27:03", "name": "[dpdk-dev,01/12] cryptodev: store device pointer in virtual devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "736d66e6971a24d07c43a91d7036312b399e2637", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1495639634-74846-2-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/24536/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/24536/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 29D8B7D62;\n\tWed, 24 May 2017 17:27:08 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 1A6E27CEF\n\tfor <dev@dpdk.org>; Wed, 24 May 2017 17:27:01 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 May 2017 08:26:56 -0700", "from silpixa00381631.ir.intel.com (HELO\n\tsilpixa00381631.ger.corp.intel.com) ([10.237.222.122])\n\tby fmsmga004.fm.intel.com with ESMTP; 24 May 2017 08:26:52 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.38,386,1491289200\"; d=\"scan'208\";a=\"265893610\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com,\n\tthomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Wed, 24 May 2017 16:27:03 +0100", "Message-Id": "<1495639634-74846-2-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>", "References": "<1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 01/12] cryptodev: store device pointer in virtual\n\tdevices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Only non virtual devices were storing the pointer to\nrte_device structure in rte_cryptodev, which will be needed\nto retrieve the driver name for any device.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 3 ++-\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 +++-\n drivers/crypto/armv8/rte_armv8_pmd.c | 3 ++-\n drivers/crypto/kasumi/rte_kasumi_pmd.c | 3 ++-\n drivers/crypto/null/null_crypto_pmd.c | 7 +++++--\n drivers/crypto/openssl/rte_openssl_pmd.c | 3 ++-\n drivers/crypto/scheduler/scheduler_pmd.c | 7 +++++--\n drivers/crypto/snow3g/rte_snow3g_pmd.c | 3 ++-\n drivers/crypto/zuc/rte_zuc_pmd.c | 3 ++-\n lib/librte_cryptodev/rte_cryptodev.c | 4 +++-\n lib/librte_cryptodev/rte_cryptodev.h | 1 +\n lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 ++-\n 12 files changed, 31 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\nindex 101ef98..246f71e 100644\n--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n@@ -450,7 +450,8 @@ aesni_gcm_create(const char *name,\n \t}\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n-\t\t\tsizeof(struct aesni_gcm_private), init_params->socket_id);\n+\t\t\tsizeof(struct aesni_gcm_private), init_params->socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tGCM_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\ndiff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\nindex 45b25c9..49d3f32 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n@@ -699,12 +699,14 @@ cryptodev_aesni_mb_create(const char *name,\n \t}\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n-\t\t\tsizeof(struct aesni_mb_private), init_params->socket_id);\n+\t\t\tsizeof(struct aesni_mb_private), init_params->socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tMB_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\n \t}\n \n+\tdev->device = &vdev->device;\n \tdev->dev_type = RTE_CRYPTODEV_AESNI_MB_PMD;\n \tdev->dev_ops = rte_aesni_mb_pmd_ops;\n \ndiff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c\nindex 3d603a5..29905d6 100644\n--- a/drivers/crypto/armv8/rte_armv8_pmd.c\n+++ b/drivers/crypto/armv8/rte_armv8_pmd.c\n@@ -808,7 +808,8 @@ cryptodev_armv8_crypto_create(const char *name,\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n \t\t\t\tsizeof(struct armv8_crypto_private),\n-\t\t\t\tinit_params->socket_id);\n+\t\t\t\tinit_params->socket_id,\n+\t\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tARMV8_CRYPTO_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\ndiff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c b/drivers/crypto/kasumi/rte_kasumi_pmd.c\nindex 9da9e89..a95f503 100644\n--- a/drivers/crypto/kasumi/rte_kasumi_pmd.c\n+++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c\n@@ -574,7 +574,8 @@ cryptodev_kasumi_create(const char *name,\n \t}\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n-\t\t\tsizeof(struct kasumi_private), init_params->socket_id);\n+\t\t\tsizeof(struct kasumi_private), init_params->socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tKASUMI_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\ndiff --git a/drivers/crypto/null/null_crypto_pmd.c b/drivers/crypto/null/null_crypto_pmd.c\nindex 023450a..8124eba 100644\n--- a/drivers/crypto/null/null_crypto_pmd.c\n+++ b/drivers/crypto/null/null_crypto_pmd.c\n@@ -166,6 +166,7 @@ static int cryptodev_null_remove(const char *name);\n /** Create crypto device */\n static int\n cryptodev_null_create(const char *name,\n+\t\tstruct rte_vdev_device *vdev,\n \t\tstruct rte_crypto_vdev_init_params *init_params)\n {\n \tstruct rte_cryptodev *dev;\n@@ -177,12 +178,14 @@ cryptodev_null_create(const char *name,\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n \t\t\tsizeof(struct null_crypto_private),\n-\t\t\tinit_params->socket_id);\n+\t\t\tinit_params->socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tNULL_CRYPTO_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\n \t}\n \n+\tdev->device = &vdev->device;\n \tdev->dev_type = RTE_CRYPTODEV_NULL_PMD;\n \tdev->dev_ops = null_crypto_pmd_ops;\n \n@@ -235,7 +238,7 @@ cryptodev_null_probe(struct rte_vdev_device *dev)\n \tRTE_LOG(INFO, PMD, \" Max number of sessions = %d\\n\",\n \t\t\tinit_params.max_nb_sessions);\n \n-\treturn cryptodev_null_create(name, &init_params);\n+\treturn cryptodev_null_create(name, dev, &init_params);\n }\n \n /** Uninitialise null crypto device */\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex f0c5ca3..13a5129 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -1277,7 +1277,8 @@ cryptodev_openssl_create(const char *name,\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n \t\t\tsizeof(struct openssl_private),\n-\t\t\tinit_params->socket_id);\n+\t\t\tinit_params->socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tOPENSSL_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\ndiff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c\nindex 0b63c20..acec102 100644\n--- a/drivers/crypto/scheduler/scheduler_pmd.c\n+++ b/drivers/crypto/scheduler/scheduler_pmd.c\n@@ -89,7 +89,8 @@ const struct scheduler_parse_map scheduler_ordering_map[] = {\n \n static int\n cryptodev_scheduler_create(const char *name,\n-\tstruct scheduler_init_params *init_params)\n+\t\tstruct rte_vdev_device *vdev,\n+\t\tstruct scheduler_init_params *init_params)\n {\n \tstruct rte_cryptodev *dev;\n \tstruct scheduler_ctx *sched_ctx;\n@@ -103,7 +104,8 @@ cryptodev_scheduler_create(const char *name,\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->def_p.name,\n \t\t\tsizeof(struct scheduler_ctx),\n-\t\t\tinit_params->def_p.socket_id);\n+\t\t\tinit_params->def_p.socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tCS_LOG_ERR(\"driver %s: failed to create cryptodev vdev\",\n \t\t\tname);\n@@ -439,6 +441,7 @@ cryptodev_scheduler_probe(struct rte_vdev_device *vdev)\n \t\t\tinit_params.def_p.name);\n \n \treturn cryptodev_scheduler_create(name,\n+\t\t\t\t\tvdev,\n \t\t\t\t\t&init_params);\n }\n \ndiff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c b/drivers/crypto/snow3g/rte_snow3g_pmd.c\nindex 960956c..f17c541 100644\n--- a/drivers/crypto/snow3g/rte_snow3g_pmd.c\n+++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c\n@@ -563,7 +563,8 @@ cryptodev_snow3g_create(const char *name,\n \t}\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n-\t\t\tsizeof(struct snow3g_private), init_params->socket_id);\n+\t\t\tsizeof(struct snow3g_private), init_params->socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tSNOW3G_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\ndiff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/drivers/crypto/zuc/rte_zuc_pmd.c\nindex 1020544..ab42d06 100644\n--- a/drivers/crypto/zuc/rte_zuc_pmd.c\n+++ b/drivers/crypto/zuc/rte_zuc_pmd.c\n@@ -463,7 +463,8 @@ cryptodev_zuc_create(const char *name,\n \t}\n \n \tdev = rte_cryptodev_pmd_virtual_dev_init(init_params->name,\n-\t\t\tsizeof(struct zuc_private), init_params->socket_id);\n+\t\t\tsizeof(struct zuc_private), init_params->socket_id,\n+\t\t\tvdev);\n \tif (dev == NULL) {\n \t\tZUC_LOG_ERR(\"failed to create cryptodev vdev\");\n \t\tgoto init_error;\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex b65cd9c..edd683c 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -673,7 +673,7 @@ rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev)\n \n struct rte_cryptodev *\n rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size,\n-\t\tint socket_id)\n+\t\tint socket_id, struct rte_vdev_device *vdev)\n {\n \tstruct rte_cryptodev *cryptodev;\n \n@@ -695,6 +695,8 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size,\n \t\t\t\t\t\" data\");\n \t}\n \n+\tcryptodev->device = &vdev->device;\n+\n \t/* initialise user call-back tail queue */\n \tTAILQ_INIT(&(cryptodev->link_intr_cbs));\n \ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex 88aeb87..f307b3b 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -49,6 +49,7 @@ extern \"C\" {\n #include \"rte_crypto.h\"\n #include \"rte_dev.h\"\n #include <rte_common.h>\n+#include <rte_vdev.h>\n \n #define CRYPTODEV_NAME_NULL_PMD\t\tcrypto_null\n /**< Null crypto PMD device name */\ndiff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h\nindex 17ef37c..ec4ca97 100644\n--- a/lib/librte_cryptodev/rte_cryptodev_pmd.h\n+++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h\n@@ -462,6 +462,7 @@ rte_cryptodev_pmd_allocate(const char *name, int socket_id);\n * @param\tname\t\t\tPMD type name\n * @param\tdev_private_size\tSize of crypto PMDs private data\n * @param\tsocket_id\t\tSocket to allocate resources on.\n+ * @param\tvdev\t\t\tPointer to virtual device structure.\n *\n * @return\n * - Cryptodev pointer if device is successfully created.\n@@ -469,7 +470,7 @@ rte_cryptodev_pmd_allocate(const char *name, int socket_id);\n */\n struct rte_cryptodev *\n rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size,\n-\t\tint socket_id);\n+\t\tint socket_id, struct rte_vdev_device *vdev);\n \n \n /**\n", "prefixes": [ "dpdk-dev", "01/12" ] }