Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2451,
    "url": "https://patches.dpdk.org/api/patches/2451/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421883395-27235-13-git-send-email-olivier.matz@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1421883395-27235-13-git-send-email-olivier.matz@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1421883395-27235-13-git-send-email-olivier.matz@6wind.com",
    "date": "2015-01-21T23:36:31",
    "name": "[dpdk-dev,RFC,12/16] testpmd: introduce parse_ipv* in csum fwd engine",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9941dde6f577674e855bcf0eadc7537a6c509bc7",
    "submitter": {
        "id": 8,
        "url": "https://patches.dpdk.org/api/people/8/?format=api",
        "name": "Olivier Matz",
        "email": "olivier.matz@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421883395-27235-13-git-send-email-olivier.matz@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/2451/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/2451/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7ACB75AA1;\n\tThu, 22 Jan 2015 00:37:13 +0100 (CET)",
            "from mail-we0-f180.google.com (mail-we0-f180.google.com\n\t[74.125.82.180]) by dpdk.org (Postfix) with ESMTP id E1D8F5A15\n\tfor <dev@dpdk.org>; Thu, 22 Jan 2015 00:36:57 +0100 (CET)",
            "by mail-we0-f180.google.com with SMTP id m14so20772117wev.11\n\tfor <dev@dpdk.org>; Wed, 21 Jan 2015 15:36:57 -0800 (PST)",
            "from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\twa5sm1710761wjc.8.2015.01.21.15.36.56\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 21 Jan 2015 15:36:57 -0800 (PST)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wm8nwEV/ifrObt8h1EjkZnhrR7sfwDL71HOu95bmVps=;\n\tb=Tql0O4G5QE6UpL/F3fpVR0ZKP9a8HEONmBJU4ndh3PflHmBxaBKhfyJr5hyp3jP005\n\tm/JYqK0v0JvjbSnIQGZRlfqMpO2DGbbAdSOr0dgWa4hKBaD5VUbbLiKijDPdaS//fNLt\n\tjZUaW7kD9J0TmJ5BmSOdTApoBisPLFxyacuRYzqNgqyJ/Cg6WCgE7Mn6xpTQ1UNFdBs7\n\tcg2Kx+JslZ/Rur676uLn1E+iu9dhEPINnoeMAKm7WYAWwRctGSOGssfzE3wEceMFap4N\n\ttdZch+suwlVxYFQkKRPNNazMuf+oJCLdMfYn3gbVw+bhdmRF4/2ULp9g3ydOdXtSob1R\n\tJV2w==",
        "X-Gm-Message-State": "ALoCoQmydhXq2sJLKz8wvri/j/H4Nn/XxvCIyLsBunrv3OILIYFij+vBDdoRAsBxu+mpZHCor9Sj",
        "X-Received": "by 10.194.192.4 with SMTP id hc4mr31045968wjc.59.1421883417798; \n\tWed, 21 Jan 2015 15:36:57 -0800 (PST)",
        "From": "Olivier Matz <olivier.matz@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 22 Jan 2015 00:36:31 +0100",
        "Message-Id": "<1421883395-27235-13-git-send-email-olivier.matz@6wind.com>",
        "X-Mailer": "git-send-email 2.1.3",
        "In-Reply-To": "<1421883395-27235-1-git-send-email-olivier.matz@6wind.com>",
        "References": "<1421883395-27235-1-git-send-email-olivier.matz@6wind.com>",
        "Subject": "[dpdk-dev] [RFC 12/16] testpmd: introduce parse_ipv* in csum fwd\n\tengine",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "These functions may be used to parse encapsulated layers\nwhen we will support IP over GRE tunnels.\n\nNo functional change.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n app/test-pmd/csumonly.c | 51 +++++++++++++++++++++++++++++++++++++------------\n 1 file changed, 39 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 3921643..b023f12 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -104,6 +104,42 @@ get_udptcp_checksum(void *l3_hdr, void *l4_hdr, uint16_t ethertype)\n \t\treturn rte_ipv6_udptcp_cksum(l3_hdr, l4_hdr);\n }\n \n+/* Parse an IPv4 header to fill l3_len, l4_len, and l4_proto */\n+static void\n+parse_ipv4(struct ipv4_hdr *ipv4_hdr, uint16_t *l3_len, uint8_t *l4_proto,\n+\tuint16_t *l4_len)\n+{\n+\tstruct tcp_hdr *tcp_hdr;\n+\n+\t*l3_len = (ipv4_hdr->version_ihl & 0x0f) * 4;\n+\t*l4_proto = ipv4_hdr->next_proto_id;\n+\n+\t/* only fill l4_len for TCP, it's useful for TSO */\n+\tif (*l4_proto == IPPROTO_TCP) {\n+\t\ttcp_hdr = (struct tcp_hdr *)((char *)ipv4_hdr + *l3_len);\n+\t\t*l4_len = (tcp_hdr->data_off & 0xf0) >> 2;\n+\t} else\n+\t\t*l4_len = 0;\n+}\n+\n+/* Parse an IPv6 header to fill l3_len, l4_len, and l4_proto */\n+static void\n+parse_ipv6(struct ipv6_hdr *ipv6_hdr, uint16_t *l3_len, uint8_t *l4_proto,\n+\tuint16_t *l4_len)\n+{\n+\tstruct tcp_hdr *tcp_hdr;\n+\n+\t*l3_len = sizeof(struct ipv6_hdr);\n+\t*l4_proto = ipv6_hdr->proto;\n+\n+\t/* only fill l4_len for TCP, it's useful for TSO */\n+\tif (*l4_proto == IPPROTO_TCP) {\n+\t\ttcp_hdr = (struct tcp_hdr *)((char *)ipv6_hdr + *l3_len);\n+\t\t*l4_len = (tcp_hdr->data_off & 0xf0) >> 2;\n+\t} else\n+\t\t*l4_len = 0;\n+}\n+\n /*\n  * Parse an ethernet header to fill the ethertype, l2_len, l3_len and\n  * ipproto. This function is able to recognize IPv4/IPv6 with one optional vlan\n@@ -115,7 +151,6 @@ parse_ethernet(struct ether_hdr *eth_hdr, uint16_t *ethertype, uint16_t *l2_len,\n {\n \tstruct ipv4_hdr *ipv4_hdr;\n \tstruct ipv6_hdr *ipv6_hdr;\n-\tstruct tcp_hdr *tcp_hdr;\n \n \t*l2_len = sizeof(struct ether_hdr);\n \t*ethertype = eth_hdr->ether_type;\n@@ -130,26 +165,18 @@ parse_ethernet(struct ether_hdr *eth_hdr, uint16_t *ethertype, uint16_t *l2_len,\n \tswitch (*ethertype) {\n \tcase _htons(ETHER_TYPE_IPv4):\n \t\tipv4_hdr = (struct ipv4_hdr *) ((char *)eth_hdr + *l2_len);\n-\t\t*l3_len = (ipv4_hdr->version_ihl & 0x0f) * 4;\n-\t\t*l4_proto = ipv4_hdr->next_proto_id;\n+\t\tparse_ipv4(ipv4_hdr, l3_len, l4_proto, l4_len);\n \t\tbreak;\n \tcase _htons(ETHER_TYPE_IPv6):\n \t\tipv6_hdr = (struct ipv6_hdr *) ((char *)eth_hdr + *l2_len);\n-\t\t*l3_len = sizeof(struct ipv6_hdr);\n-\t\t*l4_proto = ipv6_hdr->proto;\n+\t\tparse_ipv6(ipv6_hdr, l3_len, l4_proto, l4_len);\n \t\tbreak;\n \tdefault:\n+\t\t*l4_len = 0;\n \t\t*l3_len = 0;\n \t\t*l4_proto = 0;\n \t\tbreak;\n \t}\n-\n-\tif (*l4_proto == IPPROTO_TCP) {\n-\t\ttcp_hdr = (struct tcp_hdr *)((char *)eth_hdr +\n-\t\t\t*l2_len + *l3_len);\n-\t\t*l4_len = (tcp_hdr->data_off & 0xf0) >> 2;\n-\t} else\n-\t\t*l4_len = 0;\n }\n \n /* modify the IPv4 or IPv4 source address of a packet */\n",
    "prefixes": [
        "dpdk-dev",
        "RFC",
        "12/16"
    ]
}