Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2444/?format=api
https://patches.dpdk.org/api/patches/2444/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421883395-27235-6-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421883395-27235-6-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421883395-27235-6-git-send-email-olivier.matz@6wind.com", "date": "2015-01-21T23:36:24", "name": "[dpdk-dev,RFC,05/16] mbuf: remove PKT_TX_UDP_TUNNEL_PKT flag", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ce0b73945d93abf1e4d8f15712f8b8af7f6c15ab", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421883395-27235-6-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2444/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 16FCD5AB1;\n\tThu, 22 Jan 2015 00:36:56 +0100 (CET)", "from mail-wg0-f51.google.com (mail-wg0-f51.google.com\n\t[74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 99D405A9D\n\tfor <dev@dpdk.org>; Thu, 22 Jan 2015 00:36:51 +0100 (CET)", "by mail-wg0-f51.google.com with SMTP id l18so20555595wgh.10\n\tfor <dev@dpdk.org>; Wed, 21 Jan 2015 15:36:51 -0800 (PST)", "from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\twa5sm1710761wjc.8.2015.01.21.15.36.50\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 21 Jan 2015 15:36:51 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=7Yn594z7QHoGRttVx++cDGkB+M5Zbc2LXJo9rRvudOI=;\n\tb=Yewz2iy5W88dCmrV8Jsjo5XzbKC7oX+/w3ps6r+QDFP0dyFXXvgNHRyIqHaCQWmkNd\n\t1DJpjtWMHMXhrXiG481E+XFtcpN/cdzvGw0Kpjltm0ZhgXi/Hr0mH6cshMRaFpvevXTG\n\tYm2d0bBYNtPpBDD/EJXNAMzj80jNTXe9MHvGUipnVh5VuvVpCjMRvpUsDBLEgaaSbgb5\n\toGsDDaowDXQLQPy8CWPwm6Q4+ebAMxRO47pm/+c+NWWjgh93XE6Rym6PPBcgp1E8ptt+\n\tgrAhLXACk4VC1Vyo+tCp7tKHJLuwCNYC8fwq3cEb/GrL4cRoTzD8mXox0+3LanQR8L/q\n\tpLwQ==", "X-Gm-Message-State": "ALoCoQmmQ38zMUZaSEp/JxK3GMCsO4c+j9z8X3KTDkG7mQqZAqQxWPpQ29uAgtlO0Ewakdhvr8iR", "X-Received": "by 10.180.160.194 with SMTP id xm2mr45229779wib.77.1421883411487;\n\tWed, 21 Jan 2015 15:36:51 -0800 (PST)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 22 Jan 2015 00:36:24 +0100", "Message-Id": "<1421883395-27235-6-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.3", "In-Reply-To": "<1421883395-27235-1-git-send-email-olivier.matz@6wind.com>", "References": "<1421883395-27235-1-git-send-email-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [RFC 05/16] mbuf: remove PKT_TX_UDP_TUNNEL_PKT flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since previous commit, this flag is not used by any PMD, remove it from\nmbuf API and from csumonly (testpmd). In csumonly, the\nPKT_TX_OUTER_IP_CKSUM flag is already set for vxlan checksum, providing\nenough information to the underlying driver.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n app/test-pmd/csumonly.c | 4 ----\n lib/librte_mbuf/rte_mbuf.c | 1 -\n lib/librte_mbuf/rte_mbuf.h | 5 +----\n 3 files changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 4b438d1..ca5ca39 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -255,9 +255,6 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype,\n \tstruct udp_hdr *udp_hdr;\n \tuint64_t ol_flags = 0;\n \n-\tif (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)\n-\t\tol_flags |= PKT_TX_UDP_TUNNEL_PKT;\n-\n \tif (outer_ethertype == _htons(ETHER_TYPE_IPv4)) {\n \t\tipv4_hdr->hdr_checksum = 0;\n \t\tol_flags |= PKT_TX_OUTER_IPV4;\n@@ -473,7 +470,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)\n \t\t\t\t{ PKT_TX_UDP_CKSUM, PKT_TX_L4_MASK },\n \t\t\t\t{ PKT_TX_TCP_CKSUM, PKT_TX_L4_MASK },\n \t\t\t\t{ PKT_TX_SCTP_CKSUM, PKT_TX_L4_MASK },\n-\t\t\t\t{ PKT_TX_UDP_TUNNEL_PKT, PKT_TX_UDP_TUNNEL_PKT },\n \t\t\t\t{ PKT_TX_IPV4, PKT_TX_IPV4 },\n \t\t\t\t{ PKT_TX_IPV6, PKT_TX_IPV6 },\n \t\t\t\t{ PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IP_CKSUM },\ndiff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 1b14e02..2a4bc8c 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -240,7 +240,6 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask)\n \tcase PKT_TX_SCTP_CKSUM: return \"PKT_TX_SCTP_CKSUM\";\n \tcase PKT_TX_UDP_CKSUM: return \"PKT_TX_UDP_CKSUM\";\n \tcase PKT_TX_IEEE1588_TMST: return \"PKT_TX_IEEE1588_TMST\";\n-\tcase PKT_TX_UDP_TUNNEL_PKT: return \"PKT_TX_UDP_TUNNEL_PKT\";\n \tcase PKT_TX_TCP_SEG: return \"PKT_TX_TCP_SEG\";\n \tcase PKT_TX_IPV4: return \"PKT_TX_IPV4\";\n \tcase PKT_TX_IPV6: return \"PKT_TX_IPV6\";\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 191a42c..d841caa 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -117,11 +117,8 @@ extern \"C\" {\n * and set it in the TCP header. Refer to rte_ipv4_phdr_cksum() and\n * rte_ipv6_phdr_cksum() that can be used as helpers.\n */\n-#define PKT_TX_TCP_SEG (1ULL << 49)\n+#define PKT_TX_TCP_SEG (1ULL << 50)\n \n-/** TX packet is an UDP tunneled packet. It must be specified when using\n- * outer checksum offload (PKT_TX_OUTER_IP_CKSUM) */\n-#define PKT_TX_UDP_TUNNEL_PKT (1ULL << 50) /**< TX packet is an UDP tunneled packet */\n #define PKT_TX_IEEE1588_TMST (1ULL << 51) /**< TX IEEE1588 packet to timestamp. */\n \n /**\n", "prefixes": [ "dpdk-dev", "RFC", "05/16" ] }{ "id": 2444, "url": "