Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 24272,
    "url": "https://patches.dpdk.org/api/patches/24272/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/e8c09e351d137eb6051c7437d8729b0d9b0d6651.1494593926.git.pascal.mazon@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<e8c09e351d137eb6051c7437d8729b0d9b0d6651.1494593926.git.pascal.mazon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/e8c09e351d137eb6051c7437d8729b0d9b0d6651.1494593926.git.pascal.mazon@6wind.com",
    "date": "2017-05-12T13:01:36",
    "name": "[dpdk-dev,v3,1/5] net/tap: add debug messages",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4287484483cd6a91c237b2682b5fbf0c44612838",
    "submitter": {
        "id": 657,
        "url": "https://patches.dpdk.org/api/people/657/?format=api",
        "name": "Pascal Mazon",
        "email": "pascal.mazon@6wind.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/e8c09e351d137eb6051c7437d8729b0d9b0d6651.1494593926.git.pascal.mazon@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/24272/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/24272/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 654D25920;\n\tFri, 12 May 2017 15:02:20 +0200 (CEST)",
            "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 0E4D81C00\n\tfor <dev@dpdk.org>; Fri, 12 May 2017 15:02:16 +0200 (CEST)",
            "from 6wind.com (unknown [10.16.0.184])\n\tby proxy.6wind.com (Postfix) with SMTP id 590AD25337;\n\tFri, 12 May 2017 15:02:09 +0200 (CEST)",
            "by 6wind.com (sSMTP sendmail emulation);\n\tFri, 12 May 2017 15:02:10 +0200"
        ],
        "From": "Pascal Mazon <pascal.mazon@6wind.com>",
        "To": "ferruh.yigit@intel.com,\n\tdev@dpdk.org",
        "Cc": "pascal.mazon@6wind.com",
        "Date": "Fri, 12 May 2017 15:01:36 +0200",
        "Message-Id": "<e8c09e351d137eb6051c7437d8729b0d9b0d6651.1494593926.git.pascal.mazon@6wind.com>",
        "X-Mailer": "git-send-email 2.12.0.306.g4a9b9b3",
        "In-Reply-To": "<cover.1494593926.git.pascal.mazon@6wind.com>",
        "References": "<cover.1492503445.git.pascal.mazon@6wind.com>\n\t<cover.1494593926.git.pascal.mazon@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v3 1/5] net/tap: add debug messages",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Print a detailed debug message inside tap_ioctl() directly. The caller\nnow only needs to check for return value.\n\nSigned-off-by: Pascal Mazon <pascal.mazon@6wind.com>\n---\n drivers/net/tap/rte_eth_tap.c | 37 ++++++++++++++++++++++++-------------\n 1 file changed, 24 insertions(+), 13 deletions(-)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex f1bb55e9769b..3d08ef2ca4d4 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -41,6 +41,7 @@\n #include <rte_vdev.h>\n #include <rte_kvargs.h>\n #include <rte_net.h>\n+#include <rte_debug.h>\n \n #include <sys/types.h>\n #include <sys/stat.h>\n@@ -445,6 +446,24 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \treturn num_tx;\n }\n \n+static const char *\n+tap_ioctl_req2str(unsigned long request)\n+{\n+\tswitch (request) {\n+\tcase SIOCSIFFLAGS:\n+\t\treturn \"SIOCSIFFLAGS\";\n+\tcase SIOCGIFFLAGS:\n+\t\treturn \"SIOCGIFFLAGS\";\n+\tcase SIOCGIFHWADDR:\n+\t\treturn \"SIOCGIFHWADDR\";\n+\tcase SIOCSIFHWADDR:\n+\t\treturn \"SIOCSIFHWADDR\";\n+\tcase SIOCSIFMTU:\n+\t\treturn \"SIOCSIFMTU\";\n+\t}\n+\treturn \"UNKNOWN\";\n+}\n+\n static int\n tap_ioctl(struct pmd_internals *pmd, unsigned long request,\n \t  struct ifreq *ifr, int set, enum ioctl_mode mode)\n@@ -480,9 +499,7 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request,\n \tcase SIOCSIFMTU:\n \t\tbreak;\n \tdefault:\n-\t\tRTE_LOG(WARNING, PMD, \"%s: ioctl() called with wrong arg\\n\",\n-\t\t\tpmd->name);\n-\t\treturn -EINVAL;\n+\t\tRTE_ASSERT(!\"unsupported request type: must not happen\");\n \t}\n \tif (ioctl(pmd->ioctl_sock, request, ifr) < 0)\n \t\tgoto error;\n@@ -491,8 +508,8 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request,\n \treturn 0;\n \n error:\n-\tRTE_LOG(ERR, PMD, \"%s: ioctl(%lu) failed with error: %s\\n\",\n-\t\tifr->ifr_name, request, strerror(errno));\n+\tRTE_LOG(DEBUG, PMD, \"%s: %s(%s) failed: %s(%d)\\n\", ifr->ifr_name,\n+\t\t__func__, tap_ioctl_req2str(request), strerror(errno), errno);\n \treturn -errno;\n }\n \n@@ -774,12 +791,8 @@ tap_mac_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)\n \t\treturn;\n \t}\n \t/* Check the actual current MAC address on the tap netdevice */\n-\tif (tap_ioctl(pmd, SIOCGIFHWADDR, &ifr, 0, LOCAL_ONLY) != 0) {\n-\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\"%s: couldn't check current tap MAC address\\n\",\n-\t\t\tdev->data->name);\n+\tif (tap_ioctl(pmd, SIOCGIFHWADDR, &ifr, 0, LOCAL_ONLY) != 0)\n \t\treturn;\n-\t}\n \tif (is_same_ether_addr((struct ether_addr *)&ifr.ifr_hwaddr.sa_data,\n \t\t\t       mac_addr))\n \t\treturn;\n@@ -1230,10 +1243,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,\n \t\t\t\tremote_iface);\n \t\t\treturn 0;\n \t\t}\n-\t\tif (tap_ioctl(pmd, SIOCGIFHWADDR, &ifr, 0, REMOTE_ONLY) < 0) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Could not get remote MAC address\\n\");\n+\t\tif (tap_ioctl(pmd, SIOCGIFHWADDR, &ifr, 0, REMOTE_ONLY) < 0)\n \t\t\tgoto error_exit;\n-\t\t}\n \t\trte_memcpy(&pmd->eth_addr, ifr.ifr_hwaddr.sa_data,\n \t\t\t   ETHER_ADDR_LEN);\n \t}\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "1/5"
    ]
}