Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2421,
    "url": "https://patches.dpdk.org/api/patches/2421/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421811523-18737-1-git-send-email-changchun.ouyang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1421811523-18737-1-git-send-email-changchun.ouyang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1421811523-18737-1-git-send-email-changchun.ouyang@intel.com",
    "date": "2015-01-21T03:38:43",
    "name": "[dpdk-dev] ixgbe: Fix an unnecessary check in vf rss",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "668209b04c9b43fab2769e5ff942885f5c2afdac",
    "submitter": {
        "id": 31,
        "url": "https://patches.dpdk.org/api/people/31/?format=api",
        "name": "Ouyang Changchun",
        "email": "changchun.ouyang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421811523-18737-1-git-send-email-changchun.ouyang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/2421/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/2421/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3B0CA5A31;\n\tWed, 21 Jan 2015 04:38:54 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 69D535A15\n\tfor <dev@dpdk.org>; Wed, 21 Jan 2015 04:38:51 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 20 Jan 2015 19:38:50 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 20 Jan 2015 19:38:49 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0L3cl9e011860;\n\tWed, 21 Jan 2015 11:38:47 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0L3cjq9018918; Wed, 21 Jan 2015 11:38:47 +0800",
            "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0L3cj3O018914; \n\tWed, 21 Jan 2015 11:38:45 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.09,439,1418112000\"; d=\"scan'208\";a=\"665007039\"",
        "From": "Ouyang Changchun <changchun.ouyang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 21 Jan 2015 11:38:43 +0800",
        "Message-Id": "<1421811523-18737-1-git-send-email-changchun.ouyang@intel.com>",
        "X-Mailer": "git-send-email 1.7.12.2",
        "Subject": "[dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "To follow up the comments from Wodkowski, PawelX, remove this unnecessary check,\nas check_mq_mode has already check the queue number in device configure stage,\nif the queue number of vf is not correct, it will return error code and exit,\nso it doesn't need check again here in device start stage(note: pf_host_configure\nis called in device start stage).\n\nThis fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f\n\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_pf.c | 15 ---------------\n 1 file changed, 15 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c\nindex 93f6e43..dbda9b5 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_pf.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c\n@@ -187,21 +187,6 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)\n \tIXGBE_WRITE_REG(hw, IXGBE_MPSAR_LO(hw->mac.num_rar_entries), 0);\n \tIXGBE_WRITE_REG(hw, IXGBE_MPSAR_HI(hw->mac.num_rar_entries), 0);\n \n-\t/*\n-\t * VF RSS can support at most 4 queues for each VF, even if\n-\t * 8 queues are available for each VF, it need refine to 4\n-\t * queues here due to this limitation, otherwise no queue\n-\t * will receive any packet even RSS is enabled.\n-\t */\n-\tif (eth_dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_VMDQ_RSS) {\n-\t\tif (RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool == 8) {\n-\t\t\tRTE_ETH_DEV_SRIOV(eth_dev).active = ETH_32_POOLS;\n-\t\t\tRTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 4;\n-\t\t\tRTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx =\n-\t\t\t\tdev_num_vf(eth_dev) * 4;\n-\t\t}\n-\t}\n-\n \t/* set VMDq map to default PF pool */\n \thw->mac.ops.set_vmdq(hw, 0, RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx);\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}