Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2410,
    "url": "https://patches.dpdk.org/api/patches/2410/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421779267-18492-3-git-send-email-konstantin.ananyev@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1421779267-18492-3-git-send-email-konstantin.ananyev@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1421779267-18492-3-git-send-email-konstantin.ananyev@intel.com",
    "date": "2015-01-20T18:40:51",
    "name": "[dpdk-dev,v3,02/18] app/test: few small fixes fot test_acl.c",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6071457e1b5bdd353cdd02ad296b69463ec58178",
    "submitter": {
        "id": 33,
        "url": "https://patches.dpdk.org/api/people/33/?format=api",
        "name": "Ananyev, Konstantin",
        "email": "konstantin.ananyev@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421779267-18492-3-git-send-email-konstantin.ananyev@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/2410/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/2410/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3674E5AB9;\n\tTue, 20 Jan 2015 19:41:51 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id B6AC45ACE\n\tfor <dev@dpdk.org>; Tue, 20 Jan 2015 19:41:40 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 20 Jan 2015 10:38:24 -0800",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 20 Jan 2015 10:41:20 -0800",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt0KIfKG4029477; Tue, 20 Jan 2015 18:41:20 GMT",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t0KIfKkP018798;\n\tTue, 20 Jan 2015 18:41:20 GMT",
            "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with  id t0KIfKQq018794;\n\tTue, 20 Jan 2015 18:41:20 GMT"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.09,435,1418112000\"; d=\"scan'208\";a=\"664782653\"",
        "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 20 Jan 2015 18:40:51 +0000",
        "Message-Id": "<1421779267-18492-3-git-send-email-konstantin.ananyev@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com>",
        "References": "<1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 02/18] app/test: few small fixes fot test_acl.c",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Make sure that test_acl would not ignore error conditions.\nRun classify() with all possible values.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n app/test/test_acl.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test/test_acl.c b/app/test/test_acl.c\nindex 356d620..7119ad3 100644\n--- a/app/test/test_acl.c\n+++ b/app/test/test_acl.c\n@@ -111,7 +111,7 @@ test_classify_run(struct rte_acl_ctx *acx)\n \t * these will run quite a few times, it's necessary to test code paths\n \t * from num=0 to num>8\n \t */\n-\tfor (count = 0; count < RTE_DIM(acl_test_data); count++) {\n+\tfor (count = 0; count <= RTE_DIM(acl_test_data); count++) {\n \t\tret = rte_acl_classify(acx, data, results,\n \t\t\t\tcount, RTE_ACL_MAX_CATEGORIES);\n \t\tif (ret != 0) {\n@@ -128,6 +128,7 @@ test_classify_run(struct rte_acl_ctx *acx)\n \t\t\t\t\t\"(expected %\"PRIu32\" got %\"PRIu32\")!\\n\",\n \t\t\t\t\t__LINE__, i, acl_test_data[i].allow,\n \t\t\t\t\tresult);\n+\t\t\t\tret = -EINVAL;\n \t\t\t\tgoto err;\n \t\t\t}\n \t\t}\n@@ -140,6 +141,7 @@ test_classify_run(struct rte_acl_ctx *acx)\n \t\t\t\t\t\"(expected %\"PRIu32\" got %\"PRIu32\")!\\n\",\n \t\t\t\t\t__LINE__, i, acl_test_data[i].deny,\n \t\t\t\t\tresult);\n+\t\t\t\tret = -EINVAL;\n \t\t\t\tgoto err;\n \t\t\t}\n \t\t}\n@@ -150,7 +152,7 @@ test_classify_run(struct rte_acl_ctx *acx)\n \t\t\tRTE_DIM(acl_test_data), RTE_ACL_MAX_CATEGORIES,\n \t\t\tRTE_ACL_CLASSIFY_SCALAR);\n \tif (ret != 0) {\n-\t\tprintf(\"Line %i: SSE classify failed!\\n\", __LINE__);\n+\t\tprintf(\"Line %i: scalar classify failed!\\n\", __LINE__);\n \t\tgoto err;\n \t}\n \n@@ -162,6 +164,7 @@ test_classify_run(struct rte_acl_ctx *acx)\n \t\t\t\t\t\"(expected %\"PRIu32\" got %\"PRIu32\")!\\n\",\n \t\t\t\t\t__LINE__, i, acl_test_data[i].allow,\n \t\t\t\t\tresult);\n+\t\t\tret = -EINVAL;\n \t\t\tgoto err;\n \t\t}\n \t}\n@@ -174,6 +177,7 @@ test_classify_run(struct rte_acl_ctx *acx)\n \t\t\t\t\t\"(expected %\"PRIu32\" got %\"PRIu32\")!\\n\",\n \t\t\t\t\t__LINE__, i, acl_test_data[i].deny,\n \t\t\t\t\tresult);\n+\t\t\tret = -EINVAL;\n \t\t\tgoto err;\n \t\t}\n \t}\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "02/18"
    ]
}