Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2404/?format=api
{ "id": 2404, "url": "https://patches.dpdk.org/api/patches/2404/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421779267-18492-10-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421779267-18492-10-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421779267-18492-10-git-send-email-konstantin.ananyev@intel.com", "date": "2015-01-20T18:40:58", "name": "[dpdk-dev,v3,09/18] librte_acl: a bit of RT code deduplication.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "76a4b2b96271de633f261d2712c2f5bfdd321802", "submitter": { "id": 33, "url": "https://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421779267-18492-10-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2404/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2404/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4A9FE5ABA;\n\tTue, 20 Jan 2015 19:41:35 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 925FD5A9E\n\tfor <dev@dpdk.org>; Tue, 20 Jan 2015 19:41:24 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 20 Jan 2015 10:35:42 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 20 Jan 2015 10:28:04 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt0KIfKVb029495; Tue, 20 Jan 2015 18:41:20 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t0KIfKmL018848;\n\tTue, 20 Jan 2015 18:41:20 GMT", "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with id t0KIfKIK018844;\n\tTue, 20 Jan 2015 18:41:20 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"442827080\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 20 Jan 2015 18:40:58 +0000", "Message-Id": "<1421779267-18492-10-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com>", "References": "<1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 09/18] librte_acl: a bit of RT code\n\tdeduplication.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Move common check for input parameters up into rte_acl_classify_alg().\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_acl/acl_run_scalar.c | 4 ----\n lib/librte_acl/acl_run_sse.c | 4 ----\n lib/librte_acl/rte_acl.c | 19 ++++++++++++-------\n 3 files changed, 12 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/librte_acl/acl_run_scalar.c b/lib/librte_acl/acl_run_scalar.c\nindex 9935125..5be216c 100644\n--- a/lib/librte_acl/acl_run_scalar.c\n+++ b/lib/librte_acl/acl_run_scalar.c\n@@ -147,10 +147,6 @@ rte_acl_classify_scalar(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \tstruct completion cmplt[MAX_SEARCHES_SCALAR];\n \tstruct parms parms[MAX_SEARCHES_SCALAR];\n \n-\tif (categories != 1 &&\n-\t\t((RTE_ACL_RESULTS_MULTIPLIER - 1) & categories) != 0)\n-\t\treturn -EINVAL;\n-\n \tacl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results, num,\n \t\tcategories, ctx->trans_table);\n \ndiff --git a/lib/librte_acl/acl_run_sse.c b/lib/librte_acl/acl_run_sse.c\nindex 576c92b..09e32be 100644\n--- a/lib/librte_acl/acl_run_sse.c\n+++ b/lib/librte_acl/acl_run_sse.c\n@@ -572,10 +572,6 @@ int\n rte_acl_classify_sse(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \tuint32_t *results, uint32_t num, uint32_t categories)\n {\n-\tif (categories != 1 &&\n-\t\t((RTE_ACL_RESULTS_MULTIPLIER - 1) & categories) != 0)\n-\t\treturn -EINVAL;\n-\n \tif (likely(num >= MAX_SEARCHES_SSE8))\n \t\treturn search_sse_8(ctx, data, results, num, categories);\n \telse if (num >= MAX_SEARCHES_SSE4)\ndiff --git a/lib/librte_acl/rte_acl.c b/lib/librte_acl/rte_acl.c\nindex 547e6da..a16c4a4 100644\n--- a/lib/librte_acl/rte_acl.c\n+++ b/lib/librte_acl/rte_acl.c\n@@ -76,20 +76,25 @@ rte_acl_init(void)\n }\n \n int\n-rte_acl_classify(const struct rte_acl_ctx *ctx, const uint8_t **data,\n-\tuint32_t *results, uint32_t num, uint32_t categories)\n-{\n-\treturn classify_fns[ctx->alg](ctx, data, results, num, categories);\n-}\n-\n-int\n rte_acl_classify_alg(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \tuint32_t *results, uint32_t num, uint32_t categories,\n \tenum rte_acl_classify_alg alg)\n {\n+\tif (categories != 1 &&\n+\t\t\t((RTE_ACL_RESULTS_MULTIPLIER - 1) & categories) != 0)\n+\t\treturn -EINVAL;\n+\n \treturn classify_fns[alg](ctx, data, results, num, categories);\n }\n \n+int\n+rte_acl_classify(const struct rte_acl_ctx *ctx, const uint8_t **data,\n+\tuint32_t *results, uint32_t num, uint32_t categories)\n+{\n+\treturn rte_acl_classify_alg(ctx, data, results, num, categories,\n+\t\tctx->alg);\n+}\n+\n struct rte_acl_ctx *\n rte_acl_find_existing(const char *name)\n {\n", "prefixes": [ "dpdk-dev", "v3", "09/18" ] }