Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2397/?format=api
{ "id": 2397, "url": "https://patches.dpdk.org/api/patches/2397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421779267-18492-9-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421779267-18492-9-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421779267-18492-9-git-send-email-konstantin.ananyev@intel.com", "date": "2015-01-20T18:40:57", "name": "[dpdk-dev,v3,08/18] librte_acl: make scalar RT code to be more similar to vector one.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "114b9b374785bbaa9dd302fc5b65ffe18a16df11", "submitter": { "id": 33, "url": "https://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421779267-18492-9-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2397/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2397/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3A5C25AA9;\n\tTue, 20 Jan 2015 19:41:26 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 619B05A95\n\tfor <dev@dpdk.org>; Tue, 20 Jan 2015 19:41:23 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP; 20 Jan 2015 10:41:22 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 20 Jan 2015 10:41:21 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt0KIfKLO029494; Tue, 20 Jan 2015 18:41:20 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t0KIfKhZ018841;\n\tTue, 20 Jan 2015 18:41:20 GMT", "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with id t0KIfKZ5018837;\n\tTue, 20 Jan 2015 18:41:20 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,435,1418112000\"; d=\"scan'208\";a=\"653850311\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 20 Jan 2015 18:40:57 +0000", "Message-Id": "<1421779267-18492-9-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com>", "References": "<1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 08/18] librte_acl: make scalar RT code to be\n\tmore similar to vector one.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make classify_scalar to behave in the same way as it's vector counterpart:\nmove match check out of the inner loop, etc.\nThat makes scalar and vector code look more identical.\nPlus it improves scalar code performance.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_acl/acl_run_scalar.c | 23 +++++++++++++----------\n 1 file changed, 13 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_acl/acl_run_scalar.c b/lib/librte_acl/acl_run_scalar.c\nindex 40691ce..9935125 100644\n--- a/lib/librte_acl/acl_run_scalar.c\n+++ b/lib/librte_acl/acl_run_scalar.c\n@@ -162,31 +162,34 @@ rte_acl_classify_scalar(const struct rte_acl_ctx *ctx, const uint8_t **data,\n \ttransition0 = index_array[0];\n \ttransition1 = index_array[1];\n \n+\twhile ((transition0 | transition1) & RTE_ACL_NODE_MATCH) {\n+\t\ttransition0 = acl_match_check(transition0,\n+\t\t\t0, ctx, parms, &flows, resolve_priority_scalar);\n+\t\ttransition1 = acl_match_check(transition1,\n+\t\t\t1, ctx, parms, &flows, resolve_priority_scalar);\n+\t}\n+\n \twhile (flows.started > 0) {\n \n \t\tinput0 = GET_NEXT_4BYTES(parms, 0);\n \t\tinput1 = GET_NEXT_4BYTES(parms, 1);\n \n \t\tfor (n = 0; n < 4; n++) {\n-\t\t\tif (likely((transition0 & RTE_ACL_NODE_MATCH) == 0))\n-\t\t\t\ttransition0 = scalar_transition(flows.trans,\n-\t\t\t\t\ttransition0, (uint8_t)input0);\n \n+\t\t\ttransition0 = scalar_transition(flows.trans,\n+\t\t\t\ttransition0, (uint8_t)input0);\n \t\t\tinput0 >>= CHAR_BIT;\n \n-\t\t\tif (likely((transition1 & RTE_ACL_NODE_MATCH) == 0))\n-\t\t\t\ttransition1 = scalar_transition(flows.trans,\n-\t\t\t\t\ttransition1, (uint8_t)input1);\n-\n+\t\t\ttransition1 = scalar_transition(flows.trans,\n+\t\t\t\ttransition1, (uint8_t)input1);\n \t\t\tinput1 >>= CHAR_BIT;\n-\n \t\t}\n-\t\tif ((transition0 | transition1) & RTE_ACL_NODE_MATCH) {\n+\n+\t\twhile ((transition0 | transition1) & RTE_ACL_NODE_MATCH) {\n \t\t\ttransition0 = acl_match_check(transition0,\n \t\t\t\t0, ctx, parms, &flows, resolve_priority_scalar);\n \t\t\ttransition1 = acl_match_check(transition1,\n \t\t\t\t1, ctx, parms, &flows, resolve_priority_scalar);\n-\n \t\t}\n \t}\n \treturn 0;\n", "prefixes": [ "dpdk-dev", "v3", "08/18" ] }