Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2355/?format=api
{ "id": 2355, "url": "https://patches.dpdk.org/api/patches/2355/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421637803-17034-15-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421637803-17034-15-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421637803-17034-15-git-send-email-helin.zhang@intel.com", "date": "2015-01-19T03:23:20", "name": "[dpdk-dev,RFC,14/17] examples/l3fwd-acl: support of unified packet type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2274cca7cb6bdc733e4b1dabd130f23b62d0eda4", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421637803-17034-15-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2355/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2355/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 805345AC0;\n\tMon, 19 Jan 2015 04:24:27 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id A0F861288\n\tfor <dev@dpdk.org>; Mon, 19 Jan 2015 04:24:01 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP; 18 Jan 2015 19:24:01 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 18 Jan 2015 19:17:29 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0J3NwAU009430;\n\tMon, 19 Jan 2015 11:23:58 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0J3Ntl6017166; Mon, 19 Jan 2015 11:23:57 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0J3NtNi017162; \n\tMon, 19 Jan 2015 11:23:55 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,424,1418112000\"; d=\"scan'208\";a=\"514108496\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 19 Jan 2015 11:23:20 +0800", "Message-Id": "<1421637803-17034-15-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421637803-17034-1-git-send-email-helin.zhang@intel.com>", "References": "<1421637803-17034-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [RFC 14/17] examples/l3fwd-acl: support of unified\n\tpacket type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To unify packet types among all PMDs, bit masks and relevant macros\nof packet type for ol_flags are replaced by unified packet type and\nrelevant macros.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n examples/l3fwd-acl/main.c | 19 ++++++-------------\n 1 file changed, 6 insertions(+), 13 deletions(-)", "diff": "diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c\nindex 022ccab..89fb55e 100644\n--- a/examples/l3fwd-acl/main.c\n+++ b/examples/l3fwd-acl/main.c\n@@ -651,9 +651,7 @@ prepare_one_packet(struct rte_mbuf **pkts_in, struct acl_search_t *acl,\n \tstruct ipv4_hdr *ipv4_hdr;\n \tstruct rte_mbuf *pkt = pkts_in[index];\n \n-\tint type = pkt->ol_flags & (PKT_RX_IPV4_HDR | PKT_RX_IPV6_HDR);\n-\n-\tif (type == PKT_RX_IPV4_HDR) {\n+\tif (RTE_ETH_IS_IPV4_HDR(pkt->packet_type)) {\n \n \t\tipv4_hdr = (struct ipv4_hdr *)(rte_pktmbuf_mtod(pkt,\n \t\t\tunsigned char *) + sizeof(struct ether_hdr));\n@@ -674,8 +672,7 @@ prepare_one_packet(struct rte_mbuf **pkts_in, struct acl_search_t *acl,\n \t\t\trte_pktmbuf_free(pkt);\n \t\t}\n \n-\t} else if (type == PKT_RX_IPV6_HDR) {\n-\n+\t} else if (RTE_ETH_IS_IPV6_HDR(pkt->packet_type)) {\n \t\t/* Fill acl structure */\n \t\tacl->data_ipv6[acl->num_ipv6] = MBUF_IPV6_2PROTO(pkt);\n \t\tacl->m_ipv6[(acl->num_ipv6)++] = pkt;\n@@ -693,17 +690,13 @@ prepare_one_packet(struct rte_mbuf **pkts_in, struct acl_search_t *acl,\n {\n \tstruct rte_mbuf *pkt = pkts_in[index];\n \n-\tint type = pkt->ol_flags & (PKT_RX_IPV4_HDR | PKT_RX_IPV6_HDR);\n-\n-\tif (type == PKT_RX_IPV4_HDR) {\n-\n+\tif (RTE_ETH_IS_IPV4_HDR(pkt->packet_type)) {\n \t\t/* Fill acl structure */\n \t\tacl->data_ipv4[acl->num_ipv4] = MBUF_IPV4_2PROTO(pkt);\n \t\tacl->m_ipv4[(acl->num_ipv4)++] = pkt;\n \n \n-\t} else if (type == PKT_RX_IPV6_HDR) {\n-\n+\t} else if (RTE_ETH_IS_IPV6_HDR(pkt->packet_type)) {\n \t\t/* Fill acl structure */\n \t\tacl->data_ipv6[acl->num_ipv6] = MBUF_IPV6_2PROTO(pkt);\n \t\tacl->m_ipv6[(acl->num_ipv6)++] = pkt;\n@@ -751,9 +744,9 @@ send_one_packet(struct rte_mbuf *m, uint32_t res)\n \t\t/* in the ACL list, drop it */\n #ifdef L3FWDACL_DEBUG\n \t\tif ((res & ACL_DENY_SIGNATURE) != 0) {\n-\t\t\tif (m->ol_flags & PKT_RX_IPV4_HDR)\n+\t\t\tif (RTE_ETH_IS_IPV4_HDR(m->packet_type))\n \t\t\t\tdump_acl4_rule(m, res);\n-\t\t\telse\n+\t\t\telse if (RTE_ETH_IS_IPV6_HDR(m->packet_type))\n \t\t\t\tdump_acl6_rule(m, res);\n \t\t}\n #endif\n", "prefixes": [ "dpdk-dev", "RFC", "14/17" ] }