Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23427,
    "url": "https://patches.dpdk.org/api/patches/23427/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1491834491-13944-3-git-send-email-mw@semihalf.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1491834491-13944-3-git-send-email-mw@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1491834491-13944-3-git-send-email-mw@semihalf.com",
    "date": "2017-04-10T14:28:09",
    "name": "[dpdk-dev,v2,2/4] net/ena: fix delayed cleanup of Rx descriptors",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ebde0728dee871970b93c9ac79c6e2511199a29d",
    "submitter": {
        "id": 716,
        "url": "https://patches.dpdk.org/api/people/716/?format=api",
        "name": "Marcin Wojtas",
        "email": "mw@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1491834491-13944-3-git-send-email-mw@semihalf.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/23427/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/23427/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CFB16559A;\n\tMon, 10 Apr 2017 16:20:18 +0200 (CEST)",
            "from mail-lf0-f53.google.com (mail-lf0-f53.google.com\n\t[209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 93E4A2C0B\n\tfor <dev@dpdk.org>; Mon, 10 Apr 2017 16:20:14 +0200 (CEST)",
            "by mail-lf0-f53.google.com with SMTP id s141so35970481lfe.3\n\tfor <dev@dpdk.org>; Mon, 10 Apr 2017 07:20:14 -0700 (PDT)",
            "from enkidu.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tn82sm2918528lje.12.2017.04.10.07.20.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 10 Apr 2017 07:20:13 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=UTWpIlCgraitsYBNgd9AuCA3igY9+6yt41mLb/4FQqU=;\n\tb=RM7yVWzJMjo5ULxTP+4G8AEcDhV9oBUmM6A6LbvTActOJUSxRwrVGvoxZpd/G6QB4x\n\t58k588LUz4GpsMayFutxT48isy8GA0NwDH6QvKtyoxLjVtBXQTJLkt67OcR5A6cM/qXZ\n\tTuNv0yIm0OzuBCreK4r9eQkLiC0JgzbEnDUXRij03NoI2d88z0JcrRmYnqhgvhFb5dV6\n\tlWHUiiO/06CVap/i+3rmGJ6+1TgHPKwJbsGVKS+N3U8/4oVY8IW7B/bvt+GlRH6rxt8v\n\tqNPnwl/2IVT6PtxwhHPywVt6BJN7mMiZwQW3kCrKelYO9BnMas6eFuogp58RypyVNqAZ\n\tiDKQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UTWpIlCgraitsYBNgd9AuCA3igY9+6yt41mLb/4FQqU=;\n\tb=LPPMMO6kBH8I5JhfQ3gcvqStvQsD+nwLDjTOPg2vmClH5XhQ6BjdeUycEEv/cgXBeG\n\tPHkYptKIO6wCMrh3mE3MgY/qQuN6ori1c7D9NNxHa6gwcQqGE0+cTOCtMuz/cj9VyUqK\n\t9dG2szuUcv83tMXtlhJ9rpPio2ST61MgagZIUAEtgv7/Jo/A194VtbjdClZLYQRcosCw\n\tBuvW3HRaZx7F8JhwHdm38MJmrCBSwY6ESFQCk/NmKqxndFv4Ied8r7CaCDBKUIjs7rcT\n\tZH6wGAfkDAs1zcoiq3fhJxlNdypx6UaM7HlKIaCrLCGxtbDcXROTeLaPB7luLkHk/5cm\n\trxzg==",
        "X-Gm-Message-State": "AN3rC/5QChFG5zNSUPTyp2hyMxQQfdPn2W+8K86w0o2Xe0JbYijlqf/12lg/TIQS6we0nA==",
        "X-Received": "by 10.25.221.22 with SMTP id u22mr566014lfg.182.1491834013819;\n\tMon, 10 Apr 2017 07:20:13 -0700 (PDT)",
        "From": "Marcin Wojtas <mw@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "jan.medala@outlook.com, jpalider@gmail.com, netanel@amazon.com,\n\tevgenys@amazon.com, matua@amazon.com, gtzalik@amazon.com,\n\tigorch@amazon.com, mw@semihalf.com, mk@semihalf.com",
        "Date": "Mon, 10 Apr 2017 16:28:09 +0200",
        "Message-Id": "<1491834491-13944-3-git-send-email-mw@semihalf.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1491834491-13944-1-git-send-email-mw@semihalf.com>",
        "References": "<1491834491-13944-1-git-send-email-mw@semihalf.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/4] net/ena: fix delayed cleanup of Rx\n\tdescriptors",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Michal Krawczyk <mk@semihalf.com>\n\nOn RX path, after receiving bunch of packets, variable tracking\navailable descriptors in HW queue was not updated.\n\nTo fix this issue, variable tracking used descriptors must be updated\nafter receiving packets - it must be reduced by the amount of received\ndescriptors in current batch.\n\nAdditionally, variable next_to_clean in rx_ring must be updated before\nentering ena_populate_rx_queue() to keep it up to date with the current\nring state.\n\nFixes: 1daff5260ff8 (\"net/ena: use unmasked head and tail\")\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 90cf2ad..b4c713f 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1575,13 +1575,13 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\trecv_idx++;\n \t}\n \n-\tdesc_in_use += 1;\n+\trx_ring->next_to_clean = next_to_clean;\n+\n+\tdesc_in_use = desc_in_use - completed + 1;\n \t/* Burst refill to save doorbells, memory barriers, const interval */\n \tif (ring_size - desc_in_use > ENA_RING_DESCS_RATIO(ring_size))\n \t\tena_populate_rx_queue(rx_ring, ring_size - desc_in_use);\n \n-\trx_ring->next_to_clean = next_to_clean;\n-\n \treturn recv_idx;\n }\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "2/4"
    ]
}