Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2309/?format=api
{ "id": 2309, "url": "https://patches.dpdk.org/api/patches/2309/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421298930-15210-9-git-send-email-changchun.ouyang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421298930-15210-9-git-send-email-changchun.ouyang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421298930-15210-9-git-send-email-changchun.ouyang@intel.com", "date": "2015-01-15T05:15:16", "name": "[dpdk-dev,08/22] virtio: Remove redundant vq_alignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3bc21004cf1df9911be1efe7be89884acc8a49fa", "submitter": { "id": 31, "url": "https://patches.dpdk.org/api/people/31/?format=api", "name": "Ouyang Changchun", "email": "changchun.ouyang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421298930-15210-9-git-send-email-changchun.ouyang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2309/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2309/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 53E6B5A7F;\n\tThu, 15 Jan 2015 06:16:04 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id DF97E5686\n\tfor <dev@dpdk.org>; Thu, 15 Jan 2015 06:15:55 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 14 Jan 2015 21:10:38 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 14 Jan 2015 21:02:59 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0F5FrAU032287;\n\tThu, 15 Jan 2015 13:15:53 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0F5FoLT015300; Thu, 15 Jan 2015 13:15:52 +0800", "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0F5FoGZ015296; \n\tThu, 15 Jan 2015 13:15:50 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"440759248\"", "From": "Ouyang Changchun <changchun.ouyang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 15 Jan 2015 13:15:16 +0800", "Message-Id": "<1421298930-15210-9-git-send-email-changchun.ouyang@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1421298930-15210-1-git-send-email-changchun.ouyang@intel.com>", "References": "<1421298930-15210-1-git-send-email-changchun.ouyang@intel.com>", "Subject": "[dpdk-dev] [PATCH 08/22] virtio: Remove redundant vq_alignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since vq_alignment is constant (always 4K), it does not\nneed to be part of the vring struct.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\n---\n lib/librte_pmd_virtio/virtio_ethdev.c | 1 -\n lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-\n lib/librte_pmd_virtio/virtqueue.h | 3 +--\n 3 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c\nindex c89614d..b7f65b9 100644\n--- a/lib/librte_pmd_virtio/virtio_ethdev.c\n+++ b/lib/librte_pmd_virtio/virtio_ethdev.c\n@@ -294,7 +294,6 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,\n \tvq->port_id = dev->data->port_id;\n \tvq->queue_id = queue_idx;\n \tvq->vq_queue_index = vtpci_queue_idx;\n-\tvq->vq_alignment = VIRTIO_PCI_VRING_ALIGN;\n \tvq->vq_nentries = vq_size;\n \tvq->vq_free_cnt = vq_size;\n \ndiff --git a/lib/librte_pmd_virtio/virtio_rxtx.c b/lib/librte_pmd_virtio/virtio_rxtx.c\nindex 73ad3ac..b44f091 100644\n--- a/lib/librte_pmd_virtio/virtio_rxtx.c\n+++ b/lib/librte_pmd_virtio/virtio_rxtx.c\n@@ -258,7 +258,7 @@ virtio_dev_vring_start(struct virtqueue *vq, int queue_type)\n \t * Reinitialise since virtio port might have been stopped and restarted\n \t */\n \tmemset(vq->vq_ring_virt_mem, 0, vq->vq_ring_size);\n-\tvring_init(vr, size, ring_mem, vq->vq_alignment);\n+\tvring_init(vr, size, ring_mem, VIRTIO_PCI_VRING_ALIGN);\n \tvq->vq_used_cons_idx = 0;\n \tvq->vq_desc_head_idx = 0;\n \tvq->vq_avail_idx = 0;\ndiff --git a/lib/librte_pmd_virtio/virtqueue.h b/lib/librte_pmd_virtio/virtqueue.h\nindex f6ad98d..5b8a255 100644\n--- a/lib/librte_pmd_virtio/virtqueue.h\n+++ b/lib/librte_pmd_virtio/virtqueue.h\n@@ -138,8 +138,7 @@ struct virtqueue {\n \tuint8_t port_id; /**< Device port identifier. */\n \n \tvoid *vq_ring_virt_mem; /**< linear address of vring*/\n-\tint vq_alignment;\n-\tint vq_ring_size;\n+\tunsigned int vq_ring_size;\n \tphys_addr_t vq_ring_mem; /**< physical address of vring */\n \n \tstruct vring vq_ring; /**< vring keeping desc, used and avail */\n", "prefixes": [ "dpdk-dev", "08/22" ] }