Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2279,
    "url": "https://patches.dpdk.org/api/patches/2279/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421298930-15210-7-git-send-email-changchun.ouyang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1421298930-15210-7-git-send-email-changchun.ouyang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1421298930-15210-7-git-send-email-changchun.ouyang@intel.com",
    "date": "2015-01-15T05:15:14",
    "name": "[dpdk-dev,06/22] virtio: Use software vlan stripping",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d06e5d0ad10d19dc937c9674766839b421ca1a35",
    "submitter": {
        "id": 31,
        "url": "https://patches.dpdk.org/api/people/31/?format=api",
        "name": "Ouyang Changchun",
        "email": "changchun.ouyang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421298930-15210-7-git-send-email-changchun.ouyang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/2279/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/2279/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3C2B65A99;\n\tThu, 15 Jan 2015 06:15:59 +0100 (CET)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 62FBB5A8B\n\tfor <dev@dpdk.org>; Thu, 15 Jan 2015 06:15:52 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 14 Jan 2015 21:15:51 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Jan 2015 21:15:50 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0F5Fmpc032106;\n\tThu, 15 Jan 2015 13:15:48 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0F5FjIi015285; Thu, 15 Jan 2015 13:15:47 +0800",
            "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0F5FjjS015281; \n\tThu, 15 Jan 2015 13:15:45 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.09,401,1418112000\"; d=\"scan'208\";a=\"670191934\"",
        "From": "Ouyang Changchun <changchun.ouyang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 15 Jan 2015 13:15:14 +0800",
        "Message-Id": "<1421298930-15210-7-git-send-email-changchun.ouyang@intel.com>",
        "X-Mailer": "git-send-email 1.7.12.2",
        "In-Reply-To": "<1421298930-15210-1-git-send-email-changchun.ouyang@intel.com>",
        "References": "<1421298930-15210-1-git-send-email-changchun.ouyang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 06/22] virtio: Use software vlan stripping",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": null,
    "diff": "diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex f66805d..07d55b8 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -643,6 +643,9 @@ struct rte_eth_rxconf {\n #define ETH_TXQ_FLAGS_NOOFFLOADS \\\n \t\t(ETH_TXQ_FLAGS_NOVLANOFFL | ETH_TXQ_FLAGS_NOXSUMSCTP | \\\n \t\t ETH_TXQ_FLAGS_NOXSUMUDP  | ETH_TXQ_FLAGS_NOXSUMTCP)\n+#define ETH_TXQ_FLAGS_NOXSUMS \\\n+\t\t(ETH_TXQ_FLAGS_NOXSUMSCTP | ETH_TXQ_FLAGS_NOXSUMUDP | \\\n+\t\t ETH_TXQ_FLAGS_NOXSUMTCP)\n /**\n  * A structure used to configure a TX ring of an Ethernet port.\n  */\ndiff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c\nindex d37f2e9..829838c 100644\n--- a/lib/librte_pmd_virtio/virtio_ethdev.c\n+++ b/lib/librte_pmd_virtio/virtio_ethdev.c\n@@ -1064,6 +1064,8 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \t\treturn (-EINVAL);\n \t}\n \n+\thw->vlan_strip = rxmode->hw_vlan_strip;\n+\n \tret = vtpci_irq_config(hw, 0);\n \tif (ret != 0)\n \t\tPMD_DRV_LOG(ERR, \"failed to set config vector\");\ndiff --git a/lib/librte_pmd_virtio/virtio_pci.h b/lib/librte_pmd_virtio/virtio_pci.h\nindex 6998737..6d93fac 100644\n--- a/lib/librte_pmd_virtio/virtio_pci.h\n+++ b/lib/librte_pmd_virtio/virtio_pci.h\n@@ -168,6 +168,7 @@ struct virtio_hw {\n \tuint32_t    max_tx_queues;\n \tuint32_t    max_rx_queues;\n \tuint16_t    vtnet_hdr_size;\n+\tuint8_t\t    vlan_strip;\n \tuint8_t\t    use_msix;\n \tuint8_t     mac_addr[ETHER_ADDR_LEN];\n };\ndiff --git a/lib/librte_pmd_virtio/virtio_rxtx.c b/lib/librte_pmd_virtio/virtio_rxtx.c\nindex f878c62..a5756e1 100644\n--- a/lib/librte_pmd_virtio/virtio_rxtx.c\n+++ b/lib/librte_pmd_virtio/virtio_rxtx.c\n@@ -49,6 +49,7 @@\n #include <rte_prefetch.h>\n #include <rte_string_fns.h>\n #include <rte_errno.h>\n+#include <rte_byteorder.h>\n \n #include \"virtio_logs.h\"\n #include \"virtio_ethdev.h\"\n@@ -408,8 +409,8 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tif ((tx_conf->txq_flags & ETH_TXQ_FLAGS_NOOFFLOADS)\n-\t    != ETH_TXQ_FLAGS_NOOFFLOADS) {\n+\tif ((tx_conf->txq_flags & ETH_TXQ_FLAGS_NOXSUMS)\n+\t    != ETH_TXQ_FLAGS_NOXSUMS) {\n \t\tPMD_INIT_LOG(ERR, \"TX checksum offload not supported\\n\");\n \t\treturn -EINVAL;\n \t}\n@@ -446,6 +447,7 @@ uint16_t\n virtio_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n {\n \tstruct virtqueue *rxvq = rx_queue;\n+\tstruct virtio_hw *hw = rxvq->hw;\n \tstruct rte_mbuf *rxm, *new_mbuf;\n \tuint16_t nb_used, num, nb_rx = 0;\n \tuint32_t len[VIRTIO_MBUF_BURST_SZ];\n@@ -489,6 +491,9 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\trxm->pkt_len = (uint32_t)(len[i] - hdr_size);\n \t\trxm->data_len = (uint16_t)(len[i] - hdr_size);\n \n+\t\tif (hw->vlan_strip)\n+\t\t\trte_vlan_strip(rxm);\n+\n \t\tVIRTIO_DUMP_PACKET(rxm, rxm->data_len);\n \n \t\trx_pkts[nb_rx++] = rxm;\n@@ -717,6 +722,17 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t */\n \t\tif (likely(need <= 0)) {\n \t\t\ttxm = tx_pkts[nb_tx];\n+\n+\t\t\t/* Do VLAN tag insertion */\n+\t\t\tif (txm->ol_flags & PKT_TX_VLAN_PKT) {\n+\t\t\t\terror = rte_vlan_insert(&txm);\n+\t\t\t\tif (unlikely(error)) {\n+\t\t\t\t\trte_pktmbuf_free(txm);\n+\t\t\t\t\t++nb_tx;\n+\t\t\t\t\tcontinue;\n+\t\t\t\t}\n+\t\t\t}\n+\n \t\t\t/* Enqueue Packet buffers */\n \t\t\terror = virtqueue_enqueue_xmit(txvq, txm);\n \t\t\tif (unlikely(error)) {\n",
    "prefixes": [
        "dpdk-dev",
        "06/22"
    ]
}