Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2274/?format=api
{ "id": 2274, "url": "https://patches.dpdk.org/api/patches/2274/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421286361-11504-6-git-send-email-jingjing.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421286361-11504-6-git-send-email-jingjing.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421286361-11504-6-git-send-email-jingjing.wu@intel.com", "date": "2015-01-15T01:46:01", "name": "[dpdk-dev,5/5] ethdev: remove old APIs and structures of 5tuple and 2tuple filters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5d32bbaa7cf8acc548684a36e8e9d3a5533995ee", "submitter": { "id": 47, "url": "https://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421286361-11504-6-git-send-email-jingjing.wu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2274/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2274/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0B1CD5A8E;\n\tThu, 15 Jan 2015 02:46:33 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 6BC945A82\n\tfor <dev@dpdk.org>; Thu, 15 Jan 2015 02:46:19 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP; 14 Jan 2015 17:46:18 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 14 Jan 2015 17:46:18 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0F1kGZE016889;\n\tThu, 15 Jan 2015 09:46:16 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0F1kDxO011574; Thu, 15 Jan 2015 09:46:15 +0800", "(from wujingji@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0F1kDNi011570; \n\tThu, 15 Jan 2015 09:46:13 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,400,1418112000\"; d=\"scan'208\";a=\"651319428\"", "From": "Jingjing Wu <jingjing.wu@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 15 Jan 2015 09:46:01 +0800", "Message-Id": "<1421286361-11504-6-git-send-email-jingjing.wu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421286361-11504-1-git-send-email-jingjing.wu@intel.com>", "References": "<1421286361-11504-1-git-send-email-jingjing.wu@intel.com>", "Subject": "[dpdk-dev] [PATCH 5/5] ethdev: remove old APIs and structures of\n\t5tuple and 2tuple filters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Following structures are removed:\n - rte_2tuple_filter\n - rte_5tuple_filter\nFollowing APIs are removed:\n - rte_eth_dev_add_2tuple_filter\n - rte_eth_dev_remove_2tuple_filter\n - rte_eth_dev_get_2tuple_filter\n - rte_eth_dev_add_5tuple_filter\n - rte_eth_dev_remove_5tuple_filter\n - rte_eth_dev_get_5tuple_filter\nIt also move macros TCP_*_FLAG to rte_eth_ctrl.h, and removes the macro\nTCP_UGR_FLAG which is duplicated with TCP_URG_FLAG.\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/librte_ether/rte_eth_ctrl.h | 7 ++\n lib/librte_ether/rte_ethdev.c | 116 ------------------------\n lib/librte_ether/rte_ethdev.h | 195 ----------------------------------------\n 3 files changed, 7 insertions(+), 311 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h\nindex 58d830d..ab8e9a9 100644\n--- a/lib/librte_ether/rte_eth_ctrl.h\n+++ b/lib/librte_ether/rte_eth_ctrl.h\n@@ -139,6 +139,13 @@ struct rte_eth_ethertype_filter {\n \t\tRTE_NTUPLE_FLAGS_DST_PORT | \\\n \t\tRTE_NTUPLE_FLAGS_PROTO)\n \n+#define TCP_URG_FLAG 0x20\n+#define TCP_ACK_FLAG 0x10\n+#define TCP_PSH_FLAG 0x08\n+#define TCP_RST_FLAG 0x04\n+#define TCP_SYN_FLAG 0x02\n+#define TCP_FIN_FLAG 0x01\n+#define TCP_FLAG_ALL 0x3F\n \n /**\n * A structure used to define the ntuple filter entry\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 95f2ceb..22d76c8 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -3072,122 +3072,6 @@ rte_eth_dev_get_ethertype_filter(uint8_t port_id, uint16_t index,\n }\n \n int\n-rte_eth_dev_add_2tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_2tuple_filter *filter, uint16_t rx_queue)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\tif (filter->protocol != IPPROTO_TCP &&\n-\t\tfilter->tcp_flags != 0){\n-\t\tPMD_DEBUG_TRACE(\"tcp flags is 0x%x, but the protocol value\"\n-\t\t\t\" is not TCP\\n\",\n-\t\t\tfilter->tcp_flags);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->add_2tuple_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->add_2tuple_filter)(dev, index, filter, rx_queue);\n-}\n-\n-int\n-rte_eth_dev_remove_2tuple_filter(uint8_t port_id, uint16_t index)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->remove_2tuple_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->remove_2tuple_filter)(dev, index);\n-}\n-\n-int\n-rte_eth_dev_get_2tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_2tuple_filter *filter, uint16_t *rx_queue)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (filter == NULL || rx_queue == NULL)\n-\t\treturn -EINVAL;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_2tuple_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->get_2tuple_filter)(dev, index, filter, rx_queue);\n-}\n-\n-int\n-rte_eth_dev_add_5tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_5tuple_filter *filter, uint16_t rx_queue)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\n-\tif (filter->protocol != IPPROTO_TCP &&\n-\t\tfilter->tcp_flags != 0){\n-\t\tPMD_DEBUG_TRACE(\"tcp flags is 0x%x, but the protocol value\"\n-\t\t\t\" is not TCP\\n\",\n-\t\t\tfilter->tcp_flags);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->add_5tuple_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->add_5tuple_filter)(dev, index, filter, rx_queue);\n-}\n-\n-int\n-rte_eth_dev_remove_5tuple_filter(uint8_t port_id, uint16_t index)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->remove_5tuple_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->remove_5tuple_filter)(dev, index);\n-}\n-\n-int\n-rte_eth_dev_get_5tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_5tuple_filter *filter, uint16_t *rx_queue)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (filter == NULL || rx_queue == NULL)\n-\t\treturn -EINVAL;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_5tuple_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->get_5tuple_filter)(dev, index, filter,\n-\t\t\t\t\t\trx_queue);\n-}\n-\n-int\n rte_eth_dev_add_flex_filter(uint8_t port_id, uint16_t index,\n \t\t\tstruct rte_flex_filter *filter, uint16_t rx_queue)\n {\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 551b28f..f6adeaa 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -963,16 +963,6 @@ struct rte_eth_dev_callback;\n /** @internal Structure to keep track of registered callbacks */\n TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);\n \n-\n-#define TCP_URG_FLAG 0x20\n-#define TCP_UGR_FLAG 0x20\n-#define TCP_ACK_FLAG 0x10\n-#define TCP_PSH_FLAG 0x08\n-#define TCP_RST_FLAG 0x04\n-#define TCP_SYN_FLAG 0x02\n-#define TCP_FIN_FLAG 0x01\n-#define TCP_FLAG_ALL 0x3F\n-\n /**\n * A structure used to define an ethertype filter.\n */\n@@ -991,18 +981,6 @@ struct rte_syn_filter {\n };\n \n /**\n- * A structure used to define a 2tuple filter.\n- */\n-struct rte_2tuple_filter {\n-\tuint16_t dst_port; /**< big endian. */\n-\tuint8_t protocol;\n-\tuint8_t tcp_flags;\n-\tuint16_t priority; /**< used when more than one filter matches. */\n-\tuint8_t dst_port_mask:1, /**< if mask is 1b, means not compare. */\n-\t\tprotocol_mask:1;\n-};\n-\n-/**\n * A structure used to define a flex filter.\n */\n struct rte_flex_filter {\n@@ -1013,25 +991,6 @@ struct rte_flex_filter {\n \tuint8_t priority;\n };\n \n-/**\n- * A structure used to define a 5tuple filter.\n- */\n-struct rte_5tuple_filter {\n-\tuint32_t dst_ip; /**< destination IP address in big endian. */\n-\tuint32_t src_ip; /**< source IP address in big endian. */\n-\tuint16_t dst_port; /**< destination port in big endian. */\n-\tuint16_t src_port; /**< source Port big endian. */\n-\tuint8_t protocol; /**< l4 protocol. */\n-\tuint8_t tcp_flags; /**< tcp flags. */\n-\tuint16_t priority; /**< seven evels (001b-111b), 111b is highest,\n-\t\t\t\t used when more than one filter matches. */\n-\tuint8_t dst_ip_mask:1, /**< if mask is 1b, do not compare dst ip. */\n-\t\tsrc_ip_mask:1, /**< if mask is 1b, do not compare src ip. */\n-\t\tdst_port_mask:1, /**< if mask is 1b, do not compare dst port. */\n-\t\tsrc_port_mask:1, /**< if mask is 1b, do not compare src port. */\n-\t\tprotocol_mask:1; /**< if mask is 1b, do not compare protocol. */\n-};\n-\n /*\n * Definitions of all functions exported by an Ethernet driver through the\n * the generic structure of type *eth_dev_ops* supplied in the *rte_eth_dev*\n@@ -1388,34 +1347,6 @@ typedef int (*eth_get_ethertype_filter_t)(struct rte_eth_dev *dev,\n \t\t\tuint16_t *rx_queue);\n /**< @internal Get an ethertype filter rule on an Ethernet device */\n \n-typedef int (*eth_add_2tuple_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index, struct rte_2tuple_filter *filter,\n-\t\t\tuint16_t rx_queue);\n-/**< @internal Setup a new 2tuple filter rule on an Ethernet device */\n-\n-typedef int (*eth_remove_2tuple_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index);\n-/**< @internal Remove a 2tuple filter rule on an Ethernet device */\n-\n-typedef int (*eth_get_2tuple_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index, struct rte_2tuple_filter *filter,\n-\t\t\tuint16_t *rx_queue);\n-/**< @internal Get a 2tuple filter rule on an Ethernet device */\n-\n-typedef int (*eth_add_5tuple_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index, struct rte_5tuple_filter *filter,\n-\t\t\tuint16_t rx_queue);\n-/**< @internal Setup a new 5tuple filter rule on an Ethernet device */\n-\n-typedef int (*eth_remove_5tuple_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index);\n-/**< @internal Remove a 5tuple filter rule on an Ethernet device */\n-\n-typedef int (*eth_get_5tuple_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index, struct rte_5tuple_filter *filter,\n-\t\t\tuint16_t *rx_queue);\n-/**< @internal Get a 5tuple filter rule on an Ethernet device */\n-\n typedef int (*eth_add_flex_filter_t)(struct rte_eth_dev *dev,\n \t\t\tuint16_t index, struct rte_flex_filter *filter,\n \t\t\tuint16_t rx_queue);\n@@ -1537,12 +1468,6 @@ struct eth_dev_ops {\n \teth_add_ethertype_filter_t add_ethertype_filter; /**< add ethertype filter. */\n \teth_remove_ethertype_filter_t remove_ethertype_filter; /**< remove ethertype filter. */\n \teth_get_ethertype_filter_t get_ethertype_filter; /**< get ethertype filter. */\n-\teth_add_2tuple_filter_t add_2tuple_filter; /**< add 2tuple filter. */\n-\teth_remove_2tuple_filter_t remove_2tuple_filter; /**< remove 2tuple filter. */\n-\teth_get_2tuple_filter_t get_2tuple_filter; /**< get 2tuple filter. */\n-\teth_add_5tuple_filter_t add_5tuple_filter; /**< add 5tuple filter. */\n-\teth_remove_5tuple_filter_t remove_5tuple_filter; /**< remove 5tuple filter. */\n-\teth_get_5tuple_filter_t get_5tuple_filter; /**< get 5tuple filter. */\n \teth_add_flex_filter_t add_flex_filter; /**< add flex filter. */\n \teth_remove_flex_filter_t remove_flex_filter; /**< remove flex filter. */\n \teth_get_flex_filter_t get_flex_filter; /**< get flex filter. */\n@@ -3538,126 +3463,6 @@ int rte_eth_dev_get_ethertype_filter(uint8_t port_id, uint16_t index,\n \t\t\tstruct rte_ethertype_filter *filter, uint16_t *rx_queue);\n \n /**\n- * Add a new 2tuple filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of 2tuple filter.\n- * @param filter\n- * The pointer to the structure describing the 2tuple filter rule.\n- * The *rte_2tuple_filter* structure includes the values of the different\n- * fields to match: protocol, dst_port and\n- * tcp_flags if the protocol is tcp type.\n- * @param rx_queue\n- * The index of the RX queue where to store RX packets matching the added\n- * 2tuple filter.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support 2tuple filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- */\n-int rte_eth_dev_add_2tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_2tuple_filter *filter, uint16_t rx_queue);\n-\n-/**\n- * remove a 2tuple filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of 2tuple filter.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support 2tuple filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- */\n-int rte_eth_dev_remove_2tuple_filter(uint8_t port_id, uint16_t index);\n-\n-/**\n- * Get an 2tuple filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of 2tuple filter.\n- * @param filter\n- * A pointer to a structure of type *rte_2tuple_filter* to be filled with\n- * the information of the 2tuple filter.\n- * @param rx_queue\n- * A pointer to get the queue index.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support 2tuple filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- * - (-ENOENT) if no enabled filter in this index.\n- */\n-int rte_eth_dev_get_2tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_2tuple_filter *filter, uint16_t *rx_queue);\n-\n-/**\n- * Add a new 5tuple filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of 5tuple filter.\n- * @param filter\n- * The pointer to the structure describing the 5tuple filter rule.\n- * The *rte_5tuple_filter* structure includes the values of the different\n- * fields to match: dst src IP, dst src port, protocol and relative masks\n- * @param rx_queue\n- * The index of the RX queue where to store RX packets matching the added\n- * 5tuple filter.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support 5tuple filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- */\n-int rte_eth_dev_add_5tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_5tuple_filter *filter, uint16_t rx_queue);\n-\n-/**\n- * remove a 5tuple filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of 5tuple filter.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support 5tuple filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- */\n-int rte_eth_dev_remove_5tuple_filter(uint8_t port_id, uint16_t index);\n-\n-/**\n- * Get an 5tuple filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of 5tuple filter.\n- * @param filter\n- * A pointer to a structure of type *rte_5tuple_filter* to be filled with\n- * the information of the 5tuple filter.\n- * @param rx_queue\n- * A pointer to get the queue index.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support 5tuple filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- */\n-int rte_eth_dev_get_5tuple_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_5tuple_filter *filter, uint16_t *rx_queue);\n-\n-/**\n * Add a new flex filter rule on an Ethernet device.\n *\n * @param port_id\n", "prefixes": [ "dpdk-dev", "5/5" ] }