Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2249/?format=api
{ "id": 2249, "url": "https://patches.dpdk.org/api/patches/2249/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421090181-17150-4-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421090181-17150-4-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421090181-17150-4-git-send-email-konstantin.ananyev@intel.com", "date": "2015-01-12T19:16:07", "name": "[dpdk-dev,v2,03/17] librte_acl: make data_indexes long enough to survive idle transitions.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "007e910166b0a4457366c91f6d112cde33f5411e", "submitter": { "id": 33, "url": "https://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421090181-17150-4-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2249/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2249/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2D3475AAC;\n\tMon, 12 Jan 2015 20:16:41 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id B8C6E5A7E\n\tfor <dev@dpdk.org>; Mon, 12 Jan 2015 20:16:37 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 12 Jan 2015 11:16:36 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 12 Jan 2015 11:10:31 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt0CJGZpk008615; Mon, 12 Jan 2015 19:16:35 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t0CJGZ34017221;\n\tMon, 12 Jan 2015 19:16:35 GMT", "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with id t0CJGZiv017217;\n\tMon, 12 Jan 2015 19:16:35 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,691,1406617200\"; d=\"scan'208\";a=\"511102605\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 12 Jan 2015 19:16:07 +0000", "Message-Id": "<1421090181-17150-4-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421090181-17150-1-git-send-email-konstantin.ananyev@intel.com>", "References": "<1421090181-17150-1-git-send-email-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 03/17] librte_acl: make data_indexes long\n\tenough to survive idle transitions.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make data_indexes long enough to survive idle transitions.\nThat allows to simplify match processing code.\nAlso fix incorrect size calculations for data indexes.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_acl/acl_bld.c | 5 +++--\n lib/librte_acl/acl_run.h | 4 ----\n 2 files changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c\nindex d6e0c45..c5a674a 100644\n--- a/lib/librte_acl/acl_bld.c\n+++ b/lib/librte_acl/acl_bld.c\n@@ -1948,7 +1948,7 @@ acl_set_data_indexes(struct rte_acl_ctx *ctx)\n \t\tmemcpy(ctx->data_indexes + ofs, ctx->trie[i].data_index,\n \t\t\tn * sizeof(ctx->data_indexes[0]));\n \t\tctx->trie[i].data_index = ctx->data_indexes + ofs;\n-\t\tofs += n;\n+\t\tofs += RTE_ACL_MAX_FIELDS;\n \t}\n }\n \n@@ -1988,7 +1988,8 @@ rte_acl_build(struct rte_acl_ctx *ctx, const struct rte_acl_config *cfg)\n \t\t/* allocate and fill run-time structures. */\n \t\trc = rte_acl_gen(ctx, bcx.tries, bcx.bld_tries,\n \t\t\t\tbcx.num_tries, bcx.cfg.num_categories,\n-\t\t\t\tRTE_ACL_IPV4VLAN_NUM * RTE_DIM(bcx.tries),\n+\t\t\t\tRTE_ACL_MAX_FIELDS * RTE_DIM(bcx.tries) *\n+\t\t\t\tsizeof(ctx->data_indexes[0]),\n \t\t\t\tbcx.num_build_rules);\n \t\tif (rc == 0) {\n \ndiff --git a/lib/librte_acl/acl_run.h b/lib/librte_acl/acl_run.h\nindex c191053..4c843c1 100644\n--- a/lib/librte_acl/acl_run.h\n+++ b/lib/librte_acl/acl_run.h\n@@ -256,10 +256,6 @@ acl_match_check(uint64_t transition, int slot,\n \n \t\t/* Fill the slot with the next trie or idle trie */\n \t\ttransition = acl_start_next_trie(flows, parms, slot, ctx);\n-\n-\t} else if (transition == ctx->idle) {\n-\t\t/* reset indirection table for idle slots */\n-\t\tparms[slot].data_index = idle;\n \t}\n \n \treturn transition;\n", "prefixes": [ "dpdk-dev", "v2", "03/17" ] }