Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2247/?format=api
{ "id": 2247, "url": "https://patches.dpdk.org/api/patches/2247/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421080446-19249-12-git-send-email-sergio.gonzalez.monroy@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421080446-19249-12-git-send-email-sergio.gonzalez.monroy@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421080446-19249-12-git-send-email-sergio.gonzalez.monroy@intel.com", "date": "2015-01-12T16:34:04", "name": "[dpdk-dev,RFC,11/13] mk: Use LDLIBS when linking shared libraries", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "28b29e27bc5f0a8cbf5b5718320cc50e50bd3bf2", "submitter": { "id": 73, "url": "https://patches.dpdk.org/api/people/73/?format=api", "name": "Sergio Gonzalez Monroy", "email": "sergio.gonzalez.monroy@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421080446-19249-12-git-send-email-sergio.gonzalez.monroy@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2247/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2247/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0500F5B06;\n\tMon, 12 Jan 2015 17:35:12 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id ED40D5AD2\n\tfor <dev@dpdk.org>; Mon, 12 Jan 2015 17:34:18 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 12 Jan 2015 08:31:36 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2015 08:21:27 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt0CGYDgr022041 for <dev@dpdk.org>; Mon, 12 Jan 2015 16:34:13 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t0CGYC1Q019371\n\tfor <dev@dpdk.org>; Mon, 12 Jan 2015 16:34:12 GMT", "(from smonroy@localhost)\n\tby sivswdev02.ir.intel.com with id t0CGYCmZ019366\n\tfor dev@dpdk.org; Mon, 12 Jan 2015 16:34:12 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"439523200\"", "From": "Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 12 Jan 2015 16:34:04 +0000", "Message-Id": "<1421080446-19249-12-git-send-email-sergio.gonzalez.monroy@intel.com>", "X-Mailer": "git-send-email 1.8.5.4", "In-Reply-To": "<1421080446-19249-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "References": "<1421080446-19249-1-git-send-email-sergio.gonzalez.monroy@intel.com>", "Subject": "[dpdk-dev] [PATCH RFC 11/13] mk: Use LDLIBS when linking shared\n\tlibraries", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch mainly makes use of the LDLIBS variable when linking shared\nlibraries, setting proper DT_NEEDED entries.\nThis patch also fix a few nits like syntax highlighting, the command\nstring (O_TO_S_STR) used for linking shared libraries and the displayed\nof dependencies when debugging is enable (D).\n\nSigned-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>\n---\n mk/rte.lib.mk | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex 7c99fd1..559c76a 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -59,16 +59,19 @@ build: _postbuild\n \n exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))\n \n+_LDLIBS := -z defs --as-needed $(LDLIBS) $(EXECENV_LDLIBS) --no-as-needed\n+\n ifeq ($(LINK_USING_CC),1)\n # Override the definition of LD here, since we're linking with CC\n LD := $(CC) $(CPU_CFLAGS)\n _CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))\n+_LDLIBS := $(call linkerprefix,$(_LDLIBS))\n else\n _CPU_LDFLAGS := $(CPU_LDFLAGS)\n endif\n \n O_TO_A = $(AR) crus $(LIB) $(OBJS-y)\n-O_TO_A_STR = $(subst ','\\'',$(O_TO_A)) #'# fix syntax highlight\n+O_TO_A_STR = $(subst ','\\'',$(O_TO_A)) #')# fix syntax highlight\n O_TO_A_DISP = $(if $(V),\"$(O_TO_A_STR)\",\" AR $(@)\")\n O_TO_A_CMD = \"cmd_$@ = $(O_TO_A_STR)\"\n O_TO_A_DO = @set -e; \\\n@@ -76,9 +79,11 @@ O_TO_A_DO = @set -e; \\\n \t$(O_TO_A) && \\\n \techo $(O_TO_A_CMD) > $(call exe2cmd,$(@))\n \n-O_TO_S = $(LD) $(_CPU_LDFLAGS) -shared $(OBJS-y) -o $(LIB)\n-O_TO_S_STR = $(subst ','\\'',$(O_TO_S)) #'# fix syntax highlight\n+O_TO_S = $(LD) $(_CPU_LDFLAGS) -L $(RTE_OUTPUT)/lib \\\n+\t\t -shared $(OBJS-y) $(_LDLIBS) -o $(LIB)\n+O_TO_S_STR = $(subst ','\\'',$(O_TO_S)) #')# fix syntax highlight\n O_TO_S_DISP = $(if $(V),\"$(O_TO_S_STR)\",\" LD $(@)\")\n+O_TO_S_CMD = \"cmd_$@ = $(O_TO_S_STR)\"\n O_TO_S_DO = @set -e; \\\n \techo $(O_TO_S_DISP); \\\n \t$(O_TO_S) && \\\n@@ -93,7 +98,7 @@ ifeq ($(RTE_BUILD_SHARED_LIB),y)\n $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE\n \t@[ -d $(dir $@) ] || mkdir -p $(dir $@)\n \t$(if $(D),\\\n-\t\t@echo -n \"$< -> $@ \" ; \\\n+\t\t@echo -n \"$? -> $@ \" ; \\\n \t\techo -n \"file_missing=$(call boolean,$(file_missing)) \" ; \\\n \t\techo -n \"cmdline_changed=$(call boolean,$(call cmdline_changed,$(O_TO_S_STR))) \" ; \\\n \t\techo -n \"depfile_missing=$(call boolean,$(depfile_missing)) \" ; \\\n@@ -108,7 +113,7 @@ else\n $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE\n \t@[ -d $(dir $@) ] || mkdir -p $(dir $@)\n \t$(if $(D),\\\n-\t @echo -n \"$< -> $@ \" ; \\\n+\t @echo -n \"$? -> $@ \" ; \\\n \t echo -n \"file_missing=$(call boolean,$(file_missing)) \" ; \\\n \t echo -n \"cmdline_changed=$(call boolean,$(call cmdline_changed,$(O_TO_A_STR))) \" ; \\\n \t echo -n \"depfile_missing=$(call boolean,$(depfile_missing)) \" ; \\\n", "prefixes": [ "dpdk-dev", "RFC", "11/13" ] }