Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2234/?format=api
{ "id": 2234, "url": "https://patches.dpdk.org/api/patches/2234/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1421046973-23283-5-git-send-email-jingjing.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1421046973-23283-5-git-send-email-jingjing.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1421046973-23283-5-git-send-email-jingjing.wu@intel.com", "date": "2015-01-12T07:16:13", "name": "[dpdk-dev,v2,4/4] ethdev: remove old APIs and structures of ethertype filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3fcf439affa265a37b77ce0f401e3250f44486cd", "submitter": { "id": 47, "url": "https://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1421046973-23283-5-git-send-email-jingjing.wu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2234/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2234/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CF6985AA4;\n\tMon, 12 Jan 2015 08:16:49 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 2BDFA5A9B\n\tfor <dev@dpdk.org>; Mon, 12 Jan 2015 08:16:32 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 11 Jan 2015 23:16:31 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 11 Jan 2015 23:16:31 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t0C7GTQD007247;\n\tMon, 12 Jan 2015 15:16:29 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t0C7GQWJ023346; Mon, 12 Jan 2015 15:16:28 +0800", "(from wujingji@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0C7GQr0023342; \n\tMon, 12 Jan 2015 15:16:26 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,742,1413270000\"; d=\"scan'208\";a=\"668289527\"", "From": "Jingjing Wu <jingjing.wu@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 12 Jan 2015 15:16:13 +0800", "Message-Id": "<1421046973-23283-5-git-send-email-jingjing.wu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1421046973-23283-1-git-send-email-jingjing.wu@intel.com>", "References": "<1419477270-14611-1-git-send-email-jingjing.wu@intel.com>\n\t<1421046973-23283-1-git-send-email-jingjing.wu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 4/4] ethdev: remove old APIs and structures of\n\tethertype filter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Structure rte_ethertype_filter is removed.\nFollowing APIs are removed:\n - rte_eth_dev_add_ethertype_filter\n - rte_eth_dev_remove_ethertype_filter\n - rte_eth_dev_get_ethertype_filter\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/librte_ether/rte_ethdev.c | 57 ----------------------------\n lib/librte_ether/rte_ethdev.h | 88 -------------------------------------------\n 2 files changed, 145 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 95f2ceb..b55fab2 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -3015,63 +3015,6 @@ rte_eth_dev_get_syn_filter(uint8_t port_id,\n }\n \n int\n-rte_eth_dev_add_ethertype_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_ethertype_filter *filter, uint16_t rx_queue)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\tif (filter->ethertype == ETHER_TYPE_IPv4 ||\n-\t\tfilter->ethertype == ETHER_TYPE_IPv6){\n-\t\tPMD_DEBUG_TRACE(\"IP and IPv6 are not supported\"\n-\t\t\t\" in ethertype filter\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->add_ethertype_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->add_ethertype_filter)(dev, index,\n-\t\t\t\t\tfilter, rx_queue);\n-}\n-\n-int\n-rte_eth_dev_remove_ethertype_filter(uint8_t port_id, uint16_t index)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->remove_ethertype_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->remove_ethertype_filter)(dev, index);\n-}\n-\n-int\n-rte_eth_dev_get_ethertype_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_ethertype_filter *filter, uint16_t *rx_queue)\n-{\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (filter == NULL || rx_queue == NULL)\n-\t\treturn -EINVAL;\n-\n-\tif (port_id >= nb_ports) {\n-\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n-\t\treturn -ENODEV;\n-\t}\n-\n-\tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_ethertype_filter, -ENOTSUP);\n-\treturn (*dev->dev_ops->get_ethertype_filter)(dev, index,\n-\t\t\t\t\t\tfilter, rx_queue);\n-}\n-\n-int\n rte_eth_dev_add_2tuple_filter(uint8_t port_id, uint16_t index,\n \t\t\tstruct rte_2tuple_filter *filter, uint16_t rx_queue)\n {\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex ce0528f..1200c1c 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -972,15 +972,6 @@ TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);\n #define TCP_FLAG_ALL 0x3F\n \n /**\n- * A structure used to define an ethertype filter.\n- */\n-struct rte_ethertype_filter {\n-\tuint16_t ethertype; /**< little endian. */\n-\tuint8_t priority_en; /**< compare priority enable. */\n-\tuint8_t priority;\n-};\n-\n-/**\n * A structure used to define an syn filter.\n */\n struct rte_syn_filter {\n@@ -1372,20 +1363,6 @@ typedef int (*eth_get_syn_filter_t)(struct rte_eth_dev *dev,\n \t\t\tstruct rte_syn_filter *filter, uint16_t *rx_queue);\n /**< @internal Get syn filter rule on an Ethernet device */\n \n-typedef int (*eth_add_ethertype_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index, struct rte_ethertype_filter *filter,\n-\t\t\tuint16_t rx_queue);\n-/**< @internal Setup a new ethertype filter rule on an Ethernet device */\n-\n-typedef int (*eth_remove_ethertype_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index);\n-/**< @internal Remove an ethertype filter rule on an Ethernet device */\n-\n-typedef int (*eth_get_ethertype_filter_t)(struct rte_eth_dev *dev,\n-\t\t\tuint16_t index, struct rte_ethertype_filter *filter,\n-\t\t\tuint16_t *rx_queue);\n-/**< @internal Get an ethertype filter rule on an Ethernet device */\n-\n typedef int (*eth_add_2tuple_filter_t)(struct rte_eth_dev *dev,\n \t\t\tuint16_t index, struct rte_2tuple_filter *filter,\n \t\t\tuint16_t rx_queue);\n@@ -1532,9 +1509,6 @@ struct eth_dev_ops {\n \teth_add_syn_filter_t add_syn_filter; /**< add syn filter. */\n \teth_remove_syn_filter_t remove_syn_filter; /**< remove syn filter. */\n \teth_get_syn_filter_t get_syn_filter; /**< get syn filter. */\n-\teth_add_ethertype_filter_t add_ethertype_filter; /**< add ethertype filter. */\n-\teth_remove_ethertype_filter_t remove_ethertype_filter; /**< remove ethertype filter. */\n-\teth_get_ethertype_filter_t get_ethertype_filter; /**< get ethertype filter. */\n \teth_add_2tuple_filter_t add_2tuple_filter; /**< add 2tuple filter. */\n \teth_remove_2tuple_filter_t remove_2tuple_filter; /**< remove 2tuple filter. */\n \teth_get_2tuple_filter_t get_2tuple_filter; /**< get 2tuple filter. */\n@@ -3474,68 +3448,6 @@ int rte_eth_dev_get_syn_filter(uint8_t port_id,\n \t\t\tstruct rte_syn_filter *filter, uint16_t *rx_queue);\n \n /**\n- * Add a new ethertype filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of ethertype filter.\n- * @param filter\n- * The pointer to the structure describing the ethertype filter rule.\n- * The *rte_ethertype_filter* structure includes the values of the different\n- * fields to match: ethertype and priority in vlan tag.\n- * priority in vlan tag is not supported for E1000 dev.\n- * @param rx_queue\n- * The index of the RX queue where to store RX packets matching the added\n- * ethertype filter.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support ethertype filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- */\n-int rte_eth_dev_add_ethertype_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_ethertype_filter *filter, uint16_t rx_queue);\n-\n-/**\n- * remove an ethertype filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of ethertype filter.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support ethertype filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- */\n-int rte_eth_dev_remove_ethertype_filter(uint8_t port_id,\n-\t\t\tuint16_t index);\n-\n-/**\n- * Get an ethertype filter rule on an Ethernet device.\n- *\n- * @param port_id\n- * The port identifier of the Ethernet device.\n- * @param index\n- * The identifier of ethertype filter.\n- * @param filter\n- * A pointer to a structure of type *rte_ethertype_filter* to be filled with\n- * the information of the Ethertype filter.\n- * @param rx_queue\n- * A pointer to get the queue index.\n- * @return\n- * - (0) if successful.\n- * - (-ENOTSUP) if hardware doesn't support ethertype filter.\n- * - (-ENODEV) if *port_id* invalid.\n- * - (-EINVAL) if the filter information is not correct.\n- * - (-ENOENT) if no enabled filter in this index.\n- */\n-int rte_eth_dev_get_ethertype_filter(uint8_t port_id, uint16_t index,\n-\t\t\tstruct rte_ethertype_filter *filter, uint16_t *rx_queue);\n-\n-/**\n * Add a new 2tuple filter rule on an Ethernet device.\n *\n * @param port_id\n", "prefixes": [ "dpdk-dev", "v2", "4/4" ] }