Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/22216/?format=api
{ "id": 22216, "url": "https://patches.dpdk.org/api/patches/22216/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1490340531-11403-16-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1490340531-11403-16-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1490340531-11403-16-git-send-email-rasesh.mody@cavium.com", "date": "2017-03-24T07:28:05", "name": "[dpdk-dev,v3,15/61] net/qede/base: prevent device init failure", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b26e51e20c3d19a8561208159f59e1df142409bf", "submitter": { "id": 569, "url": "https://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1490340531-11403-16-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/22216/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/22216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 20ADBCFA2;\n\tFri, 24 Mar 2017 08:32:31 +0100 (CET)", "from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com\n\t[67.231.148.157]) by dpdk.org (Postfix) with ESMTP id C2098CFBA\n\tfor <dev@dpdk.org>; Fri, 24 Mar 2017 08:30:32 +0100 (CET)", "from pps.filterd (m0095336.ppops.net [127.0.0.1])\n\tby mx0a-0016ce01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv2O7Q5WT009385; Fri, 24 Mar 2017 00:30:30 -0700", "from avcashub1.qlogic.com ([198.186.0.115])\n\tby mx0a-0016ce01.pphosted.com with ESMTP id 29b9xy1bkx-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tFri, 24 Mar 2017 00:30:30 -0700", "from avluser05.qlc.com (10.1.113.115) by avcashub1.qlogic.org\n\t(10.1.4.190) with Microsoft SMTP Server (TLS) id 14.3.235.1;\n\tFri, 24 Mar 2017 00:30:30 -0700", "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid v2O7UUUU011633;\tFri, 24 Mar 2017 00:30:30 -0700" ], "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@cavium.com using -f", "From": "Rasesh Mody <rasesh.mody@cavium.com>", "To": "<ferruh.yigit@intel.com>, <dev@dpdk.org>", "CC": "Rasesh Mody <rasesh.mody@cavium.com>, <Dept-EngDPDKDev@cavium.com>", "Date": "Fri, 24 Mar 2017 00:28:05 -0700", "Message-ID": "<1490340531-11403-16-git-send-email-rasesh.mody@cavium.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<dd51cd87-72b4-fa89-3dc1-b79c32df1355@intel.com>", "References": "<dd51cd87-72b4-fa89-3dc1-b79c32df1355@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8476\n\tsignatures=668449", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1702020001\n\tdefinitions=main-1703240067", "Subject": "[dpdk-dev] [PATCH v3 15/61] net/qede/base: prevent device init\n\tfailure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Device initialization flow should not be failed because the FW interface\ncommand is not available.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_dev.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c\nindex 13e13ba..7494f93 100644\n--- a/drivers/net/qede/base/ecore_dev.c\n+++ b/drivers/net/qede/base/ecore_dev.c\n@@ -1778,18 +1778,20 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev,\n \t\trc = ecore_mcp_cmd(p_hwfn, p_hwfn->p_main_ptt,\n \t\t\t\t DRV_MSG_CODE_OV_UPDATE_STORM_FW_VER,\n \t\t\t\t drv_mb_param, &load_code, ¶m);\n-\t\tif (rc != ECORE_SUCCESS) {\n-\t\t\tDP_ERR(p_hwfn, \"Failed to send firmware version\\n\");\n-\t\t\treturn rc;\n-\t\t}\n+\t\tif (rc != ECORE_SUCCESS)\n+\t\t\tDP_INFO(p_hwfn, \"Failed to update firmware version\\n\");\n \n \t\tif (!b_default_mtu)\n-\t\t\tecore_mcp_ov_update_mtu(p_hwfn, p_hwfn->p_main_ptt,\n-\t\t\t\t\t\tp_hwfn->hw_info.mtu);\n+\t\t\trc = ecore_mcp_ov_update_mtu(p_hwfn, p_hwfn->p_main_ptt,\n+\t\t\t\t\t\t p_hwfn->hw_info.mtu);\n+\t\tif (rc != ECORE_SUCCESS)\n+\t\t\tDP_INFO(p_hwfn, \"Failed to update default mtu\\n\");\n \n \t\trc = ecore_mcp_ov_update_driver_state(p_hwfn,\n \t\t\t\t\t\t p_hwfn->p_main_ptt,\n \t\t\t\t\t\tECORE_OV_DRIVER_STATE_DISABLED);\n+\t\tif (rc != ECORE_SUCCESS)\n+\t\t\tDP_INFO(p_hwfn, \"Failed to update driver state\\n\");\n \t}\n \n \treturn rc;\n", "prefixes": [ "dpdk-dev", "v3", "15/61" ] }