Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2216,
    "url": "https://patches.dpdk.org/api/patches/2216/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1420635809-30976-2-git-send-email-david.marchand@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1420635809-30976-2-git-send-email-david.marchand@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1420635809-30976-2-git-send-email-david.marchand@6wind.com",
    "date": "2015-01-07T13:03:28",
    "name": "[dpdk-dev,1/2] devargs: indent and cleanup",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "03781c418726c7ef1ab64d4a442d4a50b0821200",
    "submitter": {
        "id": 3,
        "url": "https://patches.dpdk.org/api/people/3/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1420635809-30976-2-git-send-email-david.marchand@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/2216/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/2216/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B33375A6B;\n\tWed,  7 Jan 2015 14:03:39 +0100 (CET)",
            "from mail-wg0-f41.google.com (mail-wg0-f41.google.com\n\t[74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 8F8745A66\n\tfor <dev@dpdk.org>; Wed,  7 Jan 2015 14:03:37 +0100 (CET)",
            "by mail-wg0-f41.google.com with SMTP id l18so1156930wgh.0\n\tfor <dev@dpdk.org>; Wed, 07 Jan 2015 05:03:37 -0800 (PST)",
            "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\teu8sm2476343wib.21.2015.01.07.05.03.35 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 07 Jan 2015 05:03:36 -0800 (PST)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vwe5ViVz7fIiespbpIbLBc9UgosaI6xGf0EgHaizTtY=;\n\tb=TksneaLcHSr86/iyeDzjn9T5xXpJtl9IUqKIEXl1zFEdiUTCgbqFXSnH+Yl7pBfAdX\n\t1r8ykyT5j0qhqRh6SW0NOxQ741Lgxi+KvmO1CjMRpA82LgNDyGabI+7cq2+KJUpY2ET4\n\t/AsyBCkUhE/+s0BaWhAwmNdl3QefU982D/kcrz0j+XLluxvqjrHFTyfou3OSYUebrwWG\n\to3xpGI38s0Eqx2mjgoY2iVkRVYy7q3y/7fANUVlUtEZUtmbNT2OUjCuGlQfdwPc4ewQo\n\twBgkp8z47Ka4yFSxvSCfixtgJ9wbJ4AYa4Mjw0d+jkhGXkYNxgf4pozoj8ERgFG7zPnM\n\tj+3Q==",
        "X-Gm-Message-State": "ALoCoQmE5xYoSyy8RTPdbubKjZy+cDfi35aMQXSbIcTFK9OlxGUQxgWFzS/Ifgs/K4GP03DxF9q8",
        "X-Received": "by 10.180.75.176 with SMTP id d16mr7082854wiw.77.1420635817307; \n\tWed, 07 Jan 2015 05:03:37 -0800 (PST)",
        "From": "David Marchand <david.marchand@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed,  7 Jan 2015 14:03:28 +0100",
        "Message-Id": "<1420635809-30976-2-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 1.7.10.4",
        "In-Reply-To": "<1420635809-30976-1-git-send-email-david.marchand@6wind.com>",
        "References": "<1420635809-30976-1-git-send-email-david.marchand@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 1/2] devargs: indent and cleanup",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Prepare for next commit.\nFix some indent issues, refactor error code.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/common/eal_common_devargs.c |   27 ++++++++++++++-------------\n 1 file changed, 14 insertions(+), 13 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 4c7d11a..8c9b31a 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -48,7 +48,7 @@ struct rte_devargs_list devargs_list =\n int\n rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n {\n-\tstruct rte_devargs *devargs;\n+\tstruct rte_devargs *devargs = NULL;\n \tchar buf[RTE_DEVARGS_LEN];\n \tchar *sep;\n \tint ret;\n@@ -57,14 +57,14 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \tif (ret < 0 || ret >= (int)sizeof(buf)) {\n \t\tRTE_LOG(ERR, EAL, \"user device args too large: <%s>\\n\",\n \t\t\tdevargs_str);\n-\t\treturn -1;\n+\t\tgoto fail;\n \t}\n \n \t/* use malloc instead of rte_malloc as it's called early at init */\n \tdevargs = malloc(sizeof(*devargs));\n \tif (devargs == NULL) {\n \t\tRTE_LOG(ERR, EAL, \"cannot allocate devargs\\n\");\n-\t\treturn -1;\n+\t\tgoto fail;\n \t}\n \tmemset(devargs, 0, sizeof(*devargs));\n \tdevargs->type = devtype;\n@@ -81,28 +81,29 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)\n \tcase RTE_DEVTYPE_BLACKLISTED_PCI:\n \t\t/* try to parse pci identifier */\n \t\tif (eal_parse_pci_BDF(buf, &devargs->pci.addr) != 0 &&\n-\t\t\teal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"invalid PCI identifier <%s>\\n\", buf);\n-\t\t\tfree(devargs);\n-\t\t\treturn -1;\n+\t\t    eal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"invalid PCI identifier <%s>\\n\", buf);\n+\t\t\tgoto fail;\n \t\t}\n \t\tbreak;\n \tcase RTE_DEVTYPE_VIRTUAL:\n \t\t/* save driver name */\n \t\tret = snprintf(devargs->virtual.drv_name,\n-\t\t\tsizeof(devargs->virtual.drv_name), \"%s\", buf);\n+\t\t\t       sizeof(devargs->virtual.drv_name), \"%s\", buf);\n \t\tif (ret < 0 || ret >= (int)sizeof(devargs->virtual.drv_name)) {\n-\t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"driver name too large: <%s>\\n\", buf);\n-\t\t\tfree(devargs);\n-\t\t\treturn -1;\n+\t\t\tRTE_LOG(ERR, EAL, \"driver name too large: <%s>\\n\", buf);\n+\t\t\tgoto fail;\n \t\t}\n \t\tbreak;\n \t}\n \n \tTAILQ_INSERT_TAIL(&devargs_list, devargs, next);\n \treturn 0;\n+\n+fail:\n+\tif (devargs)\n+\t\tfree(devargs);\n+\treturn -1;\n }\n \n /* count the number of devices of a specified type */\n",
    "prefixes": [
        "dpdk-dev",
        "1/2"
    ]
}