List comments

GET /api/patches/220/comments/?format=api
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 513,
        "web_url": "https://patches.dpdk.org/comment/513/",
        "msgid": "<3586297.ZW2M4AoP7m@xps13>",
        "date": "2014-08-27T15:12:06",
        "subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/?format=api",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-08-26 15:31, Jijiang Liu:\n> +enum rte_tunnel_filter_type {\n> +\tRTE_TUNNEL_FILTER_TYPE_NONE = 0,\n> +\tRTE_TUNNEL_FILTER_IMAC_IVLAN, /**< Filter by inner MAC and VLAN ID. */\n> +\tRTE_TUNNEL_FILTER_IMAC_IVLAN_TENID,\n> +\t/**< Filter by inner MAC address and VLAN ID, tenned ID. */\n> +\tRTE_TUNNEL_FILTER_IMAC_TENID, /**< Filter by inner MAC and tenant ID. */\n> +\tRTE_TUNNEL_FILTER_IMAC, /**< Filter by inner MAC address */\n> +\tRTE_TUNNEL_FILTER_OMAC_TENID_IMAC,\n> +\t/**< Filter by outer MAC address, tenant ID and Inner MAC */\n> +\tRTE_TUNNEL_FILTER_TYPE_MAX,\n> +};\n[...]\n>  /**\n> + * Tunnel Packet filter configuration.\n> + */\n> +struct rte_eth_tunnel_filter_conf {\n> +\tstruct ether_addr *outer_mac;  /**< Outer MAC address fiter. */\n> +\tstruct ether_addr *inner_mac;  /**< Inner MAC address fiter. */\n> +\tuint16_t inner_vlan;           /**< Inner VLAN fiter. */\n> +\tenum rte_tunnel_iptype ip_type; /**< IP address type. */\n> +\tunion {\n> +\t\tuint32_t ipv4_addr;    /**< IPv4 source address to match. */\n> +\t\tuint32_t ipv6_addr[4]; /**< IPv6 source address to match. */\n> +\t} ip_addr; /**< IPv4/IPv6 source address to match (union of above). */\n> +\n> +\tuint8_t filter_type;           /**< Filter type. */\n> +\tuint8_t to_queue;              /**< Use MAC and VLAN to point to a queue. */\n> +\tenum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */\n> +\tuint32_t tenant_id;            /** < Tenant number. */\n> +\tuint16_t queue_id;             /** < queue number. */\n> +};\n[...]\n> +typedef int (*eth_tunnel_filter_set_t)(struct rte_eth_dev *dev,\n> +\t\t\t\t      struct rte_eth_tunnel_filter_conf *tunnel_filter,\n> +\t\t\t\t      uint8_t filter_count, uint8_t add);\n> +/**< @internal Set tunnel filter */\n[...]\n> + /**\n> + * Add tunnel filter configuration of Ethernet device\n> + *\n> + * @param port_id\n> + *   The port identifier of the Ethernet device.\n> + * @param tunnel_filter\n> + *   Where to store the current Tunneling UDP configuration\n> + *   of the Ethernet device.\n> + * @param filter_count\n> + *   How many filters are going to added.\n> + * @param add\n> + *   0: remove tunnel filter\n> + *   1: add tunnel filter\n> + *\n> + * @return\n> + *   - (0) if successful.\n> + *   - (-ENODEV) if port identifier is invalid.\n> + *   - (-EINVAL) if bad parameter.\n> + *   - (-ENOTSUP) if hardware doesn't support tunnel type.\n> + */\n> +int\n> +rte_eth_dev_tunnel_filter_set(uint8_t port_id,\n> +\t\t\tstruct rte_eth_tunnel_filter_conf *tunnel_filter,\n> +\t\t\tuint8_t filter_count, uint8_t add);\n\nI wonder if we could use a common function to set all kind of filters?\n\nThoughts are welcome.",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "Date": "Wed, 27 Aug 2014 17:12:06 +0200",
            "In-Reply-To": "<1409038294-21693-4-git-send-email-jijiang.liu@intel.com>",
            "Received": [
                "from mail-wi0-f171.google.com (mail-wi0-f171.google.com\n\t[209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 4B7E0B37C\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 17:08:11 +0200 (CEST)",
                "by mail-wi0-f171.google.com with SMTP id hi2so5992069wib.16\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 08:12:14 -0700 (PDT)",
                "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tkr8sm1798268wjb.20.2014.08.27.08.12.11 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Aug 2014 08:12:12 -0700 (PDT)"
            ],
            "References": "<1409038294-21693-1-git-send-email-jijiang.liu@intel.com>\n\t<1409038294-21693-4-git-send-email-jijiang.liu@intel.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "MIME-Version": "1.0",
            "X-Received": "by 10.180.19.35 with SMTP id b3mr29049592wie.52.1409152333151;\n\tWed, 27 Aug 2014 08:12:13 -0700 (PDT)",
            "Message-ID": "<3586297.ZW2M4AoP7m@xps13>",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=5TZVo2+3yxhTDO5lsjEvOaPowuFXgyIt6/EOp5q2dKo=;\n\tb=kExAw3hH444+26vViuBbUuJR8SloNIntM+IOfvxWi5CWjaRnQCotIURgczNQdXyUS/\n\tHVQk3hzF0F51T9GdgX1WZDBbdr4DmcET7fo5rw3/3BrFbW/OTab5cySAwXk/a6GBcso1\n\to1GxxehAfhLI7BcMi5Du3YUwPCq9tbByxKaRaMwfp9nhdDIm9rQdsAclDdOMFXyX2gVA\n\t3r23NKxttQfKdFtu3bFzMe3wKooEQvwQIlROQvix32Zh5mszOSAqVa5RfFxWBTA+pNkQ\n\taWGzwB7STFSt6Ysgd2UQ1DzTc/L8qz8dpExQM6Y20M+nUiXBlU3fnpIXbDC90FKM2omK\n\tjlHA==",
            "X-List-Received-Date": "Wed, 27 Aug 2014 15:08:11 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Precedence": "list",
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Organization": "6WIND",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "Jijiang Liu <jijiang.liu@intel.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-Gm-Message-State": "ALoCoQkMAOXmcwNY17+TMSL3o49PRbPX1ef5TZhyBU/5yw7uwlPGpduEAuZ7O/rQFGWQBBTjZdCf",
            "Content-Transfer-Encoding": "7Bit",
            "Cc": "dev@dpdk.org",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-BeenThere": "dev@dpdk.org",
            "Subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether"
        }
    },
    {
        "id": 530,
        "web_url": "https://patches.dpdk.org/comment/530/",
        "msgid": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01D6319C@SHSMSX101.ccr.corp.intel.com>",
        "date": "2014-08-28T00:55:58",
        "subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
        "submitter": {
            "id": 52,
            "url": "https://patches.dpdk.org/api/people/52/?format=api",
            "name": "Jijiang Liu",
            "email": "jijiang.liu@intel.com"
        },
        "content": "> -----Original Message-----\r\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\r\n> Sent: Wednesday, August 27, 2014 11:12 PM\r\n> To: Liu, Jijiang\r\n> Cc: dev@dpdk.org\r\n> Subject: Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet filter\r\n> in librte_ether\r\n> \r\n> 2014-08-26 15:31, Jijiang Liu:\r\n> > +enum rte_tunnel_filter_type {\r\n> > +\tRTE_TUNNEL_FILTER_TYPE_NONE = 0,\r\n> > +\tRTE_TUNNEL_FILTER_IMAC_IVLAN, /**< Filter by inner MAC and VLAN ID.\r\n> */\r\n> > +\tRTE_TUNNEL_FILTER_IMAC_IVLAN_TENID,\r\n> > +\t/**< Filter by inner MAC address and VLAN ID, tenned ID. */\r\n> > +\tRTE_TUNNEL_FILTER_IMAC_TENID, /**< Filter by inner MAC and tenant\r\n> ID. */\r\n> > +\tRTE_TUNNEL_FILTER_IMAC, /**< Filter by inner MAC address */\r\n> > +\tRTE_TUNNEL_FILTER_OMAC_TENID_IMAC,\r\n> > +\t/**< Filter by outer MAC address, tenant ID and Inner MAC */\r\n> > +\tRTE_TUNNEL_FILTER_TYPE_MAX,\r\n> > +};\r\n> [...]\r\n> >  /**\r\n> > + * Tunnel Packet filter configuration.\r\n> > + */\r\n> > +struct rte_eth_tunnel_filter_conf {\r\n> > +\tstruct ether_addr *outer_mac;  /**< Outer MAC address fiter. */\r\n> > +\tstruct ether_addr *inner_mac;  /**< Inner MAC address fiter. */\r\n> > +\tuint16_t inner_vlan;           /**< Inner VLAN fiter. */\r\n> > +\tenum rte_tunnel_iptype ip_type; /**< IP address type. */\r\n> > +\tunion {\r\n> > +\t\tuint32_t ipv4_addr;    /**< IPv4 source address to match. */\r\n> > +\t\tuint32_t ipv6_addr[4]; /**< IPv6 source address to match. */\r\n> > +\t} ip_addr; /**< IPv4/IPv6 source address to match (union of above).\r\n> > +*/\r\n> > +\r\n> > +\tuint8_t filter_type;           /**< Filter type. */\r\n> > +\tuint8_t to_queue;              /**< Use MAC and VLAN to point to a\r\n> queue. */\r\n> > +\tenum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */\r\n> > +\tuint32_t tenant_id;            /** < Tenant number. */\r\n> > +\tuint16_t queue_id;             /** < queue number. */\r\n> > +};\r\n> [...]\r\n> > +typedef int (*eth_tunnel_filter_set_t)(struct rte_eth_dev *dev,\r\n> > +\t\t\t\t      struct rte_eth_tunnel_filter_conf *tunnel_filter,\r\n> > +\t\t\t\t      uint8_t filter_count, uint8_t add); /**< @internal\r\n> Set\r\n> > +tunnel filter */\r\n> [...]\r\n> > + /**\r\n> > + * Add tunnel filter configuration of Ethernet device\r\n> > + *\r\n> > + * @param port_id\r\n> > + *   The port identifier of the Ethernet device.\r\n> > + * @param tunnel_filter\r\n> > + *   Where to store the current Tunneling UDP configuration\r\n> > + *   of the Ethernet device.\r\n> > + * @param filter_count\r\n> > + *   How many filters are going to added.\r\n> > + * @param add\r\n> > + *   0: remove tunnel filter\r\n> > + *   1: add tunnel filter\r\n> > + *\r\n> > + * @return\r\n> > + *   - (0) if successful.\r\n> > + *   - (-ENODEV) if port identifier is invalid.\r\n> > + *   - (-EINVAL) if bad parameter.\r\n> > + *   - (-ENOTSUP) if hardware doesn't support tunnel type.\r\n> > + */\r\n> > +int\r\n> > +rte_eth_dev_tunnel_filter_set(uint8_t port_id,\r\n> > +\t\t\tstruct rte_eth_tunnel_filter_conf *tunnel_filter,\r\n> > +\t\t\tuint8_t filter_count, uint8_t add);\r\n> \r\n> I wonder if we could use a common function to set all kind of filters?\r\n> \r\n> Thoughts are welcome.\r\n> \r\n> --\r\n> Thomas\r\n\r\nThe rte_eth_dev_tunnel_filter_set() is a common filter function for tunneling packet, which can set all kind of filters.\r\nBut now I just implemented and tested VxLAN tunneling packet in this function, another tunneling packets support will be here later.\r\nLook at the structure definition, which support another tunneling types. \r\nstruct rte_eth_tunnel_filter_conf {\r\n    ...\r\n    enum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */\r\n    ...\r\n}\r\n--\r\nJijiang Liu",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "X-MS-TNEF-Correlator": "",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
            "x-originating-ip": "[10.239.127.40]",
            "Received": [
                "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id E25AB5946\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 02:51:55 +0200 (CEST)",
                "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 27 Aug 2014 17:56:01 -0700",
                "from fmsmsx104.amr.corp.intel.com ([10.18.124.202])\n\tby orsmga002.jf.intel.com with ESMTP; 27 Aug 2014 17:56:01 -0700",
                "from shsmsx103.ccr.corp.intel.com (10.239.4.69) by\n\tfmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 27 Aug 2014 17:56:00 -0700",
                "from shsmsx101.ccr.corp.intel.com ([169.254.1.198]) by\n\tSHSMSX103.ccr.corp.intel.com ([169.254.4.219]) with mapi id\n\t14.03.0195.001; Thu, 28 Aug 2014 08:55:59 +0800"
            ],
            "References": "<1409038294-21693-1-git-send-email-jijiang.liu@intel.com>\n\t<1409038294-21693-4-git-send-email-jijiang.liu@intel.com>\n\t<3586297.ZW2M4AoP7m@xps13>",
            "MIME-Version": "1.0",
            "Message-ID": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01D6319C@SHSMSX101.ccr.corp.intel.com>",
            "Accept-Language": "en-US",
            "X-List-Received-Date": "Thu, 28 Aug 2014 00:51:56 -0000",
            "Thread-Index": "AQHPwglYD6kzoXpn7EivWqabm1XZqJvlL2Jw",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,414,1406617200\"; d=\"scan'208\";a=\"594295799\"",
            "Content-Language": "en-US",
            "Content-Transfer-Encoding": "base64",
            "From": "\"Liu, Jijiang\" <jijiang.liu@intel.com>",
            "Content-Type": "text/plain; charset=\"gb2312\"",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Return-Path": "<jijiang.liu@intel.com>",
            "X-MS-Has-Attach": "",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<3586297.ZW2M4AoP7m@xps13>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Precedence": "list",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "Subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Date": "Thu, 28 Aug 2014 00:55:58 +0000"
        }
    },
    {
        "id": 538,
        "web_url": "https://patches.dpdk.org/comment/538/",
        "msgid": "<3070853.Eook8YoHL0@xps13>",
        "date": "2014-08-28T08:36:58",
        "subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/?format=api",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-08-28 00:55, Liu, Jijiang:\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > I wonder if we could use a common function to set all kind of filters?\n> > \n> > Thoughts are welcome.\n> \n> The rte_eth_dev_tunnel_filter_set() is a common filter function for\n> tunneling packet, which can set all kind of filters.\n\nI understand that. But my question was: could we have common functions for\ntunnel filters and (existing) generic filters?",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "Date": "Thu, 28 Aug 2014 10:36:58 +0200",
            "In-Reply-To": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01D6319C@SHSMSX101.ccr.corp.intel.com>",
            "Received": [
                "from mail-wi0-f181.google.com (mail-wi0-f181.google.com\n\t[209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 93E155946\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 10:32:57 +0200 (CEST)",
                "by mail-wi0-f181.google.com with SMTP id e4so449342wiv.14\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 01:37:05 -0700 (PDT)",
                "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\txt6sm8083210wjc.14.2014.08.28.01.37.04 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 01:37:05 -0700 (PDT)"
            ],
            "References": "<1409038294-21693-1-git-send-email-jijiang.liu@intel.com>\n\t<3586297.ZW2M4AoP7m@xps13>\n\t<1ED644BD7E0A5F4091CF203DAFB8E4CC01D6319C@SHSMSX101.ccr.corp.intel.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "MIME-Version": "1.0",
            "X-Received": "by 10.181.13.116 with SMTP id ex20mr4197845wid.31.1409215025739; \n\tThu, 28 Aug 2014 01:37:05 -0700 (PDT)",
            "Message-ID": "<3070853.Eook8YoHL0@xps13>",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=+wouN7oAL4gnBSgU7y1HBY+cbA3MxtENERT9pegWTzs=;\n\tb=GWEIrvrWckAX/Q9C73ryFNHx6ZeZG+5iHF5lmFZo25gOhteN+PBiNVVokYfZFHGPEi\n\t0G3t/BVnMX3ikuaaBWA2Q5bIx3ZSqr7Ce6R84ndjUANedeVPBh+n5cyTw5hS/rbNo/wh\n\tr5WLWDl/lUrdEKFPP11yHvGvVSy5pYYyJ2ESA0g52RFYYlfYMWFRl9ZtSJXtY6aVRRfe\n\t7L1G9qYpD5K38wYEqBzbd/0/+/Ivyv4DQz1+AJ0weGfjX2t3fC4pRrd8OlOMzSzdr9r1\n\t/9qK+Hk8yYLEJq544C3OniRN98WuTUQVZdJfzzo49EEtkyaxPfCk1a3pyS4yTyrCKdd1\n\t2KcQ==",
            "X-List-Received-Date": "Thu, 28 Aug 2014 08:32:57 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Precedence": "list",
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Organization": "6WIND",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "\"Liu, Jijiang\" <jijiang.liu@intel.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-Gm-Message-State": "ALoCoQncbKDni0KeCWusDqWs/14d1A/mVr1cSt+PLKBJBoUxX2yax+T5+IbCUp5VIrVcxrBLLS6A",
            "Content-Transfer-Encoding": "7Bit",
            "Cc": "dev@dpdk.org",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-BeenThere": "dev@dpdk.org",
            "Subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether"
        }
    },
    {
        "id": 546,
        "web_url": "https://patches.dpdk.org/comment/546/",
        "msgid": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01D633CF@SHSMSX101.ccr.corp.intel.com>",
        "date": "2014-08-28T11:02:44",
        "subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
        "submitter": {
            "id": 52,
            "url": "https://patches.dpdk.org/api/people/52/?format=api",
            "name": "Jijiang Liu",
            "email": "jijiang.liu@intel.com"
        },
        "content": "Hi Thomas,\n\n> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Thursday, August 28, 2014 4:37 PM\n> To: Liu, Jijiang\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet filter\n> in librte_ether\n> \n> 2014-08-28 00:55, Liu, Jijiang:\n> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > > I wonder if we could use a common function to set all kind of filters?\n> > >\n> > > Thoughts are welcome.\n> >\n> > The rte_eth_dev_tunnel_filter_set() is a common filter function for\n> > tunneling packet, which can set all kind of filters.\n> \n> I understand that. But my question was: could we have common functions for\n> tunnel filters and (existing) generic filters?\n> \n> --\n> Thomas\nTunneling packet is encapsulated format, in order to extend another tunneling type support and distinguish between tunneling and non-tunneling packet,\nwe had better provide independent common filter API. \nThe existing generic filter function is related to normal L2 packet filter(non-tunneling packet). If there are two kind of filter APIs, one is for normal L2 packet, \nother is for tunneling packet, which will make user more clear when and how to use them.  \n\nThanks\nJijiang Liu",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "X-MS-TNEF-Correlator": "",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
            "x-originating-ip": "[10.239.127.40]",
            "Received": [
                "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 93ABD5946\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 12:58:44 +0200 (CEST)",
                "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 28 Aug 2014 03:54:48 -0700",
                "from fmsmsx104.amr.corp.intel.com ([10.18.124.202])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 Aug 2014 04:02:47 -0700",
                "from fmsmsx101.amr.corp.intel.com (10.19.9.52) by\n\tfmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 28 Aug 2014 04:02:47 -0700",
                "from shsmsx152.ccr.corp.intel.com (10.239.6.52) by\n\tFMSMSX101.amr.corp.intel.com (10.19.9.52) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Thu, 28 Aug 2014 04:02:47 -0700",
                "from shsmsx101.ccr.corp.intel.com ([169.254.1.198]) by\n\tSHSMSX152.ccr.corp.intel.com ([169.254.6.147]) with mapi id\n\t14.03.0195.001; Thu, 28 Aug 2014 19:02:45 +0800"
            ],
            "References": "<1409038294-21693-1-git-send-email-jijiang.liu@intel.com>\n\t<3586297.ZW2M4AoP7m@xps13>\n\t<1ED644BD7E0A5F4091CF203DAFB8E4CC01D6319C@SHSMSX101.ccr.corp.intel.com>\n\t<3070853.Eook8YoHL0@xps13>",
            "MIME-Version": "1.0",
            "Message-ID": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01D633CF@SHSMSX101.ccr.corp.intel.com>",
            "Accept-Language": "en-US",
            "X-List-Received-Date": "Thu, 28 Aug 2014 10:58:45 -0000",
            "Thread-Index": "AQHPwpt2SLkk1INR7Euh39mpJ3z/YZvls7fA",
            "X-IronPort-AV": "E=Sophos;i=\"5.04,417,1406617200\"; d=\"scan'208\";a=\"582831525\"",
            "Content-Language": "en-US",
            "Content-Transfer-Encoding": "quoted-printable",
            "From": "\"Liu, Jijiang\" <jijiang.liu@intel.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Return-Path": "<jijiang.liu@intel.com>",
            "X-MS-Has-Attach": "",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<3070853.Eook8YoHL0@xps13>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Precedence": "list",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "Subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Date": "Thu, 28 Aug 2014 11:02:44 +0000"
        }
    },
    {
        "id": 550,
        "web_url": "https://patches.dpdk.org/comment/550/",
        "msgid": "<1852480.GdSX0xcYZA@xps13>",
        "date": "2014-08-28T12:31:56",
        "subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether",
        "submitter": {
            "id": 1,
            "url": "https://patches.dpdk.org/api/people/1/?format=api",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-08-28 11:02, Liu, Jijiang:\n> From: Thomas Monjalon\n> > 2014-08-28 00:55, Liu, Jijiang:\n> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > > > I wonder if we could use a common function to set all kind of filters?\n> > > >\n> > > > Thoughts are welcome.\n> > >\n> > > The rte_eth_dev_tunnel_filter_set() is a common filter function for\n> > > tunneling packet, which can set all kind of filters.\n> > \n> > I understand that. But my question was: could we have common functions for\n> > tunnel filters and (existing) generic filters?\n> \n> Tunneling packet is encapsulated format, in order to extend another\n> tunneling type support and distinguish between tunneling and non-tunneling\n> packet, we had better provide independent common filter API. \n> The existing generic filter function is related to normal L2 packet\n> filter(non-tunneling packet). If there are two kind of filter APIs, one is\n> for normal L2 packet, other is for tunneling packet, which will make user\n> more clear when and how to use them.\n\nSo I ask wether it is possible to merge 2 functions and you answer they are\ndifferent functions. I know they are different.\nI don't see why you can merge all different tunnels filtering in one function\nand not merge them with other L2 filters type?\n\nShould we wait that someone suggest a new API for HTTP filtering (for a new\nshiny NIC) to think about how all filters could be configured through a common\nAPI?\nWe already have flow director, syn filter, ethertype filter, 2-tuple filter,\n5-tuple filter, flex filter and you want to add tunnel filter.\nLast time, filters was called \"generic filter\" and I asked to think about how\nit was generic:\n\thttp://dpdk.org/ml/archives/dev/2014-May/002859.html\nAs I suspected, same story restart.\n\nI want these new i40e features as much as you. But it's not responsible to\nlet API becoming a mess like that.\nAll these filters must be reworked (including flow director).",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "Date": "Thu, 28 Aug 2014 14:31:56 +0200",
            "In-Reply-To": "<1ED644BD7E0A5F4091CF203DAFB8E4CC01D633CF@SHSMSX101.ccr.corp.intel.com>",
            "Received": [
                "from mail-we0-f177.google.com (mail-we0-f177.google.com\n\t[74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 1D1A35905\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 14:27:53 +0200 (CEST)",
                "by mail-we0-f177.google.com with SMTP id u56so687841wes.36\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 05:32:02 -0700 (PDT)",
                "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tam1sm9599626wjc.29.2014.08.28.05.32.00 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 05:32:01 -0700 (PDT)"
            ],
            "References": "<1409038294-21693-1-git-send-email-jijiang.liu@intel.com>\n\t<3070853.Eook8YoHL0@xps13>\n\t<1ED644BD7E0A5F4091CF203DAFB8E4CC01D633CF@SHSMSX101.ccr.corp.intel.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "MIME-Version": "1.0",
            "X-Received": "by 10.194.47.208 with SMTP id f16mr2650547wjn.130.1409229121952; \n\tThu, 28 Aug 2014 05:32:01 -0700 (PDT)",
            "Message-ID": "<1852480.GdSX0xcYZA@xps13>",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=GlBMqkCz80+H63xEsCg14mDwGVQRouH77JSApv1floA=;\n\tb=UJn0zkMjp43Qhbmi+h9Dk/sMpX+eCHjjIs7qvPCsOp2flayeubHAQ8xb5CqeDhF9eU\n\tinSlko6YR/FczPvrZUNIFQilFCUHjDBsetkcHM2OHqKdmPxpfYfw13PNQZSA9wSfeCAq\n\t9pf6U79XCEona2soNeJGSKRkSi3lceyGMFUaHxrNr7t6BiEgTxz7QOyT013uWVUsR5w3\n\taxs3EErZHytvKrUsCihcNDhWiDGr7Xuwln2HMrEg1jM9XZyTwoR/2lE5ipnFzE1sXFmj\n\tajCUEKFfCrTibZqq0uuHGqlYK78lip9PkIvChx8NeI20GlcCA4xdIk0F9x0uyICZsTSM\n\tppJQ==",
            "X-List-Received-Date": "Thu, 28 Aug 2014 12:27:53 -0000",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Precedence": "list",
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Organization": "6WIND",
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "\"Liu, Jijiang\" <jijiang.liu@intel.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-Gm-Message-State": "ALoCoQmIKgDssK469xdH6SmR384uILBRtt0KE4Aa2zG1iDGiG+s4+cYfCz7qpFLLhXUAEccTdnRy",
            "Content-Transfer-Encoding": "7Bit",
            "Cc": "dev@dpdk.org",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-BeenThere": "dev@dpdk.org",
            "Subject": "Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet\n\tfilter in librte_ether"
        }
    }
]