Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2185/?format=api
https://patches.dpdk.org/api/patches/2185/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1420355937-18484-2-git-send-email-changchun.ouyang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1420355937-18484-2-git-send-email-changchun.ouyang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1420355937-18484-2-git-send-email-changchun.ouyang@intel.com", "date": "2015-01-04T07:18:52", "name": "[dpdk-dev,v4,1/6] ixgbe: Code cleanup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c18b67784eaf4bff655e15b54430d1c19ecb635d", "submitter": { "id": 31, "url": "https://patches.dpdk.org/api/people/31/?format=api", "name": "Ouyang Changchun", "email": "changchun.ouyang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1420355937-18484-2-git-send-email-changchun.ouyang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2185/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 66B255A5F;\n\tSun, 4 Jan 2015 08:19:11 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 49D7F5A5F\n\tfor <dev@dpdk.org>; Sun, 4 Jan 2015 08:19:08 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 03 Jan 2015 23:16:49 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 03 Jan 2015 23:19:07 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t047J5AX030833;\n\tSun, 4 Jan 2015 15:19:05 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t047J2gv018525; Sun, 4 Jan 2015 15:19:04 +0800", "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t047J2VN018521; \n\tSun, 4 Jan 2015 15:19:02 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,694,1413270000\"; d=\"scan'208\";a=\"656516623\"", "From": "Ouyang Changchun <changchun.ouyang@intel.com>", "To": "dev@dpdk.org", "Date": "Sun, 4 Jan 2015 15:18:52 +0800", "Message-Id": "<1420355937-18484-2-git-send-email-changchun.ouyang@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1420355937-18484-1-git-send-email-changchun.ouyang@intel.com>", "References": "<1419398584-19520-1-git-send-email-changchun.ouyang@intel.com>\n\t<1420355937-18484-1-git-send-email-changchun.ouyang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 1/6] ixgbe: Code cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Put global register configuring out of loop for queue; also fix typo and indent;\nAlso fix typo and indent.\n\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 35 ++++++++++++++++++-----------------\n 1 file changed, 18 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex 5c36bff..f69abda 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -3548,9 +3548,9 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \t\t\t\tIXGBE_WRITE_REG(hw, IXGBE_PSRTYPE(rxq->reg_idx), psrtype);\n \t\t\t}\n \t\t\tsrrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<\n-\t\t\t\t IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &\n-\t\t\t\t IXGBE_SRRCTL_BSIZEHDR_MASK);\n-\t\t\tsrrctl |= E1000_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;\n+\t\t\t\tIXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &\n+\t\t\t\tIXGBE_SRRCTL_BSIZEHDR_MASK);\n+\t\t\tsrrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;\n \t\t} else\n #endif\n \t\t\tsrrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;\n@@ -3985,7 +3985,7 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)\n \tstruct igb_rx_queue *rxq;\n \tstruct rte_pktmbuf_pool_private *mbp_priv;\n \tuint64_t bus_addr;\n-\tuint32_t srrctl;\n+\tuint32_t srrctl, psrtype = 0;\n \tuint16_t buf_size;\n \tuint16_t i;\n \tint ret;\n@@ -4039,20 +4039,10 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)\n \t\t * Configure Header Split\n \t\t */\n \t\tif (dev->data->dev_conf.rxmode.header_split) {\n-\n-\t\t\t/* Must setup the PSRTYPE register */\n-\t\t\tuint32_t psrtype;\n-\t\t\tpsrtype = IXGBE_PSRTYPE_TCPHDR |\n-\t\t\t\tIXGBE_PSRTYPE_UDPHDR |\n-\t\t\t\tIXGBE_PSRTYPE_IPV4HDR |\n-\t\t\t\tIXGBE_PSRTYPE_IPV6HDR;\n-\n-\t\t\tIXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE(i), psrtype);\n-\n \t\t\tsrrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<\n-\t\t\t\t IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &\n-\t\t\t\t IXGBE_SRRCTL_BSIZEHDR_MASK);\n-\t\t\tsrrctl |= E1000_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;\n+\t\t\t\tIXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &\n+\t\t\t\tIXGBE_SRRCTL_BSIZEHDR_MASK);\n+\t\t\tsrrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;\n \t\t} else\n #endif\n \t\t\tsrrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;\n@@ -4095,6 +4085,17 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n+#ifdef RTE_HEADER_SPLIT_ENABLE\n+\tif (dev->data->dev_conf.rxmode.header_split)\n+\t\t/* Must setup the PSRTYPE register */\n+\t\tpsrtype = IXGBE_PSRTYPE_TCPHDR |\n+\t\t\tIXGBE_PSRTYPE_UDPHDR |\n+\t\t\tIXGBE_PSRTYPE_IPV4HDR |\n+\t\t\tIXGBE_PSRTYPE_IPV6HDR;\n+#endif\n+\n+\tIXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype);\n+\n \tif (dev->data->dev_conf.rxmode.enable_scatter) {\n \t\tif (!dev->data->scattered_rx)\n \t\t\tPMD_INIT_LOG(DEBUG, \"forcing scatter mode\");\n", "prefixes": [ "dpdk-dev", "v4", "1/6" ] }{ "id": 2185, "url": "