Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21659/?format=api
{ "id": 21659, "url": "https://patches.dpdk.org/api/patches/21659/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1489080183-21467-5-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1489080183-21467-5-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1489080183-21467-5-git-send-email-arybchenko@solarflare.com", "date": "2017-03-09T17:23:01", "name": "[dpdk-dev,v2,4/6] net/sfc: avoid failure on port start if Rx mode is rejected", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a9d30a2ab193af9f699690efea0e97b5fe09332d", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1489080183-21467-5-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/21659/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/21659/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D2FDCCF8A;\n\tThu, 9 Mar 2017 18:26:12 +0100 (CET)", "from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com\n\t[209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 3CCB62C49\n\tfor <dev@dpdk.org>; Thu, 9 Mar 2017 18:26:00 +0100 (CET)", "from unknown [12.187.104.26] (EHLO nbfkord-smmo01.seg.att.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\t82091c85.2ab21ca80940.30171.00-2487.66700.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tThu, 09 Mar 2017 17:26:00 +0000 (UTC)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t08f81c85.0.29954.00-2354.66107.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tThu, 09 Mar 2017 17:23:14 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Thu, 9 Mar 2017 09:23:08 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Thu, 9 Mar 2017 09:23:08 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv29HN60A018051; Thu, 9 Mar 2017 17:23:06 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv29HN58l021498; Thu, 9 Mar 2017 17:23:06 GMT" ], "X-MXL-Hash": [ "58c190280f1391d3-94cc522193867d4a6757222af050068df3aaef02", "58c18f8226cf0b44-1e7452339fa91ef894830ded985d9841b2012f61" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tIvan Malov <ivan.malov@oktetlabs.ru>", "Date": "Thu, 9 Mar 2017 17:23:01 +0000", "Message-ID": "<1489080183-21467-5-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1489080183-21467-1-git-send-email-arybchenko@solarflare.com>", "References": "<1488469608-2252-1-git-send-email-arybchenko@solarflare.com>\n\t<1489080183-21467-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=Tung8Wjh c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=6Iz7jQTuP9IA:10 a=pK7X0mNQAAAA:8 a=zRKbQ67AAAAA:8 a=]", "[2AxcTa4mq2Hpd6v_9GgA:9 a=5HA-qpC1VU4iIGLgRoNS:22 a=PA03WX8]", "[tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH v2 4/6] net/sfc: avoid failure on port start if\n\tRx mode is rejected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nIf Rx mode is unacceptable, in particular, when promiscuous\nor all-multicast filters are not allowed while running over\nPCI function which is not a member of appropriate privilege\ngroups, the driver has to cope with the failures gracefully\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andrew Lee <alee@solarflare.com>\n---\n drivers/net/sfc/sfc_rx.c | 54 +++++++++++++++++++++++++++++++++++++++++++++---\n 1 file changed, 51 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex 906536e..0a9fa42 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -401,6 +401,56 @@ sfc_rx_qflush(struct sfc_adapter *sa, unsigned int sw_index)\n \tsfc_rx_qpurge(rxq);\n }\n \n+static int\n+sfc_rx_default_rxq_set_filter(struct sfc_adapter *sa, struct sfc_rxq *rxq)\n+{\n+\tboolean_t rss = (sa->rss_channels > 1) ? B_TRUE : B_FALSE;\n+\tstruct sfc_port *port = &sa->port;\n+\tint rc;\n+\n+\t/*\n+\t * If promiscuous or all-multicast mode has been requested, setting\n+\t * filter for the default Rx queue might fail, in particular, while\n+\t * running over PCI function which is not a member of corresponding\n+\t * privilege groups; if this occurs, few iterations will be made to\n+\t * repeat this step without promiscuous and all-multicast flags set\n+\t */\n+retry:\n+\trc = efx_mac_filter_default_rxq_set(sa->nic, rxq->common, rss);\n+\tif (rc == 0)\n+\t\treturn 0;\n+\telse if (rc != EOPNOTSUPP)\n+\t\treturn rc;\n+\n+\tif (port->promisc) {\n+\t\tsfc_warn(sa, \"promiscuous mode has been requested, \"\n+\t\t\t \"but the HW rejects it\");\n+\t\tsfc_warn(sa, \"promiscuous mode will be disabled\");\n+\n+\t\tport->promisc = B_FALSE;\n+\t\trc = sfc_set_rx_mode(sa);\n+\t\tif (rc != 0)\n+\t\t\treturn rc;\n+\n+\t\tgoto retry;\n+\t}\n+\n+\tif (port->allmulti) {\n+\t\tsfc_warn(sa, \"all-multicast mode has been requested, \"\n+\t\t\t \"but the HW rejects it\");\n+\t\tsfc_warn(sa, \"all-multicast mode will be disabled\");\n+\n+\t\tport->allmulti = B_FALSE;\n+\t\trc = sfc_set_rx_mode(sa);\n+\t\tif (rc != 0)\n+\t\t\treturn rc;\n+\n+\t\tgoto retry;\n+\t}\n+\n+\treturn rc;\n+}\n+\n int\n sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n {\n@@ -439,9 +489,7 @@ sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n \tsfc_rx_qrefill(rxq);\n \n \tif (sw_index == 0) {\n-\t\trc = efx_mac_filter_default_rxq_set(sa->nic, rxq->common,\n-\t\t\t\t\t\t (sa->rss_channels > 1) ?\n-\t\t\t\t\t\t B_TRUE : B_FALSE);\n+\t\trc = sfc_rx_default_rxq_set_filter(sa, rxq);\n \t\tif (rc != 0)\n \t\t\tgoto fail_mac_filter_default_rxq_set;\n \t}\n", "prefixes": [ "dpdk-dev", "v2", "4/6" ] }