Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21646/?format=api
{ "id": 21646, "url": "https://patches.dpdk.org/api/patches/21646/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1489073193-2920-11-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1489073193-2920-11-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1489073193-2920-11-git-send-email-arybchenko@solarflare.com", "date": "2017-03-09T15:26:32", "name": "[dpdk-dev,v2,10/11] net/sfc: add UDP in flow API filters support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "643574648c59c96afb72f57abf3a22938ff6d730", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1489073193-2920-11-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/21646/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/21646/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0F286D11D;\n\tThu, 9 Mar 2017 16:31:12 +0100 (CET)", "from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com\n\t[209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 3A3EF532D\n\tfor <dev@dpdk.org>; Thu, 9 Mar 2017 16:30:59 +0100 (CET)", "from unknown [12.187.104.26] (EHLO nbfkord-smmo01.seg.att.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\t33571c85.2ab215274940.22188.00-2489.47707.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tThu, 09 Mar 2017 15:30:59 +0000 (UTC)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\ta4471c85.0.21873.00-2373.46936.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tThu, 09 Mar 2017 15:27:08 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Thu, 9 Mar 2017 07:26:50 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Thu, 9 Mar 2017 07:26:49 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv29FQmS1021398; Thu, 9 Mar 2017 15:26:48 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv29FQmLm002988; Thu, 9 Mar 2017 15:26:48 GMT" ], "X-MXL-Hash": [ "58c17533295037d8-6a2bd7d0984c340a5c46b6f8d349317c02715872", "58c1744c241fa5bc-69ca1c95909318d5a390731e7b0a39df29f2a982" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ferruh Yigit <ferruh.yigit@intel.com>, Roman Zhukov\n\t<Roman.Zhukov@oktetlabs.ru>", "Date": "Thu, 9 Mar 2017 15:26:32 +0000", "Message-ID": "<1489073193-2920-11-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1489073193-2920-1-git-send-email-arybchenko@solarflare.com>", "References": "<1488470591-5853-1-git-send-email-arybchenko@solarflare.com>\n\t<1489073193-2920-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=Tung8Wjh c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=6Iz7jQTuP9IA:10 a=pK7X0mNQAAAA:8 a=zRKbQ67AAAAA:8 a=]", "[JcMCQgoTivoLn6khoysA:9 a=5HA-qpC1VU4iIGLgRoNS:22 a=PA03WX8]", "[tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.5148870741; CM=0.500; S=0.514(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH v2 10/11] net/sfc: add UDP in flow API filters\n\tsupport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>\n\nExact match of source and destination ports is supported by parser.\nIP protocol match is enforced to UDP.\n\nSigned-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andrew Lee <alee@solarflare.com>\n---\n doc/guides/nics/sfc_efx.rst | 2 ++\n drivers/net/sfc/sfc_flow.c | 88 +++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 90 insertions(+)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 7e00fdc..4d91b1d 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -139,6 +139,8 @@ Supported pattern items:\n \n - TCP (exact match of source/destination ports)\n \n+- UDP (exact match of source/destination ports)\n+\n Supported actions:\n \n - VOID\ndiff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 38e6b73..ae36934 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -76,6 +76,7 @@ static sfc_flow_item_parse sfc_flow_parse_vlan;\n static sfc_flow_item_parse sfc_flow_parse_ipv4;\n static sfc_flow_item_parse sfc_flow_parse_ipv6;\n static sfc_flow_item_parse sfc_flow_parse_tcp;\n+static sfc_flow_item_parse sfc_flow_parse_udp;\n \n static boolean_t\n sfc_flow_is_zero(const uint8_t *buf, unsigned int size)\n@@ -621,6 +622,87 @@ sfc_flow_parse_tcp(const struct rte_flow_item *item,\n \treturn -rte_errno;\n }\n \n+/**\n+ * Convert UDP item to EFX filter specification.\n+ *\n+ * @param item[in]\n+ * Item specification. Only source and destination ports fields\n+ * are supported. If the mask is NULL, default mask will be used.\n+ * Ranging is not supported.\n+ * @param efx_spec[in, out]\n+ * EFX filter specification to update.\n+ * @param[out] error\n+ * Perform verbose error reporting if not NULL.\n+ */\n+static int\n+sfc_flow_parse_udp(const struct rte_flow_item *item,\n+\t\t efx_filter_spec_t *efx_spec,\n+\t\t struct rte_flow_error *error)\n+{\n+\tint rc;\n+\tconst struct rte_flow_item_udp *spec = NULL;\n+\tconst struct rte_flow_item_udp *mask = NULL;\n+\tconst struct rte_flow_item_udp supp_mask = {\n+\t\t.hdr = {\n+\t\t\t.src_port = 0xffff,\n+\t\t\t.dst_port = 0xffff,\n+\t\t}\n+\t};\n+\n+\trc = sfc_flow_parse_init(item,\n+\t\t\t\t (const void **)&spec,\n+\t\t\t\t (const void **)&mask,\n+\t\t\t\t &supp_mask,\n+\t\t\t\t &rte_flow_item_udp_mask,\n+\t\t\t\t sizeof(struct rte_flow_item_udp),\n+\t\t\t\t error);\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n+\t/*\n+\t * Filtering by UDP source and destination ports requires\n+\t * the appropriate IP_PROTO in hardware filters\n+\t */\n+\tif (!(efx_spec->efs_match_flags & EFX_FILTER_MATCH_IP_PROTO)) {\n+\t\tefx_spec->efs_match_flags |= EFX_FILTER_MATCH_IP_PROTO;\n+\t\tefx_spec->efs_ip_proto = EFX_IPPROTO_UDP;\n+\t} else if (efx_spec->efs_ip_proto != EFX_IPPROTO_UDP) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\"IP proto in pattern with UDP item should be appropriate\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (spec == NULL)\n+\t\treturn 0;\n+\n+\t/*\n+\t * Source and destination ports are in big-endian byte order in item and\n+\t * in little-endian in efx_spec, so byte swap is used\n+\t */\n+\tif (mask->hdr.src_port == supp_mask.hdr.src_port) {\n+\t\tefx_spec->efs_match_flags |= EFX_FILTER_MATCH_REM_PORT;\n+\t\tefx_spec->efs_rem_port = rte_bswap16(spec->hdr.src_port);\n+\t} else if (mask->hdr.src_port != 0) {\n+\t\tgoto fail_bad_mask;\n+\t}\n+\n+\tif (mask->hdr.dst_port == supp_mask.hdr.dst_port) {\n+\t\tefx_spec->efs_match_flags |= EFX_FILTER_MATCH_LOC_PORT;\n+\t\tefx_spec->efs_loc_port = rte_bswap16(spec->hdr.dst_port);\n+\t} else if (mask->hdr.dst_port != 0) {\n+\t\tgoto fail_bad_mask;\n+\t}\n+\n+\treturn 0;\n+\n+fail_bad_mask:\n+\trte_flow_error_set(error, EINVAL,\n+\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t \"Bad mask in the UDP pattern item\");\n+\treturn -rte_errno;\n+}\n+\n static const struct sfc_flow_item sfc_flow_items[] = {\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_VOID,\n@@ -658,6 +740,12 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t\t.layer = SFC_FLOW_ITEM_L4,\n \t\t.parse = sfc_flow_parse_tcp,\n \t},\n+\t{\n+\t\t.type = RTE_FLOW_ITEM_TYPE_UDP,\n+\t\t.prev_layer = SFC_FLOW_ITEM_L3,\n+\t\t.layer = SFC_FLOW_ITEM_L4,\n+\t\t.parse = sfc_flow_parse_udp,\n+\t},\n };\n \n /*\n", "prefixes": [ "dpdk-dev", "v2", "10/11" ] }