List comments

GET /api/patches/216/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 472,
        "web_url": "https://patches.dpdk.org/comment/472/",
        "msgid": "<F52918179C57134FAEC9EA62FA2F96251183B2A7@shsmsx102.ccr.corp.intel.com>",
        "date": "2014-08-26T08:41:58",
        "subject": "Re: [dpdk-dev] [RFC 08/10] virtio: remove redundant vq_alignment",
        "submitter": {
            "id": 31,
            "url": "https://patches.dpdk.org/api/people/31/",
            "name": "Ouyang Changchun",
            "email": "changchun.ouyang@intel.com"
        },
        "content": "Acked by: Changchun Ouyang <Changchun.ouyang@intel.com>\r\n\r\n> -----Original Message-----\r\n> From: Stephen Hemminger [mailto:stephen@networkplumber.org]\r\n> Sent: Tuesday, August 26, 2014 10:08 AM\r\n> To: Ouyang, Changchun\r\n> Cc: dev@dpdk.org; Stephen Hemminger\r\n> Subject: [RFC 08/10] virtio: remove redundant vq_alignment\r\n> \r\n> Since vq_alignment is constant (always 4K), it does not need to be part of the\r\n> vring struct.\r\n> \r\n> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>\r\n> \r\n> ---\r\n>  lib/librte_pmd_virtio/virtio_ethdev.c |    1 -\r\n>  lib/librte_pmd_virtio/virtio_rxtx.c   |    2 +-\r\n>  lib/librte_pmd_virtio/virtqueue.h     |    3 +--\r\n>  3 files changed, 2 insertions(+), 4 deletions(-)\r\n> \r\n> --- a/lib/librte_pmd_virtio/virtio_ethdev.c\t2014-08-25\r\n> 19:00:09.918550097 -0700\r\n> +++ b/lib/librte_pmd_virtio/virtio_ethdev.c\t2014-08-25\r\n> 19:00:09.918550097 -0700\r\n> @@ -290,7 +290,6 @@ int virtio_dev_queue_setup(struct rte_et\r\n>  \tvq->port_id = dev->data->port_id;\r\n>  \tvq->queue_id = queue_idx;\r\n>  \tvq->vq_queue_index = vtpci_queue_idx;\r\n> -\tvq->vq_alignment = VIRTIO_PCI_VRING_ALIGN;\r\n>  \tvq->vq_nentries = vq_size;\r\n>  \tvq->vq_free_cnt = vq_size;\r\n> \r\n> --- a/lib/librte_pmd_virtio/virtio_rxtx.c\t2014-08-25 19:00:09.918550097 -0700\r\n> +++ b/lib/librte_pmd_virtio/virtio_rxtx.c\t2014-08-25\r\n> 19:00:09.918550097 -0700\r\n> @@ -258,7 +258,7 @@ virtio_dev_vring_start(struct virtqueue\r\n>  \t * Reinitialise since virtio port might have been stopped and restarted\r\n>  \t */\r\n>  \tmemset(vq->vq_ring_virt_mem, 0, vq->vq_ring_size);\r\n> -\tvring_init(vr, size, ring_mem, vq->vq_alignment);\r\n> +\tvring_init(vr, size, ring_mem, VIRTIO_PCI_VRING_ALIGN);\r\n>  \tvq->vq_used_cons_idx = 0;\r\n>  \tvq->vq_desc_head_idx = 0;\r\n>  \tvq->vq_avail_idx = 0;\r\n> --- a/lib/librte_pmd_virtio/virtqueue.h\t2014-08-25 19:00:09.918550097 -0700\r\n> +++ b/lib/librte_pmd_virtio/virtqueue.h\t2014-08-25\r\n> 19:00:09.918550097 -0700\r\n> @@ -139,8 +139,7 @@ struct virtqueue {\r\n>  \tuint8_t     port_id;              /**< Device port identifier. */\r\n> \r\n>  \tvoid        *vq_ring_virt_mem;    /**< linear address of vring*/\r\n> -\tint         vq_alignment;\r\n> -\tint         vq_ring_size;\r\n> +\tunsigned int vq_ring_size;\r\n>  \tphys_addr_t vq_ring_mem;          /**< physical address of vring */\r\n> \r\n>  \tstruct vring vq_ring;    /**< vring keeping desc, used and avail */",
        "headers": {
            "Thread-Index": "AQHPwNLAOnzb/Sh8X0S6+tSEwq+EGZvikVuQ",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "X-MS-Has-Attach": "",
            "Date": "Tue, 26 Aug 2014 08:41:58 +0000",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<20140826020853.851222673@networkplumber.org>",
            "Message-ID": "<F52918179C57134FAEC9EA62FA2F96251183B2A7@shsmsx102.ccr.corp.intel.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Accept-Language": "zh-CN, en-US",
            "References": "<20140826020746.062748014@networkplumber.org>\n\t<20140826020853.851222673@networkplumber.org>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<changchun.ouyang@intel.com>",
            "x-originating-ip": "[10.239.127.40]",
            "MIME-Version": "1.0",
            "Received": [
                "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id A9D8EB36D\n\tfor <dev@dpdk.org>; Tue, 26 Aug 2014 10:38:11 +0200 (CEST)",
                "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 26 Aug 2014 01:34:11 -0700",
                "from fmsmsx106.amr.corp.intel.com ([10.18.124.204])\n\tby FMSMGA003.fm.intel.com with ESMTP; 26 Aug 2014 01:38:01 -0700",
                "from fmsmsx111.amr.corp.intel.com (10.18.116.5) by\n\tFMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 26 Aug 2014 01:42:09 -0700",
                "from shsmsx103.ccr.corp.intel.com (10.239.4.69) by\n\tfmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Tue, 26 Aug 2014 01:42:08 -0700",
                "from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by\n\tSHSMSX103.ccr.corp.intel.com ([169.254.4.219]) with mapi id\n\t14.03.0195.001; Tue, 26 Aug 2014 16:41:58 +0800"
            ],
            "From": "\"Ouyang, Changchun\" <changchun.ouyang@intel.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Transfer-Encoding": "base64",
            "Subject": "Re: [dpdk-dev] [RFC 08/10] virtio: remove redundant vq_alignment",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-List-Received-Date": "Tue, 26 Aug 2014 08:38:12 -0000",
            "To": "Stephen Hemminger <stephen@networkplumber.org>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=\"utf-8\"",
            "X-Mailman-Version": "2.1.15",
            "X-ExtLoop1": "1",
            "Thread-Topic": "[RFC 08/10] virtio: remove redundant vq_alignment",
            "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"377032916\""
        }
    }
]