Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 21591,
    "url": "https://patches.dpdk.org/api/patches/21591/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170308061906.950-17-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170308061906.950-17-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170308061906.950-17-qi.z.zhang@intel.com",
    "date": "2017-03-08T06:19:04",
    "name": "[dpdk-dev,v2,16/18] net/fm10k/base: replace macros",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "83c5e9c9ec8549449f42c85a2913e97266083c25",
    "submitter": {
        "id": 504,
        "url": "https://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170308061906.950-17-qi.z.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/21591/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/21591/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D560DF962;\n\tWed,  8 Mar 2017 06:29:25 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id E4096379B\n\tfor <dev@dpdk.org>; Wed,  8 Mar 2017 06:28:35 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Mar 2017 21:28:35 -0800",
            "from unknown (HELO localhost.localdomain.sh.intel.com)\n\t([10.239.129.167])\n\tby fmsmga002.fm.intel.com with ESMTP; 07 Mar 2017 21:28:34 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.36,262,1486454400\"; d=\"scan'208\";\n\ta=\"1139354646\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "jing.d.chen@intel.com",
        "Cc": "helin.zhang@intel.com,\n\tdev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>",
        "Date": "Wed,  8 Mar 2017 01:19:04 -0500",
        "Message-Id": "<20170308061906.950-17-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20170308061906.950-1-qi.z.zhang@intel.com>",
        "References": "<20170303031727.461-1-qi.z.zhang@intel.com>\n\t<20170308061906.950-1-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 16/18] net/fm10k/base: replace macros",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Other shared code bases are planning on using\nIS_MULTICAST_ETHER_ADDR and friends without leaving the driver\nname in the macro.\nRemove reference to FM10K here so that we can re-use the specific\ncompat flags from Linux.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/fm10k/base/fm10k_pf.c   | 10 +++++-----\n drivers/net/fm10k/base/fm10k_type.h | 14 +++++++-------\n drivers/net/fm10k/base/fm10k_vf.c   |  8 ++++----\n 3 files changed, 16 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c\nindex 5b1098e..db5f491 100644\n--- a/drivers/net/fm10k/base/fm10k_pf.c\n+++ b/drivers/net/fm10k/base/fm10k_pf.c\n@@ -411,7 +411,7 @@ STATIC s32 fm10k_update_uc_addr_pf(struct fm10k_hw *hw, u16 glort,\n \tDEBUGFUNC(\"fm10k_update_uc_addr_pf\");\n \n \t/* verify MAC address is valid */\n-\tif (!FM10K_IS_VALID_ETHER_ADDR(mac))\n+\tif (!IS_VALID_ETHER_ADDR(mac))\n \t\treturn FM10K_ERR_PARAM;\n \n \treturn fm10k_update_xc_addr_pf(hw, glort, mac, vid, add, flags);\n@@ -434,7 +434,7 @@ STATIC s32 fm10k_update_mc_addr_pf(struct fm10k_hw *hw, u16 glort,\n \tDEBUGFUNC(\"fm10k_update_mc_addr_pf\");\n \n \t/* verify multicast address is valid */\n-\tif (!FM10K_IS_MULTICAST_ETHER_ADDR(mac))\n+\tif (!IS_MULTICAST_ETHER_ADDR(mac))\n \t\treturn FM10K_ERR_PARAM;\n \n \treturn fm10k_update_xc_addr_pf(hw, glort, mac, vid, add, 0);\n@@ -970,7 +970,7 @@ STATIC s32 fm10k_iov_assign_default_mac_vlan_pf(struct fm10k_hw *hw,\n \t}\n \n \t/* Update base address registers to contain MAC address */\n-\tif (FM10K_IS_VALID_ETHER_ADDR(vf_info->mac)) {\n+\tif (IS_VALID_ETHER_ADDR(vf_info->mac)) {\n \t\ttdbal = (((u32)vf_info->mac[3]) << 24) |\n \t\t\t(((u32)vf_info->mac[4]) << 16) |\n \t\t\t(((u32)vf_info->mac[5]) << 8);\n@@ -1100,7 +1100,7 @@ STATIC s32 fm10k_iov_reset_resources_pf(struct fm10k_hw *hw,\n \tFM10K_WRITE_REG(hw, FM10K_MRQC(vf_info->vsi), 0);\n \n \t/* Update base address registers to contain MAC address */\n-\tif (FM10K_IS_VALID_ETHER_ADDR(vf_info->mac)) {\n+\tif (IS_VALID_ETHER_ADDR(vf_info->mac)) {\n \t\ttdbal = (((u32)vf_info->mac[3]) << 24) |\n \t\t\t(((u32)vf_info->mac[4]) << 16) |\n \t\t\t(((u32)vf_info->mac[5]) << 8);\n@@ -1326,7 +1326,7 @@ s32 fm10k_iov_msg_mac_vlan_pf(struct fm10k_hw *hw, u32 **results,\n \t\t\treturn err;\n \n \t\t/* block attempts to set MAC for a locked device */\n-\t\tif (FM10K_IS_VALID_ETHER_ADDR(vf_info->mac) &&\n+\t\tif (IS_VALID_ETHER_ADDR(vf_info->mac) &&\n \t\t    memcmp(mac, vf_info->mac, ETH_ALEN))\n \t\t\treturn FM10K_ERR_PARAM;\n \ndiff --git a/drivers/net/fm10k/base/fm10k_type.h b/drivers/net/fm10k/base/fm10k_type.h\nindex 931633d..1ae1644 100644\n--- a/drivers/net/fm10k/base/fm10k_type.h\n+++ b/drivers/net/fm10k/base/fm10k_type.h\n@@ -447,20 +447,20 @@ struct fm10k_hw;\n #define ETH_ALEN\t6\n #endif /* ETH_ALEN */\n \n-#ifndef FM10K_IS_ZERO_ETHER_ADDR\n+#ifndef IS_ZERO_ETHER_ADDR\n /* make certain address is not 0 */\n-#define FM10K_IS_ZERO_ETHER_ADDR(addr) \\\n+#define IS_ZERO_ETHER_ADDR(addr) \\\n (!((addr)[0] | (addr)[1] | (addr)[2] | (addr)[3] | (addr)[4] | (addr)[5]))\n #endif\n \n-#ifndef FM10K_IS_MULTICAST_ETHER_ADDR\n-#define FM10K_IS_MULTICAST_ETHER_ADDR(addr) ((addr)[0] & 0x1)\n+#ifndef IS_MULTICAST_ETHER_ADDR\n+#define IS_MULTICAST_ETHER_ADDR(addr) ((addr)[0] & 0x1)\n #endif\n \n-#ifndef FM10K_IS_VALID_ETHER_ADDR\n+#ifndef IS_VALID_ETHER_ADDR\n /* make certain address is not multicast or 0 */\n-#define FM10K_IS_VALID_ETHER_ADDR(addr) \\\n-(!FM10K_IS_MULTICAST_ETHER_ADDR(addr) && !FM10K_IS_ZERO_ETHER_ADDR(addr))\n+#define IS_VALID_ETHER_ADDR(addr) \\\n+(!IS_MULTICAST_ETHER_ADDR(addr) && !IS_ZERO_ETHER_ADDR(addr))\n #endif\n \n enum fm10k_int_source {\ndiff --git a/drivers/net/fm10k/base/fm10k_vf.c b/drivers/net/fm10k/base/fm10k_vf.c\nindex 71bacd0..bd44977 100644\n--- a/drivers/net/fm10k/base/fm10k_vf.c\n+++ b/drivers/net/fm10k/base/fm10k_vf.c\n@@ -53,7 +53,7 @@ STATIC s32 fm10k_stop_hw_vf(struct fm10k_hw *hw)\n \t\treturn err;\n \n \t/* If permanent address is set then we need to restore it */\n-\tif (FM10K_IS_VALID_ETHER_ADDR(perm_addr)) {\n+\tif (IS_VALID_ETHER_ADDR(perm_addr)) {\n \t\tbal = (((u32)perm_addr[3]) << 24) |\n \t\t      (((u32)perm_addr[4]) << 16) |\n \t\t      (((u32)perm_addr[5]) << 8);\n@@ -341,11 +341,11 @@ STATIC s32 fm10k_update_uc_addr_vf(struct fm10k_hw *hw, u16 glort,\n \t\treturn FM10K_ERR_PARAM;\n \n \t/* verify MAC address is valid */\n-\tif (!FM10K_IS_VALID_ETHER_ADDR(mac))\n+\tif (!IS_VALID_ETHER_ADDR(mac))\n \t\treturn FM10K_ERR_PARAM;\n \n \t/* verify we are not locked down on the MAC address */\n-\tif (FM10K_IS_VALID_ETHER_ADDR(hw->mac.perm_addr) &&\n+\tif (IS_VALID_ETHER_ADDR(hw->mac.perm_addr) &&\n \t    memcmp(hw->mac.perm_addr, mac, ETH_ALEN))\n \t\treturn FM10K_ERR_PARAM;\n \n@@ -387,7 +387,7 @@ STATIC s32 fm10k_update_mc_addr_vf(struct fm10k_hw *hw, u16 glort,\n \t\treturn FM10K_ERR_PARAM;\n \n \t/* verify multicast address is valid */\n-\tif (!FM10K_IS_MULTICAST_ETHER_ADDR(mac))\n+\tif (!IS_MULTICAST_ETHER_ADDR(mac))\n \t\treturn FM10K_ERR_PARAM;\n \n \t/* add bit to notify us if this is a set or clear operation */\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "16/18"
    ]
}