Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21457/?format=api
{ "id": 21457, "url": "https://patches.dpdk.org/api/patches/21457/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-29-git-send-email-jblunck@infradead.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488794430-25179-29-git-send-email-jblunck@infradead.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1488794430-25179-29-git-send-email-jblunck@infradead.org", "date": "2017-03-06T10:00:20", "name": "[dpdk-dev,28/38] net/mlx: Don't reference eth_driver", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1d26190344645b196bf87ac18dd2ead1925b3407", "submitter": { "id": 249, "url": "https://patches.dpdk.org/api/people/249/?format=api", "name": "Jan Blunck", "email": "jblunck@infradead.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-29-git-send-email-jblunck@infradead.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/21457/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/21457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0FE6FFA42;\n\tMon, 6 Mar 2017 11:02:19 +0100 (CET)", "from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 09AEB5A68\n\tfor <dev@dpdk.org>; Mon, 6 Mar 2017 11:01:18 +0100 (CET)", "by mail-wr0-f193.google.com with SMTP id g10so21001814wrg.0\n\tfor <dev@dpdk.org>; Mon, 06 Mar 2017 02:01:18 -0800 (PST)", "from weierstrass.local.net ([91.200.109.169])\n\tby smtp.gmail.com with ESMTPSA id\n\tu145sm3829237wmu.1.2017.03.06.02.01.16 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Mar 2017 02:01:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:subject:date:message-id:in-reply-to:references;\n\tbh=UNi/J7dIIiVYQp8YgUPfuR0KnKsZNR2XNmDTaTwomR4=;\n\tb=Jzqj4AbSkz5pyqvP83w6DSceoNC4g85HERzbZpxN82n7r35gKgPxwuyVw8lrxmAg7I\n\tMcfNlX62jeaMwD/7CLsNC8aTmM5XkLkQAcR1ES+xNBQNuO/Xv+GYW4ixTWjbo4cYXvop\n\tyS4n3MpNHfV4TPyGFdly5oqJBczDatGLtXloMEb7kgVLD9eVoIeKCOjF5OjfmtoHA9GA\n\ttkWJAS2aDWmR/EihIuqkriPuTlVm1tk8wbEtFu6Gd6LxBRJzkI6EPPiBcXupLRUqsfDN\n\t89gkB4TITBWQKrkkm/0iC7bVxVLc4O7XgrfsRZLBo3JlZlmO8XxoQ9V4rrL6OrV2kn3p\n\tsnOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=UNi/J7dIIiVYQp8YgUPfuR0KnKsZNR2XNmDTaTwomR4=;\n\tb=E6NlDBarFmZAyI22h8vOfNJw7s0XyFXdtU5U+3zFJYTvK3IbN1eeasTHXJ/nYLhfDh\n\tE7/B6ABjV10QOoyYYHUP9DNPFEFHiKH9wJFmt0qjbx2AgjGw/GQ3BVogtfLZ91MwNKCq\n\tR6f1rV1XUV5cbcbJgHkOq6THNPR9NVGjmr+1lvAPNEb0XgYf/RvklGgT+JbeLYoge5Qz\n\tdG3rAUfWkBdbpd1y3PAPas0vmruDiEFvCYYNhKCO4Ha+Zu1YPoMlH1f8IGgIS1liGZId\n\t+PHsTXHYZsuz1XLfRHoo/0qpvy9noF1RPNYOI5tN6+6LcZUIL7IOWSspZMorQe1Go/jK\n\tyrYA==", "X-Gm-Message-State": "AMke39mdAvBtAHxFnSjLJ9thX0ikhI9J1cNeFghNioRWvIJdowgPPiIUjnVkRziQf9dtKw==", "X-Received": "by 10.223.152.239 with SMTP id\n\tw102mr14481286wrb.72.1488794477586; \n\tMon, 06 Mar 2017 02:01:17 -0800 (PST)", "From": "Jan Blunck <jblunck@infradead.org>", "To": "dev@dpdk.org", "Date": "Mon, 6 Mar 2017 11:00:20 +0100", "Message-Id": "<1488794430-25179-29-git-send-email-jblunck@infradead.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>", "References": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>", "Subject": "[dpdk-dev] [PATCH 28/38] net/mlx: Don't reference eth_driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The eth_driver concept is unused in the mlx drivers so don't reference it.\n\nSigned-off-by: Jan Blunck <jblunck@infradead.org>\n---\n drivers/net/mlx4/mlx4.c | 17 +++++++----------\n drivers/net/mlx5/mlx5.c | 19 ++++++++-----------\n 2 files changed, 15 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 79efaaa..31ee7e4 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -5510,7 +5510,7 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev)\n \t}\n }\n \n-static struct eth_driver mlx4_driver;\n+static struct rte_pci_driver mlx4_driver;\n \n /**\n * DPDK callback to register a PCI device.\n@@ -5889,16 +5889,13 @@ static const struct rte_pci_id mlx4_pci_id_map[] = {\n \t}\n };\n \n-static struct eth_driver mlx4_driver = {\n-\t.pci_drv = {\n-\t\t.driver = {\n-\t\t\t.name = MLX4_DRIVER_NAME\n-\t\t},\n-\t\t.id_table = mlx4_pci_id_map,\n-\t\t.probe = mlx4_pci_probe,\n-\t\t.drv_flags = RTE_PCI_DRV_INTR_LSC,\n+static struct rte_pci_driver mlx4_driver = {\n+\t.driver = {\n+\t\t.name = MLX4_DRIVER_NAME\n \t},\n-\t.dev_private_size = sizeof(struct priv)\n+\t.id_table = mlx4_pci_id_map,\n+\t.probe = mlx4_pci_probe,\n+\t.drv_flags = RTE_PCI_DRV_INTR_LSC,\n };\n \n /**\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex d4bd469..74a45f6 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -343,7 +343,7 @@ mlx5_args(struct priv *priv, struct rte_devargs *devargs)\n \treturn 0;\n }\n \n-static struct eth_driver mlx5_driver;\n+static struct rte_pci_driver mlx5_driver;\n \n /**\n * DPDK callback to register a PCI device.\n@@ -373,7 +373,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \tint i;\n \n \t(void)pci_drv;\n-\tassert(pci_drv == &mlx5_driver.pci_drv);\n+\tassert(pci_drv == &mlx5_driver);\n \t/* Get mlx5_dev[] index. */\n \tidx = mlx5_dev_idx(&pci_dev->addr);\n \tif (idx == -1) {\n@@ -761,16 +761,13 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {\n \t}\n };\n \n-static struct eth_driver mlx5_driver = {\n-\t.pci_drv = {\n-\t\t.driver = {\n-\t\t\t.name = MLX5_DRIVER_NAME\n-\t\t},\n-\t\t.id_table = mlx5_pci_id_map,\n-\t\t.probe = mlx5_pci_probe,\n-\t\t.drv_flags = RTE_PCI_DRV_INTR_LSC,\n+static struct rte_pci_driver mlx5_driver = {\n+\t.driver = {\n+\t\t.name = MLX5_DRIVER_NAME\n \t},\n-\t.dev_private_size = sizeof(struct priv)\n+\t.id_table = mlx5_pci_id_map,\n+\t.probe = mlx5_pci_probe,\n+\t.drv_flags = RTE_PCI_DRV_INTR_LSC,\n };\n \n /**\n", "prefixes": [ "dpdk-dev", "28/38" ] }