Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 21442,
    "url": "https://patches.dpdk.org/api/patches/21442/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-15-git-send-email-jblunck@infradead.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1488794430-25179-15-git-send-email-jblunck@infradead.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1488794430-25179-15-git-send-email-jblunck@infradead.org",
    "date": "2017-03-06T10:00:06",
    "name": "[dpdk-dev,14/38] net/bonding: use ethdev allocation helper for virtual devices",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "720877d0ca6d2222123069590f7d0fb9664679e9",
    "submitter": {
        "id": 249,
        "url": "https://patches.dpdk.org/api/people/249/?format=api",
        "name": "Jan Blunck",
        "email": "jblunck@infradead.org"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-15-git-send-email-jblunck@infradead.org/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/21442/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/21442/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 39B02F969;\n\tMon,  6 Mar 2017 11:01:50 +0100 (CET)",
            "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67]) by dpdk.org (Postfix) with ESMTP id C348C567F\n\tfor <dev@dpdk.org>; Mon,  6 Mar 2017 11:01:00 +0100 (CET)",
            "by mail-wm0-f67.google.com with SMTP id n11so12814994wma.0\n\tfor <dev@dpdk.org>; Mon, 06 Mar 2017 02:01:00 -0800 (PST)",
            "from weierstrass.local.net ([91.200.109.169])\n\tby smtp.gmail.com with ESMTPSA id\n\tu145sm3829237wmu.1.2017.03.06.02.00.59 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Mar 2017 02:00:59 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:subject:date:message-id:in-reply-to:references;\n\tbh=dWrC1ViRZuhvLjoP7PdjZC/30l+23jfG1O6D+8JgVU8=;\n\tb=fcBnVuHHiQFZmw/PkGp+wd8PE6jCyFUQnSKPo7HM9iVkfK2shNvT36S46mcF0kyQZT\n\txlTQjuboFaSSPRFfYr7WK36z/WyhEvMw5LOvuZ2cfGbKhuFSWNDxKnJmcEH5ve8kxFhL\n\trjLJGm6B3b5nIj8Q8xOYhdRckXhdiYEpLe7olwUYE9KazijLxU2mWDAubt+if8P+Xj9N\n\tq2W59cx8qTynbpgfc2DlAQuZmnIpFaa44agAia6M65EI4KB+g7RBAhMJ9Olq5nTpWTxW\n\tlda8iKBWPepnzGAomPqysu1PkTgi6DpQYpmMPArg2ansFMkKj98cuZ7JODpPtI8xwvth\n\tN22g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=dWrC1ViRZuhvLjoP7PdjZC/30l+23jfG1O6D+8JgVU8=;\n\tb=cBbyb4AMDX0EXCAzMs3LOx0LJ/Q22fUAI1rGbVC+q7kN0zLWh9dV9svb3f9vzgnhyv\n\t7Gkez/LgtTJCjIqZ1PaC7QLCVKEqm88GFrkRxW2GWulnRC98+2DKd5pcyUFwjpwO8B14\n\tv9AypcHm7Xs380v9322aDPL1ZjktMRTPi7NYQ5+wwpCsUDw0rO2T2EHJeitBre9x5Jow\n\t5oVpRkveDpjz5E5vArs418HStv/jhsqVS9vMHxmw67fZ+Lcl279mkfNcT33hxu1FnHSM\n\tIWhRu/cD3LaKCwhxIDq9iquYbIiAQX0yKBiYNJ8L50k6AHqXFwadoB660e/Dr5S8iMFk\n\t3OXA==",
        "X-Gm-Message-State": "AMke39n34Pzx0alKcIplGZnwO/DcZWFJL4KOA6s2C7HPQtT5OdrMUdeDE6J0i5RqY+bcrw==",
        "X-Received": "by 10.28.107.14 with SMTP id g14mr13686924wmc.106.1488794460417; \n\tMon, 06 Mar 2017 02:01:00 -0800 (PST)",
        "From": "Jan Blunck <jblunck@infradead.org>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  6 Mar 2017 11:00:06 +0100",
        "Message-Id": "<1488794430-25179-15-git-send-email-jblunck@infradead.org>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>",
        "References": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>",
        "Subject": "[dpdk-dev] [PATCH 14/38] net/bonding: use ethdev allocation helper\n\tfor virtual devices",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Jan Blunck <jblunck@infradead.org>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 20 +++-----------------\n 1 file changed, 3 insertions(+), 17 deletions(-)",
    "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex c0d08a8..3c80ff5 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -36,6 +36,7 @@\n #include <rte_mbuf.h>\n #include <rte_malloc.h>\n #include <rte_ethdev.h>\n+#include <rte_ethdev_vdev.h>\n #include <rte_tcp.h>\n #include <rte_udp.h>\n #include <rte_ip.h>\n@@ -2243,31 +2244,20 @@ bond_alloc(struct rte_vdev_device *dev, uint8_t mode)\n \t * and internal (private) data\n \t */\n \n-\tif (name == NULL) {\n-\t\tRTE_BOND_LOG(ERR, \"Invalid name specified\");\n-\t\tgoto err;\n-\t}\n-\n \tif (socket_id >= number_of_sockets()) {\n \t\tRTE_BOND_LOG(ERR,\n \t\t\t\t\"Invalid socket id specified to create bonded device on.\");\n \t\tgoto err;\n \t}\n \n-\tinternals = rte_zmalloc_socket(name, sizeof(*internals), 0, socket_id);\n-\tif (internals == NULL) {\n-\t\tRTE_BOND_LOG(ERR, \"Unable to malloc internals on socket\");\n-\t\tgoto err;\n-\t}\n-\n \t/* reserve an ethdev entry */\n-\teth_dev = rte_eth_dev_allocate(name);\n+\teth_dev = rte_eth_vdev_allocate(dev, sizeof(*internals));\n \tif (eth_dev == NULL) {\n \t\tRTE_BOND_LOG(ERR, \"Unable to allocate rte_eth_dev\");\n \t\tgoto err;\n \t}\n \n-\teth_dev->data->dev_private = internals;\n+\tinternals = eth_dev->data->dev_private;\n \teth_dev->data->nb_rx_queues = (uint16_t)1;\n \teth_dev->data->nb_tx_queues = (uint16_t)1;\n \n@@ -2281,10 +2271,6 @@ bond_alloc(struct rte_vdev_device *dev, uint8_t mode)\n \teth_dev->dev_ops = &default_dev_ops;\n \teth_dev->data->dev_flags = RTE_ETH_DEV_INTR_LSC |\n \t\tRTE_ETH_DEV_DETACHABLE;\n-\teth_dev->driver = NULL;\n-\teth_dev->data->kdrv = RTE_KDRV_NONE;\n-\teth_dev->data->drv_name = pmd_bond_drv.driver.name;\n-\teth_dev->data->numa_node =  socket_id;\n \n \trte_spinlock_init(&internals->lock);\n \n",
    "prefixes": [
        "dpdk-dev",
        "14/38"
    ]
}