Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21434/?format=api
{ "id": 21434, "url": "https://patches.dpdk.org/api/patches/21434/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-7-git-send-email-jblunck@infradead.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488794430-25179-7-git-send-email-jblunck@infradead.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1488794430-25179-7-git-send-email-jblunck@infradead.org", "date": "2017-03-06T09:59:58", "name": "[dpdk-dev,06/38] net/tap: use ethdev allocation helper for virtual devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "809653b30775fbffc9640fc0511d417e5d9808ca", "submitter": { "id": 249, "url": "https://patches.dpdk.org/api/people/249/?format=api", "name": "Jan Blunck", "email": "jblunck@infradead.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-7-git-send-email-jblunck@infradead.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/21434/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/21434/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6A566F6BE;\n\tMon, 6 Mar 2017 11:01:32 +0100 (CET)", "from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193]) by dpdk.org (Postfix) with ESMTP id F02F5952\n\tfor <dev@dpdk.org>; Mon, 6 Mar 2017 11:00:51 +0100 (CET)", "by mail-wr0-f193.google.com with SMTP id g10so21000328wrg.0\n\tfor <dev@dpdk.org>; Mon, 06 Mar 2017 02:00:51 -0800 (PST)", "from weierstrass.local.net ([91.200.109.169])\n\tby smtp.gmail.com with ESMTPSA id\n\tu145sm3829237wmu.1.2017.03.06.02.00.50 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Mar 2017 02:00:50 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:subject:date:message-id:in-reply-to:references;\n\tbh=hXfkW8hFB3r0R43YJwpazffG543IhD1JWbt3cVr87+o=;\n\tb=Mn7YHBR3VVvYl5l6BTIyGFDoj/cxOyse9ekfu8SkQaFuakrkTX+eVitybncAlm5Azj\n\twh92ArXzXYmKRb4Z1Kw733i8d1XHtAC/606JZzhrW7RItQvfD8vgT7yR7jVAjYJO7e7O\n\tRLQjDCiykkWoQ45lLjiOJiRKFofuv+6DDyz5GsVFO2sO8eA97f6VnU7ZjZVGuEkktSKK\n\tOj1nK4dQzSkyKSEQuL2JVFk37TrA1MVpzTqg3P4MQdUSJf0JVJXV5/v7W/3/P0EVyviq\n\tOwEXf0rvrdlOzLreROVVvoy+V8CXoJXlCjSvX82rUyKRIFx6Ts0Qa9hloyiTh9LA0gOR\n\tSPrg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=hXfkW8hFB3r0R43YJwpazffG543IhD1JWbt3cVr87+o=;\n\tb=quyvaGNPoQOF6/79N77ttr9xtEp2s3BL/xQxx/TxeF1s7PVB/l4RzebJaDORSSdVAW\n\tGGfhMudxTQtwe/oQLTHBjcc7GvxBy3AxkGgrnNq8AKAw21eQIn/j1HedEcyIh9JKFCE9\n\t7edPkqpVZpfZ8EGGmqp4Zfnm5fopyQE2SHVfr1YiqEc9HR0MuLiVnwq5gZrzBbohIOWg\n\tbEVZVFsNhpmJ6OPTLtltxxqJsomjnMmJ3iXS1b0xpVJ+NIhf4HTOF2SyZOMv/OaBC0Gr\n\t5EMToYAmy6C+WS4Df1LxyNGNYinaZS2tTLurX+gLyLbyo8cxGL7SAXE0p3AF/bRTdayQ\n\tA9gg==", "X-Gm-Message-State": "AMke39lAjjNBty89Agll0s0q7UA50F/hbcmRBbI+0ngunRGJHpAB36+R/AUVvG6OQsQPpQ==", "X-Received": "by 10.223.151.5 with SMTP id r5mr15067182wrb.97.1488794451498;\n\tMon, 06 Mar 2017 02:00:51 -0800 (PST)", "From": "Jan Blunck <jblunck@infradead.org>", "To": "dev@dpdk.org", "Date": "Mon, 6 Mar 2017 10:59:58 +0100", "Message-Id": "<1488794430-25179-7-git-send-email-jblunck@infradead.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>", "References": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>", "Subject": "[dpdk-dev] [PATCH 06/38] net/tap: use ethdev allocation helper for\n\tvirtual devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Jan Blunck <jblunck@infradead.org>\n---\n drivers/net/tap/rte_eth_tap.c | 37 +++++++++++--------------------------\n 1 file changed, 11 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 941150f..f6f025f 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -33,6 +33,7 @@\n \n #include <rte_mbuf.h>\n #include <rte_ethdev.h>\n+#include <rte_ethdev_vdev.h>\n #include <rte_malloc.h>\n #include <rte_vdev.h>\n #include <rte_kvargs.h>\n@@ -641,12 +642,12 @@ static const struct eth_dev_ops ops = {\n };\n \n static int\n-eth_dev_tap_create(const char *name, char *tap_name)\n+eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name)\n {\n \tint numa_node = rte_socket_id();\n-\tstruct rte_eth_dev *dev = NULL;\n-\tstruct pmd_internals *pmd = NULL;\n-\tstruct rte_eth_dev_data *data = NULL;\n+\tstruct rte_eth_dev *dev;\n+\tstruct pmd_internals *pmd;\n+\tstruct rte_eth_dev_data *data;\n \tint i;\n \n \tRTE_LOG(DEBUG, PMD, \" TAP device on numa %u\\n\", rte_socket_id());\n@@ -657,30 +658,19 @@ eth_dev_tap_create(const char *name, char *tap_name)\n \t\tgoto error_exit;\n \t}\n \n-\tpmd = rte_zmalloc_socket(tap_name, sizeof(*pmd), 0, numa_node);\n-\tif (!pmd) {\n-\t\tRTE_LOG(ERR, PMD, \"TAP Unable to allocate internal struct\\n\");\n-\t\tgoto error_exit;\n-\t}\n-\n-\tdev = rte_eth_dev_allocate(tap_name);\n+\tdev = rte_eth_vdev_allocate(vdev, sizeof(*pmd));\n \tif (!dev) {\n \t\tRTE_LOG(ERR, PMD, \"TAP Unable to allocate device struct\\n\");\n \t\tgoto error_exit;\n \t}\n \n+\tpmd = dev->data->dev_private;\n \tsnprintf(pmd->name, sizeof(pmd->name), \"%s\", tap_name);\n-\n \tpmd->nb_queues = RTE_PMD_TAP_MAX_QUEUES;\n \n \t/* Setup some default values */\n-\tdata->dev_private = pmd;\n-\tdata->port_id = dev->data->port_id;\n+\trte_memcpy(data, dev->data, sizeof(*data));\n \tdata->dev_flags = RTE_ETH_DEV_DETACHABLE;\n-\tdata->kdrv = RTE_KDRV_NONE;\n-\tdata->drv_name = pmd_tap_drv.driver.name;\n-\tdata->numa_node = numa_node;\n-\n \tdata->dev_link = pmd_link;\n \tdata->mac_addrs = &pmd->eth_addr;\n \tdata->nb_rx_queues = pmd->nb_queues;\n@@ -688,10 +678,8 @@ eth_dev_tap_create(const char *name, char *tap_name)\n \n \tdev->data = data;\n \tdev->dev_ops = &ops;\n-\tdev->driver = NULL;\n \tdev->rx_pkt_burst = pmd_rx_burst;\n \tdev->tx_pkt_burst = pmd_tx_burst;\n-\tsnprintf(dev->data->name, sizeof(dev->data->name), \"%s\", name);\n \n \t/* Presetup the fds to -1 as being not valid */\n \tfor (i = 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) {\n@@ -702,13 +690,10 @@ eth_dev_tap_create(const char *name, char *tap_name)\n \treturn 0;\n \n error_exit:\n-\tRTE_LOG(DEBUG, PMD, \"TAP Unable to initialize %s\\n\", name);\n+\tRTE_LOG(DEBUG, PMD, \"TAP Unable to initialize %s\\n\",\n+\t\trte_vdev_device_name(vdev));\n \n \trte_free(data);\n-\trte_free(pmd);\n-\n-\trte_eth_dev_release_port(dev);\n-\n \treturn -EINVAL;\n }\n \n@@ -785,7 +770,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)\n \tRTE_LOG(NOTICE, PMD, \"Initializing pmd_tap for %s as %s\\n\",\n \t\tname, tap_name);\n \n-\tret = eth_dev_tap_create(name, tap_name);\n+\tret = eth_dev_tap_create(dev, tap_name);\n \n leave:\n \tif (ret == -1) {\n", "prefixes": [ "dpdk-dev", "06/38" ] }