Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21430/?format=api
{ "id": 21430, "url": "https://patches.dpdk.org/api/patches/21430/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-3-git-send-email-jblunck@infradead.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488794430-25179-3-git-send-email-jblunck@infradead.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1488794430-25179-3-git-send-email-jblunck@infradead.org", "date": "2017-03-06T09:59:54", "name": "[dpdk-dev,02/38] eal: parse \"driver\" device argument before probing drivers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "02f31c9bf810ee4533ec925dfa10172d967ecd1a", "submitter": { "id": 249, "url": "https://patches.dpdk.org/api/people/249/?format=api", "name": "Jan Blunck", "email": "jblunck@infradead.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488794430-25179-3-git-send-email-jblunck@infradead.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/21430/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/21430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3DA83BD2C;\n\tMon, 6 Mar 2017 11:01:19 +0100 (CET)", "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 6FDE03772\n\tfor <dev@dpdk.org>; Mon, 6 Mar 2017 11:00:47 +0100 (CET)", "by mail-wm0-f68.google.com with SMTP id n11so12814003wma.0\n\tfor <dev@dpdk.org>; Mon, 06 Mar 2017 02:00:47 -0800 (PST)", "from weierstrass.local.net ([91.200.109.169])\n\tby smtp.gmail.com with ESMTPSA id\n\tu145sm3829237wmu.1.2017.03.06.02.00.45 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Mar 2017 02:00:45 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:subject:date:message-id:in-reply-to:references;\n\tbh=iYq+6H3MbYWRLkA+gBO2bbUJGkuxp5wilAiM1jPUYP0=;\n\tb=hgKsx5AILlosmBJDCpRrZfjzJqLrSBbsOCkikD3iupeZUzs5uEPZBr0DP9dDeyZtbL\n\tDKAneStgXHWlEb7taPc+AwpE0VsANM+871+1suLPDvNPsLIjDHKf7IRuy0IJdp9NhzFr\n\tbuJzykOztVJXg/VF2G3knoIWBQQAK8WeV1h7I69JRK/wdM68jd4XGfsImOwKdYkQLeTP\n\tRLCz2jZJdNlblmBdu0tubY++5Eb+VF5nHJFq4QU+1DnLIv1btOfAMx9fa2P2iN+dPKna\n\t5wtkKeq55AGAiTNRPw17Qjjx1KGAX5rN4SLe1cKa+DC6ts56/G+ZL7mKzRS0meeSDdfV\n\tmj6A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=iYq+6H3MbYWRLkA+gBO2bbUJGkuxp5wilAiM1jPUYP0=;\n\tb=Mlqp+jzhmKk2aIOCnQ/A7VO96heFTt4Zs78dzfWNjt16kSyjTeruaavg9Mn1WiveLd\n\t7A1f7v1OmvMCDZDug3bGBuTjrN8jL0/ZoaSxhfl1iKJK3cj4k7L4rPzMVeUEYBRIN9kF\n\tTSrUIVFM1NDIWPkF2ZvtGDL63BjZe4deMTUhloxnjjzHSWSJC66F9YLBvViPlEdFK0mg\n\tdx9YlaVu+bAFhMsk2JoBPlvW61WKKES5Svw0DAhUY9w2mCzmYF2UfW3RZhijQrL1+g/U\n\tCjoafYYoCm3+1IhSYeg6Z67XuhZJ7bzovhSuOH7vjS+Ze5m0zkf3PUw5OVOyV6LtmZqc\n\tS0eQ==", "X-Gm-Message-State": "AMke39lJLHCDojBTN2sCDXEAzjCkRdXM3N9HJhTu+8xOGlBTyoAViAzQk4b0yWuwDhw4xQ==", "X-Received": "by 10.28.20.148 with SMTP id 142mr5744764wmu.134.1488794447015; \n\tMon, 06 Mar 2017 02:00:47 -0800 (PST)", "From": "Jan Blunck <jblunck@infradead.org>", "To": "dev@dpdk.org", "Date": "Mon, 6 Mar 2017 10:59:54 +0100", "Message-Id": "<1488794430-25179-3-git-send-email-jblunck@infradead.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>", "References": "<1488794430-25179-1-git-send-email-jblunck@infradead.org>", "Subject": "[dpdk-dev] [PATCH 02/38] eal: parse \"driver\" device argument before\n\tprobing drivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In some cases the virtual device name should be totally different than\nthe driver being used for the device. Therefore lets parse the devargs for\nthe \"driver\" argument before probing drivers in vdev_probe_all_drivers().\n\nSigned-off-by: Jan Blunck <jblunck@infradead.org>\n---\n lib/librte_eal/common/eal_common_vdev.c | 48 +++++++++++++++++++++++++++++----\n 1 file changed, 43 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c\nindex c922297..4b5c0eb 100644\n--- a/lib/librte_eal/common/eal_common_vdev.c\n+++ b/lib/librte_eal/common/eal_common_vdev.c\n@@ -72,12 +72,48 @@ rte_eal_vdrv_unregister(struct rte_vdev_driver *driver)\n \tTAILQ_REMOVE(&vdev_driver_list, driver, next);\n }\n \n+/*\n+ * Parse \"driver\" devargs without adding a dependency on rte_kvargs.h\n+ */\n+static char *parse_driver_arg(const char *args)\n+{\n+\tchar *str, *c;\n+\n+\tif (!args || args[0] == '\\0')\n+\t\treturn NULL;\n+\n+\tc = str = strdup(args);\n+\n+\tdo {\n+\t\tif (strncmp(c, \"driver=\", 7) == 0) {\n+\t\t\tc += 7;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tc = strchr(c, ',');\n+\t\tif (c)\n+\t\t\tc++;\n+\t} while (c);\n+\n+\tif (!c)\n+\t\tfree(str);\n+\n+\treturn c;\n+}\n+\n static int\n vdev_probe_all_drivers(struct rte_vdev_device *dev)\n {\n-\tconst char *name = rte_vdev_device_name(dev);\n+\tconst char *name;\n+\tchar *drv_name;\n \tstruct rte_vdev_driver *driver;\n-\tint ret;\n+\tint ret = 1;\n+\n+\tdrv_name = parse_driver_arg(rte_vdev_device_args(dev));\n+\tname = drv_name ? drv_name : rte_vdev_device_name(dev);\n+\n+\tRTE_LOG(DEBUG, EAL, \"Search driver %s to probe device %s\\n\", name,\n+\t\trte_vdev_device_name(dev));\n \n \tTAILQ_FOREACH(driver, &vdev_driver_list, next) {\n \t\t/*\n@@ -92,7 +128,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)\n \t\t\tret = driver->probe(dev);\n \t\t\tif (ret)\n \t\t\t\tdev->device.driver = NULL;\n-\t\t\treturn ret;\n+\t\t\tgoto out;\n \t\t}\n \t}\n \n@@ -105,11 +141,13 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)\n \t\t\tret = driver->probe(dev);\n \t\t\tif (ret)\n \t\t\t\tdev->device.driver = NULL;\n-\t\t\treturn ret;\n+\t\t\tbreak;\n \t\t}\n \t}\n \n-\treturn 1;\n+out:\n+\tfree(drv_name);\n+\treturn ret;\n }\n \n static struct rte_vdev_device *\n", "prefixes": [ "dpdk-dev", "02/38" ] }