Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21260/?format=api
{ "id": 21260, "url": "https://patches.dpdk.org/api/patches/21260/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488534682-3494-3-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488534682-3494-3-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1488534682-3494-3-git-send-email-yuanhan.liu@linux.intel.com", "date": "2017-03-03T09:51:07", "name": "[dpdk-dev,02/17] net/vhost: remove feature related APIs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "78c8b9920c77cbf294038b3f7872dced8923a064", "submitter": { "id": 307, "url": "https://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": { "id": 355, "url": "https://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488534682-3494-3-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/21260/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/21260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8185BBD30;\n\tFri, 3 Mar 2017 10:53:05 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id E0656201\n\tfor <dev@dpdk.org>; Fri, 3 Mar 2017 10:52:49 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Mar 2017 01:52:49 -0800", "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby fmsmga002.fm.intel.com with ESMTP; 03 Mar 2017 01:52:47 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.35,236,1484035200\"; d=\"scan'208\";\n\ta=\"1137400854\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tHarris James R <james.r.harris@intel.com>,\n\tLiu Changpeng <changpeng.liu@intel.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>", "Date": "Fri, 3 Mar 2017 17:51:07 +0800", "Message-Id": "<1488534682-3494-3-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com>", "Subject": "[dpdk-dev] [PATCH 02/17] net/vhost: remove feature related APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "vdev options is better for disabling/enabling some features.\n\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\n---\n drivers/net/vhost/rte_eth_vhost.c | 25 ------------------------\n drivers/net/vhost/rte_eth_vhost.h | 30 -----------------------------\n drivers/net/vhost/rte_pmd_vhost_version.map | 3 ---\n 3 files changed, 58 deletions(-)", "diff": "diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 62ccb74..0ebaa4a 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -963,31 +963,6 @@ struct vhost_xstats_name_off {\n \treturn 0;\n }\n \n-/**\n- * Disable features in feature_mask. Returns 0 on success.\n- */\n-int\n-rte_eth_vhost_feature_disable(uint64_t feature_mask)\n-{\n-\treturn rte_vhost_feature_disable(feature_mask);\n-}\n-\n-/**\n- * Enable features in feature_mask. Returns 0 on success.\n- */\n-int\n-rte_eth_vhost_feature_enable(uint64_t feature_mask)\n-{\n-\treturn rte_vhost_feature_enable(feature_mask);\n-}\n-\n-/* Returns currently supported vhost features */\n-uint64_t\n-rte_eth_vhost_feature_get(void)\n-{\n-\treturn rte_vhost_feature_get();\n-}\n-\n static const struct eth_dev_ops ops = {\n \t.dev_start = eth_dev_start,\n \t.dev_stop = eth_dev_stop,\ndiff --git a/drivers/net/vhost/rte_eth_vhost.h b/drivers/net/vhost/rte_eth_vhost.h\nindex 7c98b1a..ea4bce4 100644\n--- a/drivers/net/vhost/rte_eth_vhost.h\n+++ b/drivers/net/vhost/rte_eth_vhost.h\n@@ -43,36 +43,6 @@\n \n #include <rte_virtio_net.h>\n \n-/**\n- * Disable features in feature_mask.\n- *\n- * @param feature_mask\n- * Vhost features defined in \"linux/virtio_net.h\".\n- * @return\n- * - On success, zero.\n- * - On failure, a negative value.\n- */\n-int rte_eth_vhost_feature_disable(uint64_t feature_mask);\n-\n-/**\n- * Enable features in feature_mask.\n- *\n- * @param feature_mask\n- * Vhost features defined in \"linux/virtio_net.h\".\n- * @return\n- * - On success, zero.\n- * - On failure, a negative value.\n- */\n-int rte_eth_vhost_feature_enable(uint64_t feature_mask);\n-\n-/**\n- * Returns currently supported vhost features.\n- *\n- * @return\n- * Vhost features defined in \"linux/virtio_net.h\".\n- */\n-uint64_t rte_eth_vhost_feature_get(void);\n-\n /*\n * Event description.\n */\ndiff --git a/drivers/net/vhost/rte_pmd_vhost_version.map b/drivers/net/vhost/rte_pmd_vhost_version.map\nindex 3d44083..695db85 100644\n--- a/drivers/net/vhost/rte_pmd_vhost_version.map\n+++ b/drivers/net/vhost/rte_pmd_vhost_version.map\n@@ -1,9 +1,6 @@\n DPDK_16.04 {\n \tglobal:\n \n-\trte_eth_vhost_feature_disable;\n-\trte_eth_vhost_feature_enable;\n-\trte_eth_vhost_feature_get;\n \trte_eth_vhost_get_queue_event;\n \n \tlocal: *;\n", "prefixes": [ "dpdk-dev", "02/17" ] }