Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 21160,
    "url": "https://patches.dpdk.org/api/patches/21160/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170303031727.461-6-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170303031727.461-6-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170303031727.461-6-qi.z.zhang@intel.com",
    "date": "2017-03-03T03:17:15",
    "name": "[dpdk-dev,05/17] net/fm10k/base: clean up the logic",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "a2833443159c563fbc872f5f2be6e728ffbd54ba",
    "submitter": {
        "id": 504,
        "url": "https://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170303031727.461-6-qi.z.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/21160/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/21160/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9B933F618;\n\tFri,  3 Mar 2017 03:27:11 +0100 (CET)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 4D4D92952\n\tfor <dev@dpdk.org>; Fri,  3 Mar 2017 03:26:42 +0100 (CET)",
            "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga104.jf.intel.com with ESMTP; 02 Mar 2017 18:26:41 -0800",
            "from unknown (HELO localhost.localdomain.sh.intel.com)\n\t([10.239.129.167])\n\tby orsmga005.jf.intel.com with ESMTP; 02 Mar 2017 18:26:40 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.35,234,1484035200\"; d=\"scan'208\";a=\"71069219\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "jing.d.chen@intel.com",
        "Cc": "helin.zhang@intel.com,\n\tdev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>",
        "Date": "Thu,  2 Mar 2017 22:17:15 -0500",
        "Message-Id": "<20170303031727.461-6-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20170303031727.461-1-qi.z.zhang@intel.com>",
        "References": "<20170303031727.461-1-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 05/17] net/fm10k/base: clean up the logic",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Clean up the logic in fm10k_tlv_attr_parse, we\nshould not reply on that FM10K_NOT_IMPLEMENTED is\ngreater than zero, as this can easily cause confusion.\nThe patch also correct a minor document error.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/fm10k/base/fm10k_tlv.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/net/fm10k/base/fm10k_tlv.c b/drivers/net/fm10k/base/fm10k_tlv.c\nindex e6150c1..0328ede 100644\n--- a/drivers/net/fm10k/base/fm10k_tlv.c\n+++ b/drivers/net/fm10k/base/fm10k_tlv.c\n@@ -520,7 +520,8 @@ STATIC s32 fm10k_tlv_attr_validate(u32 *attr,\n  *  up into an array of pointers stored in results.  The function will\n  *  return FM10K_ERR_PARAM on any input or message error,\n  *  FM10K_NOT_IMPLEMENTED for any attribute that is outside of the array\n- *  and 0 on success.\n+ *  and 0 on success. Any attributes not found in tlv_attr will be silently\n+ *  ignored.\n  **/\n static s32 fm10k_tlv_attr_parse(u32 *attr, u32 **results,\n \t\t\t\tconst struct fm10k_tlv_attr *tlv_attr)\n@@ -559,14 +560,15 @@ static s32 fm10k_tlv_attr_parse(u32 *attr, u32 **results,\n \twhile (offset < len) {\n \t\tattr_id = *attr & FM10K_TLV_ID_MASK;\n \n-\t\tif (attr_id < FM10K_TLV_RESULTS_MAX)\n-\t\t\terr = fm10k_tlv_attr_validate(attr, tlv_attr);\n-\t\telse\n-\t\t\terr = FM10K_NOT_IMPLEMENTED;\n+\t\tif (attr_id >= FM10K_TLV_RESULTS_MAX)\n+\t\t\treturn FM10K_NOT_IMPLEMENTED;\n \n-\t\tif (err < 0)\n+\t\terr = fm10k_tlv_attr_validate(attr, tlv_attr);\n+\t\tif (err == FM10K_NOT_IMPLEMENTED)\n+\t\t\t; /* silently ignore non-implemented attributes */\n+\t\telse if (err)\n \t\t\treturn err;\n-\t\tif (!err)\n+\t\telse\n \t\t\tresults[attr_id] = attr;\n \n \t\t/* update offset */\n",
    "prefixes": [
        "dpdk-dev",
        "05/17"
    ]
}