Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21147/?format=api
{ "id": 21147, "url": "https://patches.dpdk.org/api/patches/21147/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488470591-5853-12-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488470591-5853-12-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1488470591-5853-12-git-send-email-arybchenko@solarflare.com", "date": "2017-03-02T16:03:11", "name": "[dpdk-dev,11/11] net/sfc: add unknown unicast/multicast match in flow API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "554717994b5b46c1c4ae727f34f3dd65ebc897c6", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488470591-5853-12-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/21147/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/21147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7EBCEF96B;\n\tThu, 2 Mar 2017 17:04:34 +0100 (CET)", "from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com\n\t[209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 93B75F60C\n\tfor <dev@dpdk.org>; Thu, 2 Mar 2017 17:04:14 +0100 (CET)", "from unknown [12.187.104.26] (EHLO nbfkord-smmo01.seg.att.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\te7248b85.2b9540499940.805669.00-2492.2324333.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tThu, 02 Mar 2017 16:04:14 +0000 (UTC)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\t17248b85.0.805630.00-2341.2324289.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tThu, 02 Mar 2017 16:04:03 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Thu, 2 Mar 2017 08:03:41 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Thu, 2 Mar 2017 08:03:41 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv22G3eRk007976; Thu, 2 Mar 2017 16:03:40 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv22G3dWu005942; Thu, 2 Mar 2017 16:03:40 GMT" ], "X-MXL-Hash": [ "58b8427e70785cb8-b54b2721f29088077958af72d8e550b3238f5316", "58b84273159ec52a-03d24925cac512f856885698c5af3f416a7c1087" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Roman Zhukov <Roman.Zhukov@oktetlabs.ru>", "Date": "Thu, 2 Mar 2017 16:03:11 +0000", "Message-ID": "<1488470591-5853-12-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1488470591-5853-1-git-send-email-arybchenko@solarflare.com>", "References": "<1488470591-5853-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=LaQ6n2ri c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=6Iz7jQTuP9IA:10 a=pK7X0mNQAAAA:8 a=zRKbQ67AAAAA:8 a=]", "[-JkzxDlHddFFsAgQEuIA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a]", "[=fH-BJDhb3eu3mg5H:21 a=t4ImBl-vaHLBeeO9:21 a=5HA-qpC1VU4iI]", "[GLgRoNS:22 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 11/11] net/sfc: add unknown unicast/multicast\n\tmatch in flow API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>\n\nSupport individual/group destination address match (unknown unicast\nand all-multicast correspondingly in terms of firmware).\n\nSigned-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andrew Lee <alee@solarflare.com>\n---\n doc/guides/nics/sfc_efx.rst | 11 ++++++++++-\n drivers/net/sfc/sfc_flow.c | 14 ++++++++++++++\n 2 files changed, 24 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 4d91b1d..8229d7d 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -127,7 +127,8 @@ Supported pattern items:\n \n - VOID\n \n-- ETH (exact match of source/destination addresses, EtherType)\n+- ETH (exact match of source/destination addresses, individual/group match\n+ of destination address, EtherType)\n \n - VLAN (exact match of VID, double-tagging is supported)\n \n@@ -149,6 +150,14 @@ Supported actions:\n \n Validating flow rules depends on the firmware variant.\n \n+Ethernet destinaton individual/group match\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Ethernet item supports I/G matching, if only the corresponding bit is set\n+in the mask of destination address. If destinaton address in the spec is\n+multicast, it matches all multicast (and broadcast) packets, oherwise it\n+matches unicast packets that are not filtered by other flow rules.\n+\n \n Supported NICs\n --------------\ndiff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 7a1f38f..defdb2f 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -212,6 +212,8 @@ sfc_flow_parse_eth(const struct rte_flow_item *item,\n \t\t.src.addr_bytes = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff },\n \t\t.type = 0xffff,\n \t};\n+\tconst uint8_t ig_mask[EFX_MAC_ADDR_LEN] =\n+\t\t{ 0x01, 0x00, 0x00, 0x00, 0x00, 0x00 };\n \n \trc = sfc_flow_parse_init(item,\n \t\t\t\t (const void **)&spec,\n@@ -227,10 +229,22 @@ sfc_flow_parse_eth(const struct rte_flow_item *item,\n \tif (spec == NULL)\n \t\treturn 0;\n \n+\t/*\n+\t * In addition to full and empty masks of destination address,\n+\t * individual/group mask is also supported\n+\t */\n \tif (is_same_ether_addr(&mask->dst, &supp_mask.dst)) {\n \t\tefx_spec->efs_match_flags |= EFX_FILTER_MATCH_LOC_MAC;\n \t\trte_memcpy(efx_spec->efs_loc_mac, spec->dst.addr_bytes,\n \t\t\t EFX_MAC_ADDR_LEN);\n+\t} else if (memcmp(mask->dst.addr_bytes, ig_mask,\n+\t\t\t EFX_MAC_ADDR_LEN) == 0) {\n+\t\tif (is_unicast_ether_addr(&spec->dst))\n+\t\t\tefx_spec->efs_match_flags |=\n+\t\t\t\tEFX_FILTER_MATCH_UNKNOWN_UCAST_DST;\n+\t\telse\n+\t\t\tefx_spec->efs_match_flags |=\n+\t\t\t\tEFX_FILTER_MATCH_UNKNOWN_MCAST_DST;\n \t} else if (!is_zero_ether_addr(&mask->dst)) {\n \t\tgoto fail_bad_mask;\n \t}\n", "prefixes": [ "dpdk-dev", "11/11" ] }