Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20993/?format=api
{ "id": 20993, "url": "https://patches.dpdk.org/api/patches/20993/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/8995ab6d0107cfc12355a4557aa9a47d363f36cb.1488372438.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<8995ab6d0107cfc12355a4557aa9a47d363f36cb.1488372438.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/8995ab6d0107cfc12355a4557aa9a47d363f36cb.1488372438.git.nelio.laranjeiro@6wind.com", "date": "2017-03-01T12:49:45", "name": "[dpdk-dev,v2,6/9] net/mlx5: support flag flow action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d393d8e2b216e0faf04660bde73e2fa2f73a231a", "submitter": { "id": 243, "url": "https://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/8995ab6d0107cfc12355a4557aa9a47d363f36cb.1488372438.git.nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/20993/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/20993/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AA61BF616;\n\tWed, 1 Mar 2017 13:50:39 +0100 (CET)", "from mail-wr0-f181.google.com (mail-wr0-f181.google.com\n\t[209.85.128.181]) by dpdk.org (Postfix) with ESMTP id BE0862B86\n\tfor <dev@dpdk.org>; Wed, 1 Mar 2017 13:50:17 +0100 (CET)", "by mail-wr0-f181.google.com with SMTP id l37so29397257wrc.1\n\tfor <dev@dpdk.org>; Wed, 01 Mar 2017 04:50:17 -0800 (PST)", "from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tl45sm6502268wrc.14.2017.03.01.04.50.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 01 Mar 2017 04:50:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=uhGbRYJMGU9dIUQr+udg+PVYmea3tfV2sSRyWn132G4=;\n\tb=F83AiM04+22p43++4UbZqzpkuwSGzzC7vJTrnRb8hKqb127I2qi/wdA83mcCmHp1TQ\n\t4BYEde0DnleCdLakLdh9EymLw1W23bzSNwiFqMWLcTSrhwDE6ipWFzCaTpPNMHpWGGDK\n\tqD2e0N12joq+zHh0eZpDXk8F9QY1w/O8vRqACitAe64WVic5NF0Sfpl+uAAhHUyiccja\n\tiJ04prho5zG7pA4zELvQ/E7y8PKmazZGW/bYN1OjLImZHRCpOqQHNvmv1CEWRdRd1i8Z\n\t07859DlLA4+CYvPoMhvoSQS53z2Q+x0q0hP6UUlNReTiOUzTLH9bR+TxUTmrfw+oE5IB\n\tl3dA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=uhGbRYJMGU9dIUQr+udg+PVYmea3tfV2sSRyWn132G4=;\n\tb=niIQmCyXEPd3ZpQjl5rr6ovutHPK9nbdfftFotfzgX3ovO35oDrhOKvPzpxdcU/zdl\n\tsVVm/KYHnvVqBprZdSYnRgTAgKvkULwp6bW9lvNEEbjk9xJTE/1mJBBJv9v8u+PfMZJU\n\tchIYMXx2r0cMuq0OwFJcsYqVWKPQjr6XhG1fo1kSn9qbPAjd9RkhauBWCXBmhz6WO9uJ\n\tVSi0AXXKtGET/xbIS8+tM1pyhmz/MQgoFKRkB68XmXpdYenmDD3grip1qR60TVqQQrys\n\tInoj2bwyLEtBzNiaaRHiZCuWT//nYY34AKMJTjr5x+8A6Aiy6HdN3C60hFnHl4nuiyZD\n\t1ppQ==", "X-Gm-Message-State": "AMke39npgcsLXbjhMv/sxyUKSlHKZ/SDrYxxP7uqd/wGc13xhQn35X405kmKNL0b4mJKa0wq", "X-Received": "by 10.223.181.129 with SMTP id c1mr7208952wre.147.1488372617371; \n\tWed, 01 Mar 2017 04:50:17 -0800 (PST)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 1 Mar 2017 13:49:45 +0100", "Message-Id": "<8995ab6d0107cfc12355a4557aa9a47d363f36cb.1488372438.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1488372438.git.nelio.laranjeiro@6wind.com>", "<cover.1488372438.git.nelio.laranjeiro@6wind.com>" ], "References": [ "<cover.1488372438.git.nelio.laranjeiro@6wind.com>", "<cover.1488364873.git.nelio.laranjeiro@6wind.com>\n\t<cover.1488372438.git.nelio.laranjeiro@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v2 6/9] net/mlx5: support flag flow action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This action is not terminal in this PMD, it must be followed by a queue\naction.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 5 +++++\n drivers/net/mlx5/mlx5_prm.h | 7 ++++---\n drivers/net/mlx5/mlx5_rxtx.c | 19 +++++++++++--------\n 3 files changed, 20 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex a885f6e..39a96ea 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -146,6 +146,7 @@ static const enum rte_flow_action_type valid_actions[] = {\n \tRTE_FLOW_ACTION_TYPE_DROP,\n \tRTE_FLOW_ACTION_TYPE_QUEUE,\n \tRTE_FLOW_ACTION_TYPE_MARK,\n+\tRTE_FLOW_ACTION_TYPE_FLAG,\n \tRTE_FLOW_ACTION_TYPE_END,\n };\n \n@@ -476,6 +477,8 @@ priv_flow_validate(struct priv *priv,\n \t\t\t\treturn -rte_errno;\n \t\t\t}\n \t\t\taction.mark = 1;\n+\t\t} else if (actions->type == RTE_FLOW_ACTION_TYPE_FLAG) {\n+\t\t\taction.mark = 1;\n \t\t} else {\n \t\t\tgoto exit_action_not_supported;\n \t\t}\n@@ -1061,6 +1064,8 @@ priv_flow_create(struct priv *priv,\n \t\t\tif (mark)\n \t\t\t\taction.mark_id = mark->id;\n \t\t\taction.mark = !action.drop;\n+\t\t} else if (actions->type == RTE_FLOW_ACTION_TYPE_FLAG) {\n+\t\t\taction.mark = 1;\n \t\t} else {\n \t\t\trte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\ndiff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h\nindex 33fc386..0a77f5b 100644\n--- a/drivers/net/mlx5/mlx5_prm.h\n+++ b/drivers/net/mlx5/mlx5_prm.h\n@@ -233,9 +233,11 @@ mlx5_flow_mark_set(uint32_t val)\n \n \t/*\n \t * Add one to the user value to differentiate un-marked flows from\n-\t * marked flows.\n+\t * marked flows, if the ID is equal to MLX5_FLOW_MARK_DEFAULT it\n+\t * remains untouched.\n \t */\n-\t++val;\n+\tif (val != MLX5_FLOW_MARK_DEFAULT)\n+\t\t++val;\n #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN\n \t/*\n \t * Mark is 24 bits (minus reserved values) but is stored on a 32 bit\n@@ -247,7 +249,6 @@ mlx5_flow_mark_set(uint32_t val)\n #else\n \tret = val;\n #endif\n-\tassert(ret <= MLX5_FLOW_MARK_MAX);\n \treturn ret;\n }\n \ndiff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex 122847d..58dd7c8 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -1538,14 +1538,17 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\t\t\tpkt->hash.rss = rss_hash_res;\n \t\t\t\tpkt->ol_flags = PKT_RX_RSS_HASH;\n \t\t\t}\n-\t\t\tif (rxq->mark &&\n-\t\t\t ((cqe->sop_drop_qpn !=\n-\t\t\t htonl(MLX5_FLOW_MARK_INVALID)) &&\n-\t\t\t (cqe->sop_drop_qpn !=\n-\t\t\t htonl(MLX5_FLOW_MARK_DEFAULT)))) {\n-\t\t\t\tpkt->hash.fdir.hi =\n-\t\t\t\t\tmlx5_flow_mark_get(cqe->sop_drop_qpn);\n-\t\t\t\tpkt->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;\n+\t\t\tif (rxq->mark && (cqe->sop_drop_qpn !=\n+\t\t\t\t\t htonl(MLX5_FLOW_MARK_INVALID))) {\n+\t\t\t\tpkt->ol_flags |= PKT_RX_FDIR;\n+\t\t\t\tif (cqe->sop_drop_qpn !=\n+\t\t\t\t htonl(MLX5_FLOW_MARK_DEFAULT)) {\n+\t\t\t\t\tuint32_t mark = cqe->sop_drop_qpn;\n+\n+\t\t\t\t\tpkt->ol_flags |= PKT_RX_FDIR_ID;\n+\t\t\t\t\tpkt->hash.fdir.hi =\n+\t\t\t\t\t\tmlx5_flow_mark_get(mark);\n+\t\t\t\t}\n \t\t\t}\n \t\t\tif (rxq->csum | rxq->csum_l2tun | rxq->vlan_strip |\n \t\t\t rxq->crc_present) {\n", "prefixes": [ "dpdk-dev", "v2", "6/9" ] }