Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20962/?format=api
{ "id": 20962, "url": "https://patches.dpdk.org/api/patches/20962/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170228185315.12546-21-aconole@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170228185315.12546-21-aconole@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170228185315.12546-21-aconole@redhat.com", "date": "2017-02-28T18:53:09", "name": "[dpdk-dev,v6,20/26] eal_pci: continue probing even on failures", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "adf9863827a9c17b9e8d43ab720978ea43952d61", "submitter": { "id": 332, "url": "https://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170228185315.12546-21-aconole@redhat.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/20962/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/20962/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 69223F977;\n\tTue, 28 Feb 2017 19:54:36 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id A01502B86\n\tfor <dev@dpdk.org>; Tue, 28 Feb 2017 19:53:29 +0100 (CET)", "from int-mx11.intmail.prod.int.phx2.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 215604E326;\n\tTue, 28 Feb 2017 18:53:30 +0000 (UTC)", "from dhcp-25-97.bos.redhat.com ([10.18.25.172])\n\tby int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id v1SIrHWW019326; Tue, 28 Feb 2017 13:53:29 -0500" ], "From": "Aaron Conole <aconole@redhat.com>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 28 Feb 2017 13:53:09 -0500", "Message-Id": "<20170228185315.12546-21-aconole@redhat.com>", "In-Reply-To": "<20170228185315.12546-1-aconole@redhat.com>", "References": "<20170227161811.12309-1-aconole@redhat.com>\n\t<20170228185315.12546-1-aconole@redhat.com>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.24", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]); Tue, 28 Feb 2017 18:53:30 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v6 20/26] eal_pci: continue probing even on\n\tfailures", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some devices may be inaccessible for a variety of reasons, or the\nPCI-bus may be unavailable causing the whole thing to fail. Still,\nbetter to continue attempts at probes.\n\nSigned-off-by: Aaron Conole <aconole@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/common/eal_common_pci.c | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex 72547bd..9416190 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -69,6 +69,7 @@\n #include <sys/queue.h>\n #include <sys/mman.h>\n \n+#include <rte_errno.h>\n #include <rte_interrupts.h>\n #include <rte_log.h>\n #include <rte_pci.h>\n@@ -416,6 +417,7 @@ rte_eal_pci_probe(void)\n \tstruct rte_pci_device *dev = NULL;\n \tstruct rte_devargs *devargs;\n \tint probe_all = 0;\n+\tint ret_1 = 0;\n \tint ret = 0;\n \n \tif (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) == 0)\n@@ -430,17 +432,20 @@ rte_eal_pci_probe(void)\n \n \t\t/* probe all or only whitelisted devices */\n \t\tif (probe_all)\n-\t\t\tret = pci_probe_all_drivers(dev);\n+\t\t\tret_1 = pci_probe_all_drivers(dev);\n \t\telse if (devargs != NULL &&\n \t\t\tdevargs->type == RTE_DEVTYPE_WHITELISTED_PCI)\n-\t\t\tret = pci_probe_all_drivers(dev);\n-\t\tif (ret < 0)\n-\t\t\trte_exit(EXIT_FAILURE, \"Requested device \" PCI_PRI_FMT\n+\t\t\tret_1 = pci_probe_all_drivers(dev);\n+\t\tif (ret_1 < 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Requested device \" PCI_PRI_FMT\n \t\t\t\t \" cannot be used\\n\", dev->addr.domain, dev->addr.bus,\n \t\t\t\t dev->addr.devid, dev->addr.function);\n+\t\t\trte_errno = errno;\n+\t\t\tret = 1;\n+\t\t}\n \t}\n \n-\treturn 0;\n+\treturn -ret;\n }\n \n /* dump one device */\n", "prefixes": [ "dpdk-dev", "v6", "20/26" ] }