Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20947/?format=api
https://patches.dpdk.org/api/patches/20947/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170228185315.12546-6-aconole@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170228185315.12546-6-aconole@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170228185315.12546-6-aconole@redhat.com", "date": "2017-02-28T18:52:54", "name": "[dpdk-dev,v6,05/26] eal: do not panic if parsing args returns error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "94f55f5958d7ff00558de76e3cbddbdc4a07ea87", "submitter": { "id": 332, "url": "https://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170228185315.12546-6-aconole@redhat.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/20947/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/20947/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1EDC4F60C;\n\tTue, 28 Feb 2017 19:54:08 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id DFDE72BB2\n\tfor <dev@dpdk.org>; Tue, 28 Feb 2017 19:53:20 +0100 (CET)", "from int-mx11.intmail.prod.int.phx2.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 53F9E3A76BB;\n\tTue, 28 Feb 2017 18:53:21 +0000 (UTC)", "from dhcp-25-97.bos.redhat.com ([10.18.25.172])\n\tby int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id v1SIrHWH019326; Tue, 28 Feb 2017 13:53:20 -0500" ], "From": "Aaron Conole <aconole@redhat.com>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 28 Feb 2017 13:52:54 -0500", "Message-Id": "<20170228185315.12546-6-aconole@redhat.com>", "In-Reply-To": "<20170228185315.12546-1-aconole@redhat.com>", "References": "<20170227161811.12309-1-aconole@redhat.com>\n\t<20170228185315.12546-1-aconole@redhat.com>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.24", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]); Tue, 28 Feb 2017 18:53:21 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v6 05/26] eal: do not panic if parsing args\n\treturns error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It's possible that the application could take a corrective action here,\nand either prompt the user for different arguments, or at least perform\na better logging. Exiting this early prevents any useful information\ngathering from the application layer.\n\nSigned-off-by: Aaron Conole <aconole@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 12bd941..f7511ab 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -781,8 +781,12 @@ rte_eal_init(int argc, char **argv)\n \t}\n \n \tfctret = eal_parse_args(argc, argv);\n-\tif (fctret < 0)\n-\t\texit(1);\n+\tif (fctret < 0) {\n+\t\trte_eal_init_alert(\"Invalid 'command line' arguments.\");\n+\t\trte_errno = EINVAL;\n+\t\trte_atomic32_clear(&run_once);\n+\t\treturn -1;\n+\t}\n \n \tif (internal_config.no_hugetlbfs == 0 &&\n \t\t\tinternal_config.process_type != RTE_PROC_SECONDARY &&\n", "prefixes": [ "dpdk-dev", "v6", "05/26" ] }{ "id": 20947, "url": "