Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20845/?format=api
https://patches.dpdk.org/api/patches/20845/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488182237-10247-10-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488182237-10247-10-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1488182237-10247-10-git-send-email-rasesh.mody@cavium.com", "date": "2017-02-27T07:56:25", "name": "[dpdk-dev,09/61] net/qede/base: remove attribute field from update current config", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e5326f1bf9ef9d6d7d029d61cbdf67549af9e8dd", "submitter": { "id": 569, "url": "https://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488182237-10247-10-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/20845/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/20845/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E9625F95C;\n\tMon, 27 Feb 2017 08:58:10 +0100 (CET)", "from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com\n\t[67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 9418FF950\n\tfor <dev@dpdk.org>; Mon, 27 Feb 2017 08:57:56 +0100 (CET)", "from pps.filterd (m0085408.ppops.net [127.0.0.1])\n\tby mx0b-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv1R7vWDN010877; Sun, 26 Feb 2017 23:57:55 -0800", "from avcashub1.qlogic.com ([198.186.0.115])\n\tby mx0b-0016ce01.pphosted.com with ESMTP id 28ut281v1t-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tSun, 26 Feb 2017 23:57:54 -0800", "from avluser05.qlc.com (10.1.113.115) by avcashub1.qlogic.org\n\t(10.1.4.190) with Microsoft SMTP Server (TLS) id 14.3.235.1;\n\tSun, 26 Feb 2017 23:57:54 -0800", "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid v1R7vscC010401;\tSun, 26 Feb 2017 23:57:54 -0800" ], "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@cavium.com using -f", "From": "Rasesh Mody <rasesh.mody@cavium.com>", "To": "<dev@dpdk.org>", "CC": "Rasesh Mody <rasesh.mody@cavium.com>, <Dept-EngDPDKDev@cavium.com>", "Date": "Sun, 26 Feb 2017 23:56:25 -0800", "Message-ID": "<1488182237-10247-10-git-send-email-rasesh.mody@cavium.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1488182237-10247-1-git-send-email-rasesh.mody@cavium.com>", "References": "<1488182237-10247-1-git-send-email-rasesh.mody@cavium.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8451\n\tsignatures=669242", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1702020001\n\tdefinitions=main-1702270081", "Subject": "[dpdk-dev] [PATCH 09/61] net/qede/base: remove attribute field from\n\tupdate current config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove attribute field from update_current_config() API, Management FW\nneed to know only the last entity who configured the device.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_mcp.c | 5 ++---\n drivers/net/qede/base/ecore_mcp_api.h | 8 --------\n 2 files changed, 2 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c\nindex 8d747c2..cc69b65 100644\n--- a/drivers/net/qede/base/ecore_mcp.c\n+++ b/drivers/net/qede/base/ecore_mcp.c\n@@ -1710,14 +1710,13 @@ enum _ecore_status_t ecore_mcp_resume(struct ecore_hwfn *p_hwfn,\n enum _ecore_status_t\n ecore_mcp_ov_update_current_config(struct ecore_hwfn *p_hwfn,\n \t\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t\t enum ecore_ov_config_method config,\n \t\t\t\t enum ecore_ov_client client)\n {\n \tenum _ecore_status_t rc;\n \tu32 resp = 0, param = 0;\n \tu32 drv_mb_param;\n \n-\tswitch (config) {\n+\tswitch (client) {\n \tcase ECORE_OV_CLIENT_DRV:\n \t\tdrv_mb_param = DRV_MB_PARAM_OV_CURR_CFG_OS;\n \t\tbreak;\n@@ -1728,7 +1727,7 @@ enum _ecore_status_t\n \t\tdrv_mb_param = DRV_MB_PARAM_OV_CURR_CFG_VENDOR_SPEC;\n \t\tbreak;\n \tdefault:\n-\t\tDP_NOTICE(p_hwfn, true, \"Invalid client type %d\\n\", config);\n+\t\tDP_NOTICE(p_hwfn, true, \"Invalid client type %d\\n\", client);\n \t\treturn ECORE_INVAL;\n \t}\n \ndiff --git a/drivers/net/qede/base/ecore_mcp_api.h b/drivers/net/qede/base/ecore_mcp_api.h\nindex 614cf67..72a58e4 100644\n--- a/drivers/net/qede/base/ecore_mcp_api.h\n+++ b/drivers/net/qede/base/ecore_mcp_api.h\n@@ -173,12 +173,6 @@ enum ecore_mcp_protocol_type {\n };\n #endif\n \n-enum ecore_ov_config_method {\n-\tECORE_OV_CONFIG_MTU,\n-\tECORE_OV_CONFIG_MAC,\n-\tECORE_OV_CONFIG_WOL\n-};\n-\n enum ecore_ov_client {\n \tECORE_OV_CLIENT_DRV,\n \tECORE_OV_CLIENT_USER,\n@@ -453,7 +447,6 @@ enum _ecore_status_t ecore_start_recovery_process(struct ecore_hwfn *p_hwfn,\n *\n * @param p_hwfn\n * @param p_ptt\n- * @param config - Configuation that has been updated\n * @param client - ecore client type\n *\n * @return enum _ecore_status_t - ECORE_SUCCESS - operation was successful.\n@@ -461,7 +454,6 @@ enum _ecore_status_t ecore_start_recovery_process(struct ecore_hwfn *p_hwfn,\n enum _ecore_status_t\n ecore_mcp_ov_update_current_config(struct ecore_hwfn *p_hwfn,\n \t\t\t\t struct ecore_ptt *p_ptt,\n-\t\t\t\t enum ecore_ov_config_method config,\n \t\t\t\t enum ecore_ov_client client);\n \n /**\n", "prefixes": [ "dpdk-dev", "09/61" ] }{ "id": 20845, "url": "