Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 20633,
    "url": "https://patches.dpdk.org/api/patches/20633/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1487647073-129064-11-git-send-email-david.hunt@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1487647073-129064-11-git-send-email-david.hunt@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1487647073-129064-11-git-send-email-david.hunt@intel.com",
    "date": "2017-02-21T03:17:46",
    "name": "[dpdk-dev,v7,10/17] test: test single and burst distributor API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "82fe67d9a05a880405734c2e39d449f8446ced61",
    "submitter": {
        "id": 342,
        "url": "https://patches.dpdk.org/api/people/342/?format=api",
        "name": "Hunt, David",
        "email": "david.hunt@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1487647073-129064-11-git-send-email-david.hunt@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/20633/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/20633/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2CFEEF94F;\n\tTue, 21 Feb 2017 11:17:57 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 8407A69C3\n\tfor <dev@dpdk.org>; Tue, 21 Feb 2017 11:17:27 +0100 (CET)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Feb 2017 02:17:27 -0800",
            "from silpixa00397515.ir.intel.com (HELO\n\tsilpixa00397515.ger.corp.intel.com) ([10.237.223.14])\n\tby fmsmga004.fm.intel.com with ESMTP; 21 Feb 2017 02:17:26 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.35,189,1484035200\"; d=\"scan'208\";a=\"227857089\"",
        "From": "David Hunt <david.hunt@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "bruce.richardson@intel.com,\n\tDavid Hunt <david.hunt@intel.com>",
        "Date": "Tue, 21 Feb 2017 03:17:46 +0000",
        "Message-Id": "<1487647073-129064-11-git-send-email-david.hunt@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1487647073-129064-1-git-send-email-david.hunt@intel.com>",
        "References": "<1485163480-156507-2-git-send-email-david.hunt@intel.com>\n\t<1487647073-129064-1-git-send-email-david.hunt@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v7 10/17] test: test single and burst distributor\n\tAPI",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: David Hunt <david.hunt@intel.com>\n---\n app/test/test_distributor.c | 115 +++++++++++++++++++++++++++++++-------------\n 1 file changed, 82 insertions(+), 33 deletions(-)",
    "diff": "diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c\nindex 8866e31..c345382 100644\n--- a/app/test/test_distributor.c\n+++ b/app/test/test_distributor.c\n@@ -543,16 +543,25 @@ static\n int test_error_distributor_create_name(void)\n {\n \tstruct rte_distributor *d = NULL;\n+\tstruct rte_distributor *db = NULL;\n \tchar *name = NULL;\n \n \td = rte_distributor_create(name, rte_socket_id(),\n \t\t\trte_lcore_count() - 1,\n-\t\t\tRTE_DIST_ALG_BURST);\n+\t\t\tRTE_DIST_ALG_SINGLE);\n \tif (d != NULL || rte_errno != EINVAL) {\n \t\tprintf(\"ERROR: No error on create() with NULL name param\\n\");\n \t\treturn -1;\n \t}\n \n+\tdb = rte_distributor_create(name, rte_socket_id(),\n+\t\t\trte_lcore_count() - 1,\n+\t\t\tRTE_DIST_ALG_BURST);\n+\tif (db != NULL || rte_errno != EINVAL) {\n+\t\tprintf(\"ERROR: No error on create() with NULL param\\n\");\n+\t\treturn -1;\n+\t}\n+\n \treturn 0;\n }\n \n@@ -560,15 +569,25 @@ int test_error_distributor_create_name(void)\n static\n int test_error_distributor_create_numworkers(void)\n {\n-\tstruct rte_distributor *d = NULL;\n+\tstruct rte_distributor *ds = NULL;\n+\tstruct rte_distributor *db = NULL;\n \n-\td = rte_distributor_create(\"test_numworkers\", rte_socket_id(),\n+\tds = rte_distributor_create(\"test_numworkers\", rte_socket_id(),\n \t\t\tRTE_MAX_LCORE + 10,\n-\t\t\tRTE_DIST_ALG_BURST);\n-\tif (d != NULL || rte_errno != EINVAL) {\n+\t\t\tRTE_DIST_ALG_SINGLE);\n+\tif (ds != NULL || rte_errno != EINVAL) {\n \t\tprintf(\"ERROR: No error on create() with num_workers > MAX\\n\");\n \t\treturn -1;\n \t}\n+\n+\tdb = rte_distributor_create(\"test_numworkers\", rte_socket_id(),\n+\t\t\tRTE_MAX_LCORE + 10,\n+\t\t\tRTE_DIST_ALG_BURST);\n+\tif (db != NULL || rte_errno != EINVAL) {\n+\t\tprintf(\"ERROR: No error on create() num_workers > MAX\\n\");\n+\t\treturn -1;\n+\t}\n+\n \treturn 0;\n }\n \n@@ -601,26 +620,43 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)\n static int\n test_distributor(void)\n {\n-\tstatic struct rte_distributor *d;\n+\tstatic struct rte_distributor *ds;\n+\tstatic struct rte_distributor *db;\n+\tstatic struct rte_distributor *dist[2];\n \tstatic struct rte_mempool *p;\n+\tint i;\n \n \tif (rte_lcore_count() < 2) {\n \t\tprintf(\"ERROR: not enough cores to test distributor\\n\");\n \t\treturn -1;\n \t}\n \n-\tif (d == NULL) {\n-\t\td = rte_distributor_create(\"Test_dist_burst\",\n+\tif (db == NULL) {\n+\t\tdb = rte_distributor_create(\"Test_dist_burst\",\n \t\t\t\trte_socket_id(),\n \t\t\t\trte_lcore_count() - 1,\n \t\t\t\tRTE_DIST_ALG_BURST);\n-\t\tif (d == NULL) {\n+\t\tif (db == NULL) {\n \t\t\tprintf(\"Error creating burst distributor\\n\");\n \t\t\treturn -1;\n \t\t}\n \t} else {\n-\t\trte_distributor_flush(d);\n-\t\trte_distributor_clear_returns(d);\n+\t\trte_distributor_flush(db);\n+\t\trte_distributor_clear_returns(db);\n+\t}\n+\n+\tif (ds == NULL) {\n+\t\tds = rte_distributor_create(\"Test_dist_single\",\n+\t\t\t\trte_socket_id(),\n+\t\t\t\trte_lcore_count() - 1,\n+\t\t\t\tRTE_DIST_ALG_SINGLE);\n+\t\tif (ds == NULL) {\n+\t\t\tprintf(\"Error creating single distributor\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t} else {\n+\t\trte_distributor_flush(ds);\n+\t\trte_distributor_clear_returns(ds);\n \t}\n \n \tconst unsigned nb_bufs = (511 * rte_lcore_count()) < BIG_BATCH ?\n@@ -634,37 +670,50 @@ test_distributor(void)\n \t\t}\n \t}\n \n-\tworker_params.dist = d;\n-\tsprintf(worker_params.name, \"burst\");\n+\tdist[0] = ds;\n+\tdist[1] = db;\n \n-\trte_eal_mp_remote_launch(handle_work, &worker_params, SKIP_MASTER);\n-\tif (sanity_test(&worker_params, p) < 0)\n-\t\tgoto err;\n-\tquit_workers(&worker_params, p);\n+\tfor (i = 0; i < 2; i++) {\n \n-\trte_eal_mp_remote_launch(handle_work_with_free_mbufs, &worker_params,\n-\t\t\t\tSKIP_MASTER);\n-\tif (sanity_test_with_mbuf_alloc(&worker_params, p) < 0)\n-\t\tgoto err;\n-\tquit_workers(&worker_params, p);\n+\t\tworker_params.dist = dist[i];\n+\t\tif (i)\n+\t\t\tsprintf(worker_params.name, \"burst\");\n+\t\telse\n+\t\t\tsprintf(worker_params.name, \"single\");\n \n-\tif (rte_lcore_count() > 2) {\n-\t\trte_eal_mp_remote_launch(handle_work_for_shutdown_test,\n-\t\t\t\t&worker_params,\n-\t\t\t\tSKIP_MASTER);\n-\t\tif (sanity_test_with_worker_shutdown(&worker_params, p) < 0)\n+\t\trte_eal_mp_remote_launch(handle_work,\n+\t\t\t\t&worker_params, SKIP_MASTER);\n+\t\tif (sanity_test(&worker_params, p) < 0)\n \t\t\tgoto err;\n \t\tquit_workers(&worker_params, p);\n \n-\t\trte_eal_mp_remote_launch(handle_work_for_shutdown_test,\n-\t\t\t\t&worker_params,\n-\t\t\t\tSKIP_MASTER);\n-\t\tif (test_flush_with_worker_shutdown(&worker_params, p) < 0)\n+\t\trte_eal_mp_remote_launch(handle_work_with_free_mbufs,\n+\t\t\t\t&worker_params, SKIP_MASTER);\n+\t\tif (sanity_test_with_mbuf_alloc(&worker_params, p) < 0)\n \t\t\tgoto err;\n \t\tquit_workers(&worker_params, p);\n \n-\t} else {\n-\t\tprintf(\"Not enough cores to run tests for worker shutdown\\n\");\n+\t\tif (rte_lcore_count() > 2) {\n+\t\t\trte_eal_mp_remote_launch(handle_work_for_shutdown_test,\n+\t\t\t\t\t&worker_params,\n+\t\t\t\t\tSKIP_MASTER);\n+\t\t\tif (sanity_test_with_worker_shutdown(&worker_params,\n+\t\t\t\t\tp) < 0)\n+\t\t\t\tgoto err;\n+\t\t\tquit_workers(&worker_params, p);\n+\n+\t\t\trte_eal_mp_remote_launch(handle_work_for_shutdown_test,\n+\t\t\t\t\t&worker_params,\n+\t\t\t\t\tSKIP_MASTER);\n+\t\t\tif (test_flush_with_worker_shutdown(&worker_params,\n+\t\t\t\t\tp) < 0)\n+\t\t\t\tgoto err;\n+\t\t\tquit_workers(&worker_params, p);\n+\n+\t\t} else {\n+\t\t\tprintf(\"Too few cores to run worker shutdown test\\n\");\n+\t\t}\n+\n \t}\n \n \tif (test_error_distributor_create_numworkers() == -1 ||\n",
    "prefixes": [
        "dpdk-dev",
        "v7",
        "10/17"
    ]
}