Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 20214,
    "url": "https://patches.dpdk.org/api/patches/20214/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1486459218-11455-1-git-send-email-aleksanderx.gajewski@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1486459218-11455-1-git-send-email-aleksanderx.gajewski@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1486459218-11455-1-git-send-email-aleksanderx.gajewski@intel.com",
    "date": "2017-02-07T09:20:18",
    "name": "[dpdk-dev] app/test-crypto-perf: fix buffer not null terminated",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "329c42d96f228a75ab384c32ed7a1554d84b7643",
    "submitter": {
        "id": 665,
        "url": "https://patches.dpdk.org/api/people/665/?format=api",
        "name": "Aleksander Gajewski",
        "email": "aleksanderx.gajewski@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "https://patches.dpdk.org/api/users/22/?format=api",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1486459218-11455-1-git-send-email-aleksanderx.gajewski@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/20214/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/20214/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 288FEFFA;\n\tTue,  7 Feb 2017 10:19:00 +0100 (CET)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 3533F9E7\n\tfor <dev@dpdk.org>; Tue,  7 Feb 2017 10:18:57 +0100 (CET)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga105.jf.intel.com with ESMTP; 07 Feb 2017 01:18:56 -0800",
            "from gklab-246-020.igk.intel.com (HELO Sent) ([10.217.246.20])\n\tby fmsmga001.fm.intel.com with SMTP; 07 Feb 2017 01:18:53 -0800",
            "by Sent (sSMTP sendmail emulation); Tue, 07 Feb 2017 10:20:20 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.33,345,1477983600\"; d=\"scan'208\";\n\ta=\"1104077391\"",
        "From": "Aleksander Gajewski <aleksanderx.gajewski@intel.com>",
        "To": "declan.doherty@intel.com",
        "Cc": "dev@dpdk.org,\n\tAleksander Gajewski <aleksanderx.gajewski@intel.com>",
        "Date": "Tue,  7 Feb 2017 10:20:18 +0100",
        "Message-Id": "<1486459218-11455-1-git-send-email-aleksanderx.gajewski@intel.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "Subject": "[dpdk-dev] [PATCH] app/test-crypto-perf: fix buffer not null\n\tterminated",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix problem: the string buffer may not have a null terminator if\nthe source string's length is equal to the buffer size.\n\nCoverity issue: 141069\nFixes: f8be1786b1b8 (\"app/crypto-perf: introduce performance test\napplication\")\n\nSigned-off-by: Aleksander Gajewski <aleksanderx.gajewski@intel.com>\n---\n app/test-crypto-perf/cperf_options_parsing.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c\nindex 3b7342d..691e788 100644\n--- a/app/test-crypto-perf/cperf_options_parsing.c\n+++ b/app/test-crypto-perf/cperf_options_parsing.c\n@@ -198,7 +198,8 @@ struct name_id_map {\n \tif (strlen(arg) > (sizeof(opts->device_type) - 1))\n \t\treturn -1;\n \n-\tstrncpy(opts->device_type, arg, sizeof(opts->device_type));\n+\tstrncpy(opts->device_type, arg, sizeof(opts->device_type) - 1);\n+\t*(opts->device_type + sizeof(opts->device_type) - 1) = '\\0';\n \n \treturn 0;\n }\n",
    "prefixes": [
        "dpdk-dev"
    ]
}