Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2006/?format=api
{ "id": 2006, "url": "https://patches.dpdk.org/api/patches/2006/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1418684684-23642-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1418684684-23642-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1418684684-23642-1-git-send-email-thomas.monjalon@6wind.com", "date": "2014-12-15T23:04:44", "name": "[dpdk-dev,v2] mk: fix build with shared pcap pmd", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d4f9bea73c96fa11f643b8e1f440dfdcd994926f", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1418684684-23642-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/2006/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/2006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 09658805C;\n\tTue, 16 Dec 2014 00:05:20 +0100 (CET)", "from mail-wg0-f43.google.com (mail-wg0-f43.google.com\n\t[74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 1E6258057\n\tfor <dev@dpdk.org>; Tue, 16 Dec 2014 00:05:18 +0100 (CET)", "by mail-wg0-f43.google.com with SMTP id l18so16056338wgh.2\n\tfor <dev@dpdk.org>; Mon, 15 Dec 2014 15:05:18 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\teu15sm14899209wid.18.2014.12.15.15.05.16 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 15 Dec 2014 15:05:17 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=iSDn2bt//uU35srjmF/FBYAKdZWIgEuIfIkUOARSVxM=;\n\tb=fAuc8WY0JQOKqm05AjpGuSDcfPYwbviIB/5X6YNSJhU++JK7+0GaH+tYRcPNvRjOtl\n\t0+CNvY+WpX4x1WOUnJiHTY6Ct3QDlP92CFKFME6u72J1PC4XREiQEnUm7hMHFf+KVUQC\n\tn50hSXAHWRLsi08wDic/YFMy7cv7zpgqqBMTb8t+UdrxroMuFMePDdpBa0Rquyq/0leB\n\tGKEtY4rwwjAEsJs9DbyC2SgT1pb3UYG0ivGQSOyqIlEjpdlpHwSW/uZugX3cUOZR5o59\n\t3Ys+BFdIhj0iee3kdfNGKgCkIYKZrmiJmto4tAaoXKSkEcEeZuRCio6Hhcfb6lpHRALB\n\t3LuQ==", "X-Gm-Message-State": "ALoCoQkpFEbH0ACw+ds6t+drW7TqoImCqmGz3Ia68f/PwAYUn1HkpuSCFrqozxv/v+wuWvXYSDzd", "X-Received": "by 10.194.57.43 with SMTP id f11mr54446347wjq.6.1418684717965;\n\tMon, 15 Dec 2014 15:05:17 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Tue, 16 Dec 2014 00:04:44 +0100", "Message-Id": "<1418684684-23642-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.1.3", "In-Reply-To": "<2438199.ui6ep4sFDa@xps13>", "References": "<2438199.ui6ep4sFDa@xps13>", "Subject": "[dpdk-dev] [PATCH v2] mk: fix build with shared pcap pmd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some applications doesn't have the pcap link flag\nwhen shared libraries are enabled.\nIndeed in such case, pcap PMD must not be linked but pcap library should.\n\nActually -lpcap is always needed if pcap PMD is used,\nand -lrte_pmd_pcap must be set only with static PMD library.\nSo the flags -lrte_pmd_pcap and -lpcap are enabled separately.\n\nWorkarounds in test-pmd/ and test-pipeline/ can be removed.\n\nReported-by: Stepan Sojka <stepan.sojka@adaptivemobile.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n\nv2:\nfix in rte.app.mk\n\nv1 from Stepan:\nfix every applications\n\n app/test-pipeline/Makefile | 4 ----\n app/test-pmd/Makefile | 4 ----\n mk/rte.app.mk | 6 +++++-\n 3 files changed, 5 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test-pipeline/Makefile b/app/test-pipeline/Makefile\nindex b81652f..aa6df0c 100644\n--- a/app/test-pipeline/Makefile\n+++ b/app/test-pipeline/Makefile\n@@ -41,10 +41,6 @@ APP = testpipeline\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n \n-ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)\n-LDFLAGS += -lpcap\n-endif\n-\n #\n # all source are stored in SRCS-y\n #\ndiff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile\nindex 97dc2e6..dcf26f4 100644\n--- a/app/test-pmd/Makefile\n+++ b/app/test-pmd/Makefile\n@@ -41,10 +41,6 @@ APP = testpmd\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n \n-ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)\n-LDFLAGS += -lpcap\n-endif\n-\n #\n # all source are stored in SRCS-y\n #\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 84ec4df..c5eaf82 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -119,6 +119,10 @@ LDLIBS += -lm\n LDLIBS += -lrt\n endif\n \n+ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)\n+LDLIBS += -lpcap\n+endif\n+\n LDLIBS += --start-group\n \n ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y)\n@@ -207,7 +211,7 @@ LDLIBS += -lrte_pmd_ring\n endif\n \n ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)\n-LDLIBS += -lrte_pmd_pcap -lpcap\n+LDLIBS += -lrte_pmd_pcap\n endif\n \n ifeq ($(CONFIG_RTE_LIBRTE_PMD_AF_PACKET),y)\n", "prefixes": [ "dpdk-dev", "v2" ] }