Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 19488,
    "url": "https://patches.dpdk.org/api/patches/19488/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1484620116-70813-25-git-send-email-wenzhuo.lu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1484620116-70813-25-git-send-email-wenzhuo.lu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1484620116-70813-25-git-send-email-wenzhuo.lu@intel.com",
    "date": "2017-01-17T02:28:34",
    "name": "[dpdk-dev,v11,24/26] net/i40e: enhance in sanity check of MAC",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e000a0851e814e11d174761208eac0a8bce45c66",
    "submitter": {
        "id": 258,
        "url": "https://patches.dpdk.org/api/people/258/?format=api",
        "name": "Wenzhuo Lu",
        "email": "wenzhuo.lu@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1484620116-70813-25-git-send-email-wenzhuo.lu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/19488/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/19488/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2789CFA7E;\n\tTue, 17 Jan 2017 03:29:43 +0100 (CET)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id C24C4F95D\n\tfor <dev@dpdk.org>; Tue, 17 Jan 2017 03:29:04 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP; 16 Jan 2017 18:29:04 -0800",
            "from dpdk26.sh.intel.com ([10.239.128.228])\n\tby orsmga001.jf.intel.com with ESMTP; 16 Jan 2017 18:29:03 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.33,242,1477983600\"; d=\"scan'208\";\n\ta=\"1083777041\"",
        "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "\"Chen Jing D(Mark)\" <jing.d.chen@intel.com>",
        "Date": "Tue, 17 Jan 2017 10:28:34 +0800",
        "Message-Id": "<1484620116-70813-25-git-send-email-wenzhuo.lu@intel.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "In-Reply-To": "<1484620116-70813-1-git-send-email-wenzhuo.lu@intel.com>",
        "References": "<1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1484620116-70813-1-git-send-email-wenzhuo.lu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v11 24/26] net/i40e: enhance in sanity check of\n\tMAC",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n\nWhen VF sends request to add a new MAC address, PF host\nwill check if it's a non-zero or unicast address, or it\nwill return with error. In fact, VF still can set multicast\naddress. This change remove to check if it's a unicast\naddress.\n\nSigned-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>\n---\n drivers/net/i40e/i40e_pf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c\nindex 8a6733c..263e843 100644\n--- a/drivers/net/i40e/i40e_pf.c\n+++ b/drivers/net/i40e/i40e_pf.c\n@@ -753,8 +753,8 @@\n \t\tmac = (struct ether_addr *)(addr_list->list[i].addr);\n \t\t(void)rte_memcpy(&filter.mac_addr, mac, ETHER_ADDR_LEN);\n \t\tfilter.filter_type = RTE_MACVLAN_PERFECT_MATCH;\n-\t\tif(!is_valid_assigned_ether_addr(mac) ||\n-\t\t\ti40e_vsi_add_mac(vf->vsi, &filter)) {\n+\t\tif (is_zero_ether_addr(mac) ||\n+\t\t    i40e_vsi_add_mac(vf->vsi, &filter)) {\n \t\t\tret = I40E_ERR_INVALID_MAC_ADDR;\n \t\t\tgoto send_msg;\n \t\t}\n",
    "prefixes": [
        "dpdk-dev",
        "v11",
        "24/26"
    ]
}