Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1912,
    "url": "https://patches.dpdk.org/api/patches/1912/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1418181016-6973-1-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1418181016-6973-1-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1418181016-6973-1-git-send-email-helin.zhang@intel.com",
    "date": "2014-12-10T03:10:16",
    "name": "[dpdk-dev,v2] i40e: bug fix of querying reta",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4e5983a9b78d1b633777cf5a3f344dadf4f4441d",
    "submitter": {
        "id": 14,
        "url": "https://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1418181016-6973-1-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/1912/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/1912/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A2BC86A8B;\n\tWed, 10 Dec 2014 04:10:28 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id D8573DE0\n\tfor <dev@dpdk.org>; Wed, 10 Dec 2014 04:10:24 +0100 (CET)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP; 09 Dec 2014 19:10:23 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 09 Dec 2014 18:59:42 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sBA3AKaZ001787;\n\tWed, 10 Dec 2014 11:10:20 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sBA3AIPf007008; Wed, 10 Dec 2014 11:10:20 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sBA3AIRI007004; \n\tWed, 10 Dec 2014 11:10:18 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"427173537\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 10 Dec 2014 11:10:16 +0800",
        "Message-Id": "<1418181016-6973-1-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1418086399-32205-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1418086399-32205-1-git-send-email-helin.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2] i40e: bug fix of querying reta",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "There is a bug in querying reta, of storing the data to the correct entry.\nCode changes is straightforward for this bug.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c    | 2 +-\n lib/librte_pmd_i40e/i40e_ethdev_vf.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\nv2 changes:\n* Added the fix for the same issue in i40e VF driver.",
    "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 899cb42..008d62c 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -1924,7 +1924,7 @@ i40e_dev_rss_reta_query(struct rte_eth_dev *dev,\n \t\tlut = I40E_READ_REG(hw, I40E_PFQF_HLUT(i >> 2));\n \t\tfor (j = 0; j < I40E_4_BIT_WIDTH; j++) {\n \t\t\tif (mask & (0x1 << j))\n-\t\t\t\treta_conf[idx].reta[shift] = ((lut >>\n+\t\t\t\treta_conf[idx].reta[shift + j] = ((lut >>\n \t\t\t\t\t(CHAR_BIT * j)) & I40E_8_BIT_MASK);\n \t\t}\n \t}\ndiff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\nindex 7ef7d58..fe46cf1 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n@@ -1760,7 +1760,7 @@ i40evf_dev_rss_reta_query(struct rte_eth_dev *dev,\n \t\tlut = I40E_READ_REG(hw, I40E_VFQF_HLUT(i >> 2));\n \t\tfor (j = 0; j < I40E_4_BIT_WIDTH; j++) {\n \t\t\tif (mask & (0x1 << j))\n-\t\t\t\treta_conf[idx].reta[shift] =\n+\t\t\t\treta_conf[idx].reta[shift + j] =\n \t\t\t\t\t((lut >> (CHAR_BIT * j)) &\n \t\t\t\t\t\tI40E_8_BIT_MASK);\n \t\t}\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}