Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/188/?format=api
{ "id": 188, "url": "https://patches.dpdk.org/api/patches/188/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1408520788-20380-1-git-send-email-pawelx.wodkowski@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1408520788-20380-1-git-send-email-pawelx.wodkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1408520788-20380-1-git-send-email-pawelx.wodkowski@intel.com", "date": "2014-08-20T07:46:28", "name": "[dpdk-dev] ixgbe_rx_scan_hw_ring: Fix initializing id and hash fields in flow director mode.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b4f00c2ca421d9b82dac88e08576f0a12458eca9", "submitter": { "id": 58, "url": "https://patches.dpdk.org/api/people/58/?format=api", "name": "Wodkowski, PawelX", "email": "pawelx.wodkowski@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1408520788-20380-1-git-send-email-pawelx.wodkowski@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/188/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/188/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<pwodkowx@ecsmtp.ir.intel.com>", "Received": [ "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 3C2435932\n\tfor <dev@dpdk.org>; Wed, 20 Aug 2014 09:43:46 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 20 Aug 2014 00:47:17 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 20 Aug 2014 00:46:40 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts7K7kWgW030079; Wed, 20 Aug 2014 08:46:32 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id s7K7kWfl022046;\n\tWed, 20 Aug 2014 08:46:32 +0100", "(from pwodkowx@localhost)\n\tby sivswdev01.ir.intel.com with id s7K7kWlN022042;\n\tWed, 20 Aug 2014 08:46:32 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.01,900,1400050800\"; d=\"scan'208\";a=\"587327822\"", "From": "Pawel Wodkowski <pawelx.wodkowski@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 20 Aug 2014 08:46:28 +0100", "Message-Id": "<1408520788-20380-1-git-send-email-pawelx.wodkowski@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] ixgbe_rx_scan_hw_ring: Fix initializing id and\n\thash fields in flow director mode.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 20 Aug 2014 07:43:47 -0000" }, "content": "When Flow Director was used together with bulk alloc, id and hash was swapped\nwhen packet matches flow director filter due to improper fdir field initialization.\n\n\nSigned-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 24 +++++++++++++++++-------\n 1 file changed, 17 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex aaf46d4..796e5a4 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -902,6 +902,7 @@ ixgbe_rx_scan_hw_ring(struct igb_rx_queue *rxq)\n \tstruct igb_rx_entry *rxep;\n \tstruct rte_mbuf *mb;\n \tuint16_t pkt_len;\n+\tuint16_t pkt_flags;\n \tint s[LOOK_AHEAD], nb_dd;\n \tint i, j, nb_rx = 0;\n \n@@ -935,21 +936,30 @@ ixgbe_rx_scan_hw_ring(struct igb_rx_queue *rxq)\n \t\t/* Translate descriptor info to mbuf format */\n \t\tfor (j = 0; j < nb_dd; ++j) {\n \t\t\tmb = rxep[j].mbuf;\n-\t\t\tpkt_len = (uint16_t)(rxdp[j].wb.upper.length -\n-\t\t\t\t\t\t\trxq->crc_len);\n+\t\t\tpkt_len = (uint16_t)(rxdp[j].wb.upper.length - rxq->crc_len);\n \t\t\tmb->pkt.data_len = pkt_len;\n \t\t\tmb->pkt.pkt_len = pkt_len;\n-\t\t\tmb->pkt.vlan_macip.f.vlan_tci = rxdp[j].wb.upper.vlan;\n-\t\t\tmb->pkt.hash.rss = rxdp[j].wb.lower.hi_dword.rss;\n+\t\t\tmb->pkt.vlan_macip.f.vlan_tci =\n+\t\t\t\trte_le_to_cpu_16(rxdp[j].wb.upper.vlan);\n \n \t\t\t/* convert descriptor fields to rte mbuf flags */\n-\t\t\tmb->ol_flags = rx_desc_hlen_type_rss_to_pkt_flags(\n+\t\t\tpkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(\n \t\t\t\t\trxdp[j].wb.lower.lo_dword.data);\n \t\t\t/* reuse status field from scan list */\n-\t\t\tmb->ol_flags = (uint16_t)(mb->ol_flags |\n+\t\t\tpkt_flags = (uint16_t)(pkt_flags |\n \t\t\t\t\trx_desc_status_to_pkt_flags(s[j]));\n-\t\t\tmb->ol_flags = (uint16_t)(mb->ol_flags |\n+\t\t\tpkt_flags = (uint16_t)(pkt_flags |\n \t\t\t\t\trx_desc_error_to_pkt_flags(s[j]));\n+\t\t\tmb->ol_flags = pkt_flags;\n+\n+\t\t\tif (likely(pkt_flags & PKT_RX_RSS_HASH))\n+\t\t\t\tmb->pkt.hash.rss = rxdp[j].wb.lower.hi_dword.rss;\n+\t\t\telse if (pkt_flags & PKT_RX_FDIR) {\n+\t\t\t\tmb->pkt.hash.fdir.hash =\n+\t\t\t\t\t(uint16_t)((rxdp[j].wb.lower.hi_dword.csum_ip.csum)\n+\t\t\t\t\t\t& IXGBE_ATR_HASH_MASK);\n+\t\t\t\tmb->pkt.hash.fdir.id = rxdp[j].wb.lower.hi_dword.csum_ip.ip_id;\n+\t\t\t}\n \t\t}\n \n \t\t/* Move mbuf pointers from the S/W ring to the stage */\n", "prefixes": [ "dpdk-dev" ] }