Patch Comment List
List patch comments
GET /api/patches/181/comments/?format=api
[ { "id": 414, "web_url": "https://patches.dpdk.org/comment/414/", "msgid": "<D01A7C76.27BA%rsanford@akamai.com>", "list_archive_url": "https://inbox.dpdk.org/dev/D01A7C76.27BA%rsanford@akamai.com", "date": "2014-08-20T20:25:57", "subject": "Re: [dpdk-dev] [PATCH 3/6] bond: fix naming inconsistency in\n\ttx_burst_round_robin", "submitter": { "id": 59, "url": "https://patches.dpdk.org/api/people/59/?format=api", "name": "Sanford, Robert", "email": "rsanford@akamai.com" }, "content": "Reviewed-by: Robert Sanford <rsanford@akamai.com>\n\n\n>Renaming struct bond_dev_pritvate *dev_private to internals to match\n>convention used in other pmds\n>\n>Signed-off-by: Declan Doherty <declan.doherty@intel.com>\n>---\n> lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +++++-----\n> 1 files changed, 5 insertions(+), 5 deletions(-)\n>\n>diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n>b/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n>index 683b146..70123fc 100644\n>--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n>+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n>@@ -92,7 +92,7 @@ static uint16_t\n> bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs,\n> \t\tuint16_t nb_pkts)\n> {\n>-\tstruct bond_dev_private *dev_private;\n>+\tstruct bond_dev_private *internals;\n> \tstruct bond_tx_queue *bd_tx_q;\n> \n> \tstruct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_pkts];\n>@@ -107,13 +107,13 @@ bond_ethdev_tx_burst_round_robin(void *queue,\n>struct rte_mbuf **bufs,\n> \tint i, cs_idx = 0;\n> \n> \tbd_tx_q = (struct bond_tx_queue *)queue;\n>-\tdev_private = bd_tx_q->dev_private;\n>+\tinternals = bd_tx_q->dev_private;\n> \n> \t/* Copy slave list to protect against slave up/down changes during tx\n> \t * bursting */\n>-\tnum_of_slaves = dev_private->active_slave_count;\n>-\tmemcpy(slaves, dev_private->active_slaves,\n>-\t\t\tsizeof(dev_private->active_slaves[0]) * num_of_slaves);\n>+\tnum_of_slaves = internals->active_slave_count;\n>+\tmemcpy(slaves, internals->active_slaves,\n>+\t\t\tsizeof(internals->active_slaves[0]) * num_of_slaves);\n> \n> \tif (num_of_slaves < 1)\n> \t\treturn num_tx_total;\n>-- \n>1.7.0.7\n>", "headers": { "Return-Path": "<rsanford@akamai.com>", "Received": [ "from prod-mail-xrelay08.akamai.com (prod-mail-xrelay08.akamai.com\n\t[96.6.114.112]) by dpdk.org (Postfix) with ESMTP id 897325932\n\tfor <dev@dpdk.org>; Wed, 20 Aug 2014 22:22:26 +0200 (CEST)", "from prod-mail-xrelay08.akamai.com (localhost.localdomain\n\t[127.0.0.1]) by postfix.imss70 (Postfix) with ESMTP id 991804852E;\n\tWed, 20 Aug 2014 20:25:59 +0000 (GMT)", "from prod-mail-relay08.akamai.com (prod-mail-relay08.akamai.com\n\t[172.27.22.71])\n\tby prod-mail-xrelay08.akamai.com (Postfix) with ESMTP id 8D2B64840B; \n\tWed, 20 Aug 2014 20:25:59 +0000 (GMT)", "from ustx2ex-cashub.dfw01.corp.akamai.com\n\t(ustx2ex-cashub2.dfw01.corp.akamai.com [172.27.25.76])\n\tby prod-mail-relay08.akamai.com (Postfix) with ESMTP id 879009805C;\n\tWed, 20 Aug 2014 20:25:59 +0000 (GMT)", "from USMBX2.msg.corp.akamai.com ([169.254.1.85]) by\n\tustx2ex-cashub2.dfw01.corp.akamai.com ([172.27.25.76]) with mapi;\n\tWed, 20 Aug 2014 15:25:59 -0500" ], "From": "\"Sanford, Robert\" <rsanford@akamai.com>", "To": "Declan Doherty <declan.doherty@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Date": "Wed, 20 Aug 2014 15:25:57 -0500", "Thread-Topic": "[dpdk-dev] [PATCH 3/6] bond: fix naming inconsistency in\n\ttx_burst_round_robin", "Thread-Index": "Ac+8tPPOGpDX4o8qTACEhrf+Wizghg==", "Message-ID": "<D01A7C76.27BA%rsanford@akamai.com>", "References": "<1408456313-28812-1-git-send-email-declan.doherty@intel.com>\n\t<1408456313-28812-4-git-send-email-declan.doherty@intel.com>", "In-Reply-To": "<1408456313-28812-4-git-send-email-declan.doherty@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "user-agent": "Microsoft-MacOutlook/14.4.3.140616", "acceptlanguage": "en-US", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 3/6] bond: fix naming inconsistency in\n\ttx_burst_round_robin", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 20 Aug 2014 20:22:26 -0000" }, "addressed": null } ]