Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/18060/?format=api
{ "id": 18060, "url": "https://patches.dpdk.org/api/patches/18060/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20161216143919.4909-10-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20161216143919.4909-10-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20161216143919.4909-10-ferruh.yigit@intel.com", "date": "2016-12-16T14:38:59", "name": "[dpdk-dev,v4,09/29] net/i40e: fix VF reset flow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7468a34b79270b40f3bc9cbd28f4ea1353516939", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20161216143919.4909-10-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/18060/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/18060/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CC4B5FA33;\n\tFri, 16 Dec 2016 15:41:19 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 922615689;\n\tFri, 16 Dec 2016 15:41:17 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga103.jf.intel.com with ESMTP; 16 Dec 2016 06:41:16 -0800", "from sivswdev02.ir.intel.com ([10.237.217.46])\n\tby fmsmga005.fm.intel.com with ESMTP; 16 Dec 2016 06:41:15 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,358,1477983600\"; d=\"scan'208\";a=\"43277595\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Jingjing Wu <jingjing.wu@intel.com>; Helin Zhang <helin.zhang@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>, stable@dpdk.org", "Date": "Fri, 16 Dec 2016 14:38:59 +0000", "Message-Id": "<20161216143919.4909-10-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20161216143919.4909-1-ferruh.yigit@intel.com>", "References": "<1481835919-36488-1-git-send-email-qi.z.zhang@intel.com>\n\t<20161216143919.4909-1-ferruh.yigit@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 09/29] net/i40e: fix VF reset flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Qi Zhang <qi.z.zhang@intel.com>\n\nAdd missing step during VF reset: PF should\nset I40E_VFGEN_RSTAT to ACTIVE at end of the\nVF reset operation or VF driver may not able\nto detect that reset is already completed.\nThis patch also remove the unnecessary enum\nfor vfr state.\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\n\nCC: stable@dpdk.org\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/i40e/i40e_pf.c | 6 ++++--\n drivers/net/i40e/i40e_pf.h | 5 -----\n 2 files changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c\nindex 8b8a14f..2bc3355 100644\n--- a/drivers/net/i40e/i40e_pf.c\n+++ b/drivers/net/i40e/i40e_pf.c\n@@ -139,7 +139,7 @@ i40e_pf_host_vf_reset(struct i40e_pf_vf *vf, bool do_hw_reset)\n \tabs_vf_id = vf_id + hw->func_caps.vf_base_id;\n \n \t/* Notify VF that we are in VFR progress */\n-\tI40E_WRITE_REG(hw, I40E_VFGEN_RSTAT1(vf_id), I40E_PF_VFR_INPROGRESS);\n+\tI40E_WRITE_REG(hw, I40E_VFGEN_RSTAT1(vf_id), I40E_VFR_INPROGRESS);\n \n \t/*\n \t * If require a SW VF reset, a VFLR interrupt will be generated,\n@@ -220,7 +220,7 @@ i40e_pf_host_vf_reset(struct i40e_pf_vf *vf, bool do_hw_reset)\n \t}\n \n \t/* Reset done, Set COMPLETE flag and clear reset bit */\n-\tI40E_WRITE_REG(hw, I40E_VFGEN_RSTAT1(vf_id), I40E_PF_VFR_COMPLETED);\n+\tI40E_WRITE_REG(hw, I40E_VFGEN_RSTAT1(vf_id), I40E_VFR_COMPLETED);\n \tval = I40E_READ_REG(hw, I40E_VPGEN_VFRTRIG(vf_id));\n \tval &= ~I40E_VPGEN_VFRTRIG_VFSWR_MASK;\n \tI40E_WRITE_REG(hw, I40E_VPGEN_VFRTRIG(vf_id), val);\n@@ -248,6 +248,8 @@ i40e_pf_host_vf_reset(struct i40e_pf_vf *vf, bool do_hw_reset)\n \t\treturn -EFAULT;\n \t}\n \n+\tI40E_WRITE_REG(hw, I40E_VFGEN_RSTAT1(vf_id), I40E_VFR_VFACTIVE);\n+\n \treturn ret;\n }\n \ndiff --git a/drivers/net/i40e/i40e_pf.h b/drivers/net/i40e/i40e_pf.h\nindex 59bf2ee..ada398b 100644\n--- a/drivers/net/i40e/i40e_pf.h\n+++ b/drivers/net/i40e/i40e_pf.h\n@@ -48,11 +48,6 @@\n \n #define I40E_DPDK_OFFSET 0x100\n \n-enum i40e_pf_vfr_state {\n-\tI40E_PF_VFR_INPROGRESS = 0,\n-\tI40E_PF_VFR_COMPLETED = 1,\n-};\n-\n /* DPDK pf driver specific command to VF */\n enum i40e_virtchnl_ops_dpdk {\n \t/*\n", "prefixes": [ "dpdk-dev", "v4", "09/29" ] }