Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/18007/?format=api
{ "id": 18007, "url": "https://patches.dpdk.org/api/patches/18007/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1481835919-36488-3-git-send-email-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1481835919-36488-3-git-send-email-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1481835919-36488-3-git-send-email-qi.z.zhang@intel.com", "date": "2016-12-15T21:04:52", "name": "[dpdk-dev,v3,02/29] net/i40e: add callback to user on VF to PF mbox msg", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "112150775895c3ea46a7d48b807118c2685def16", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1481835919-36488-3-git-send-email-qi.z.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/18007/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/18007/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 49FF0475E;\n\tFri, 16 Dec 2016 05:09:23 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 481C5376D\n\tfor <dev@dpdk.org>; Fri, 16 Dec 2016 05:08:39 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP; 15 Dec 2016 20:08:38 -0800", "from unknown (HELO localhost.localdomain.sh.intel.com)\n\t([10.239.129.189])\n\tby fmsmga006.fm.intel.com with ESMTP; 15 Dec 2016 20:08:37 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,355,1477983600\"; d=\"scan'208\";a=\"43201924\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "jingjing.wu@intel.com,\n\thelin.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>", "Date": "Thu, 15 Dec 2016 16:04:52 -0500", "Message-Id": "<1481835919-36488-3-git-send-email-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1481835919-36488-1-git-send-email-qi.z.zhang@intel.com>", "References": "<1481835919-36488-1-git-send-email-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 02/29] net/i40e: add callback to user on VF to\n\tPF mbox msg", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Wenzhuo Lu <wenzhuo.lu@intel.com>\n\nThe callback asks the user application if it is allowed to\nperform the mailbox messages.\n\nIf the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED\nthen continue. If ACK or NACK, do nothing and send\nnot_supported to VF.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/i40e/i40e_pf.c | 230 ++++++++++++++++++++++++++++++++++------\n drivers/net/i40e/rte_pmd_i40e.h | 21 ++++\n 2 files changed, 216 insertions(+), 35 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c\nindex f70712b..8b8a14f 100644\n--- a/drivers/net/i40e/i40e_pf.c\n+++ b/drivers/net/i40e/i40e_pf.c\n@@ -55,6 +55,7 @@\n #include \"i40e_ethdev.h\"\n #include \"i40e_rxtx.h\"\n #include \"i40e_pf.h\"\n+#include \"rte_pmd_i40e.h\"\n \n #define I40E_CFG_CRCSTRIP_DEFAULT 1\n \n@@ -272,14 +273,23 @@ i40e_pf_host_send_msg_to_vf(struct i40e_pf_vf *vf,\n }\n \n static void\n-i40e_pf_host_process_cmd_version(struct i40e_pf_vf *vf)\n+i40e_pf_host_process_cmd_version(struct i40e_pf_vf *vf, bool b_op)\n {\n \tstruct i40e_virtchnl_version_info info;\n \n \tinfo.major = I40E_DPDK_VERSION_MAJOR;\n \tinfo.minor = I40E_DPDK_VERSION_MINOR;\n-\ti40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_VERSION,\n-\t\tI40E_SUCCESS, (uint8_t *)&info, sizeof(info));\n+\n+\tif (b_op)\n+\t\ti40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_VERSION,\n+\t\t\t\t\t I40E_SUCCESS,\n+\t\t\t\t\t (uint8_t *)&info,\n+\t\t\t\t\t sizeof(info));\n+\telse\n+\t\ti40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_VERSION,\n+\t\t\t\t\t I40E_NOT_SUPPORTED,\n+\t\t\t\t\t (uint8_t *)&info,\n+\t\t\t\t\t sizeof(info));\n }\n \n static int\n@@ -292,13 +302,20 @@ i40e_pf_host_process_cmd_reset_vf(struct i40e_pf_vf *vf)\n }\n \n static int\n-i40e_pf_host_process_cmd_get_vf_resource(struct i40e_pf_vf *vf)\n+i40e_pf_host_process_cmd_get_vf_resource(struct i40e_pf_vf *vf, bool b_op)\n {\n \tstruct i40e_virtchnl_vf_resource *vf_res = NULL;\n \tstruct i40e_hw *hw = I40E_PF_TO_HW(vf->pf);\n \tuint32_t len = 0;\n \tint ret = I40E_SUCCESS;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(vf,\n+\t\t\t\t\t I40E_VIRTCHNL_OP_GET_VF_RESOURCES,\n+\t\t\t\t\t I40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \t/* only have 1 VSI by default */\n \tlen = sizeof(struct i40e_virtchnl_vf_resource) +\n \t\t\t\tI40E_DEFAULT_VF_VSI_NUM *\n@@ -423,7 +440,8 @@ i40e_pf_host_hmc_config_txq(struct i40e_hw *hw,\n static int\n i40e_pf_host_process_cmd_config_vsi_queues(struct i40e_pf_vf *vf,\n \t\t\t\t\t uint8_t *msg,\n-\t\t\t\t\t uint16_t msglen)\n+\t\t\t\t\t uint16_t msglen,\n+\t\t\t\t\t bool b_op)\n {\n \tstruct i40e_hw *hw = I40E_PF_TO_HW(vf->pf);\n \tstruct i40e_vsi *vsi = vf->vsi;\n@@ -432,6 +450,13 @@ i40e_pf_host_process_cmd_config_vsi_queues(struct i40e_pf_vf *vf,\n \tstruct i40e_virtchnl_queue_pair_info *vc_qpi;\n \tint i, ret = I40E_SUCCESS;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(vf,\n+\t\t\t\t\t I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES,\n+\t\t\t\t\t I40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (!msg || vc_vqci->num_queue_pairs > vsi->nb_qps ||\n \t\tvc_vqci->num_queue_pairs > I40E_MAX_VSI_QP ||\n \t\tmsglen < I40E_VIRTCHNL_CONFIG_VSI_QUEUES_SIZE(vc_vqci,\n@@ -482,7 +507,8 @@ i40e_pf_host_process_cmd_config_vsi_queues(struct i40e_pf_vf *vf,\n static int\n i40e_pf_host_process_cmd_config_vsi_queues_ext(struct i40e_pf_vf *vf,\n \t\t\t\t\t uint8_t *msg,\n-\t\t\t\t\t uint16_t msglen)\n+\t\t\t\t\t uint16_t msglen,\n+\t\t\t\t\t bool b_op)\n {\n \tstruct i40e_hw *hw = I40E_PF_TO_HW(vf->pf);\n \tstruct i40e_vsi *vsi = vf->vsi;\n@@ -491,6 +517,14 @@ i40e_pf_host_process_cmd_config_vsi_queues_ext(struct i40e_pf_vf *vf,\n \tstruct i40e_virtchnl_queue_pair_ext_info *vc_qpei;\n \tint i, ret = I40E_SUCCESS;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (!msg || vc_vqcei->num_queue_pairs > vsi->nb_qps ||\n \t\tvc_vqcei->num_queue_pairs > I40E_MAX_VSI_QP ||\n \t\tmsglen < I40E_VIRTCHNL_CONFIG_VSI_QUEUES_SIZE(vc_vqcei,\n@@ -539,12 +573,21 @@ i40e_pf_host_process_cmd_config_vsi_queues_ext(struct i40e_pf_vf *vf,\n \n static int\n i40e_pf_host_process_cmd_config_irq_map(struct i40e_pf_vf *vf,\n-\t\t\t\t\tuint8_t *msg, uint16_t msglen)\n+\t\t\t\t\tuint8_t *msg, uint16_t msglen,\n+\t\t\t\t\tbool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_irq_map_info *irqmap =\n \t (struct i40e_virtchnl_irq_map_info *)msg;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_CONFIG_IRQ_MAP,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen < sizeof(struct i40e_virtchnl_irq_map_info)) {\n \t\tPMD_DRV_LOG(ERR, \"buffer too short\");\n \t\tret = I40E_ERR_PARAM;\n@@ -646,12 +689,21 @@ i40e_pf_host_process_cmd_enable_queues(struct i40e_pf_vf *vf,\n static int\n i40e_pf_host_process_cmd_disable_queues(struct i40e_pf_vf *vf,\n \t\t\t\t\tuint8_t *msg,\n-\t\t\t\t\tuint16_t msglen)\n+\t\t\t\t\tuint16_t msglen,\n+\t\t\t\t\tbool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_queue_select *q_sel =\n \t\t(struct i40e_virtchnl_queue_select *)msg;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_DISABLE_QUEUES,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen != sizeof(*q_sel)) {\n \t\tret = I40E_ERR_PARAM;\n \t\tgoto send_msg;\n@@ -669,7 +721,8 @@ i40e_pf_host_process_cmd_disable_queues(struct i40e_pf_vf *vf,\n static int\n i40e_pf_host_process_cmd_add_ether_address(struct i40e_pf_vf *vf,\n \t\t\t\t\t uint8_t *msg,\n-\t\t\t\t\t uint16_t msglen)\n+\t\t\t\t\t uint16_t msglen,\n+\t\t\t\t\t bool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_ether_addr_list *addr_list =\n@@ -678,6 +731,14 @@ i40e_pf_host_process_cmd_add_ether_address(struct i40e_pf_vf *vf,\n \tint i;\n \tstruct ether_addr *mac;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_ADD_ETHER_ADDRESS,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tmemset(&filter, 0 , sizeof(struct i40e_mac_filter_info));\n \n \tif (msg == NULL || msglen <= sizeof(*addr_list)) {\n@@ -707,7 +768,8 @@ i40e_pf_host_process_cmd_add_ether_address(struct i40e_pf_vf *vf,\n static int\n i40e_pf_host_process_cmd_del_ether_address(struct i40e_pf_vf *vf,\n \t\t\t\t\t uint8_t *msg,\n-\t\t\t\t\t uint16_t msglen)\n+\t\t\t\t\t uint16_t msglen,\n+\t\t\t\t\t bool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_ether_addr_list *addr_list =\n@@ -715,6 +777,14 @@ i40e_pf_host_process_cmd_del_ether_address(struct i40e_pf_vf *vf,\n \tint i;\n \tstruct ether_addr *mac;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_DEL_ETHER_ADDRESS,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen <= sizeof(*addr_list)) {\n \t\tPMD_DRV_LOG(ERR, \"delete_ether_address argument too short\");\n \t\tret = I40E_ERR_PARAM;\n@@ -739,7 +809,8 @@ i40e_pf_host_process_cmd_del_ether_address(struct i40e_pf_vf *vf,\n \n static int\n i40e_pf_host_process_cmd_add_vlan(struct i40e_pf_vf *vf,\n-\t\t\t\tuint8_t *msg, uint16_t msglen)\n+\t\t\t\tuint8_t *msg, uint16_t msglen,\n+\t\t\t\tbool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_vlan_filter_list *vlan_filter_list =\n@@ -747,6 +818,14 @@ i40e_pf_host_process_cmd_add_vlan(struct i40e_pf_vf *vf,\n \tint i;\n \tuint16_t *vid;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_ADD_VLAN,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen <= sizeof(*vlan_filter_list)) {\n \t\tPMD_DRV_LOG(ERR, \"add_vlan argument too short\");\n \t\tret = I40E_ERR_PARAM;\n@@ -771,7 +850,8 @@ i40e_pf_host_process_cmd_add_vlan(struct i40e_pf_vf *vf,\n static int\n i40e_pf_host_process_cmd_del_vlan(struct i40e_pf_vf *vf,\n \t\t\t\t uint8_t *msg,\n-\t\t\t\t uint16_t msglen)\n+\t\t\t\t uint16_t msglen,\n+\t\t\t\t bool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_vlan_filter_list *vlan_filter_list =\n@@ -779,6 +859,14 @@ i40e_pf_host_process_cmd_del_vlan(struct i40e_pf_vf *vf,\n \tint i;\n \tuint16_t *vid;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_DEL_VLAN,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen <= sizeof(*vlan_filter_list)) {\n \t\tPMD_DRV_LOG(ERR, \"delete_vlan argument too short\");\n \t\tret = I40E_ERR_PARAM;\n@@ -803,7 +891,8 @@ static int\n i40e_pf_host_process_cmd_config_promisc_mode(\n \t\t\t\t\tstruct i40e_pf_vf *vf,\n \t\t\t\t\tuint8_t *msg,\n-\t\t\t\t\tuint16_t msglen)\n+\t\t\t\t\tuint16_t msglen,\n+\t\t\t\t\tbool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_promisc_info *promisc =\n@@ -811,6 +900,14 @@ i40e_pf_host_process_cmd_config_promisc_mode(\n \tstruct i40e_hw *hw = I40E_PF_TO_HW(vf->pf);\n \tbool unicast = FALSE, multicast = FALSE;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen != sizeof(*promisc)) {\n \t\tret = I40E_ERR_PARAM;\n \t\tgoto send_msg;\n@@ -836,13 +933,20 @@ i40e_pf_host_process_cmd_config_promisc_mode(\n }\n \n static int\n-i40e_pf_host_process_cmd_get_stats(struct i40e_pf_vf *vf)\n+i40e_pf_host_process_cmd_get_stats(struct i40e_pf_vf *vf, bool b_op)\n {\n \ti40e_update_vsi_stats(vf->vsi);\n \n-\ti40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_GET_STATS,\n-\t\tI40E_SUCCESS, (uint8_t *)&vf->vsi->eth_stats,\n-\t\t\t\tsizeof(vf->vsi->eth_stats));\n+\tif (b_op)\n+\t\ti40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_GET_STATS,\n+\t\t\t\t\t I40E_SUCCESS,\n+\t\t\t\t\t (uint8_t *)&vf->vsi->eth_stats,\n+\t\t\t\t\t sizeof(vf->vsi->eth_stats));\n+\telse\n+\t\ti40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_GET_STATS,\n+\t\t\t\t\t I40E_NOT_SUPPORTED,\n+\t\t\t\t\t (uint8_t *)&vf->vsi->eth_stats,\n+\t\t\t\t\t sizeof(vf->vsi->eth_stats));\n \n \treturn I40E_SUCCESS;\n }\n@@ -851,12 +955,21 @@ static int\n i40e_pf_host_process_cmd_cfg_vlan_offload(\n \t\t\t\t\tstruct i40e_pf_vf *vf,\n \t\t\t\t\tuint8_t *msg,\n-\t\t\t\t\tuint16_t msglen)\n+\t\t\t\t\tuint16_t msglen,\n+\t\t\t\t\tbool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_vlan_offload_info *offload =\n \t\t\t(struct i40e_virtchnl_vlan_offload_info *)msg;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_CFG_VLAN_OFFLOAD,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen != sizeof(*offload)) {\n \t\tret = I40E_ERR_PARAM;\n \t\tgoto send_msg;\n@@ -877,12 +990,21 @@ i40e_pf_host_process_cmd_cfg_vlan_offload(\n static int\n i40e_pf_host_process_cmd_cfg_pvid(struct i40e_pf_vf *vf,\n \t\t\t\t\tuint8_t *msg,\n-\t\t\t\t\tuint16_t msglen)\n+\t\t\t\t\tuint16_t msglen,\n+\t\t\t\t\tbool b_op)\n {\n \tint ret = I40E_SUCCESS;\n \tstruct i40e_virtchnl_pvid_info *tpid_info =\n \t\t\t(struct i40e_virtchnl_pvid_info *)msg;\n \n+\tif (!b_op) {\n+\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\tvf,\n+\t\t\tI40E_VIRTCHNL_OP_CFG_VLAN_PVID,\n+\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\treturn ret;\n+\t}\n+\n \tif (msg == NULL || msglen != sizeof(*tpid_info)) {\n \t\tret = I40E_ERR_PARAM;\n \t\tgoto send_msg;\n@@ -923,6 +1045,8 @@ i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev,\n \tstruct i40e_pf_vf *vf;\n \t/* AdminQ will pass absolute VF id, transfer to internal vf id */\n \tuint16_t vf_id = abs_vf_id - hw->func_caps.vf_base_id;\n+\tstruct rte_pmd_i40e_mb_event_param cb_param;\n+\tbool b_op = TRUE;\n \n \tif (vf_id > pf->vf_num - 1 || !pf->vfs) {\n \t\tPMD_DRV_LOG(ERR, \"invalid argument\");\n@@ -937,10 +1061,35 @@ i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev,\n \t\treturn;\n \t}\n \n+\t/**\n+\t * initialise structure to send to user application\n+\t * will return response from user in retval field\n+\t */\n+\tcb_param.retval = RTE_PMD_I40E_MB_EVENT_PROCEED;\n+\tcb_param.vfid = vf_id;\n+\tcb_param.msg_type = opcode;\n+\tcb_param.msg = (void *)msg;\n+\tcb_param.msglen = msglen;\n+\n+\t/**\n+\t * Ask user application if we're allowed to perform those functions.\n+\t * If we get cb_param.retval == RTE_PMD_I40E_MB_EVENT_PROCEED,\n+\t * then business as usual.\n+\t * If RTE_PMD_I40E_MB_EVENT_NOOP_ACK or RTE_PMD_I40E_MB_EVENT_NOOP_NACK,\n+\t * do nothing and send not_supported to VF. As PF must send a response\n+\t * to VF and ACK/NACK is not defined.\n+\t */\n+\t_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_VF_MBOX, &cb_param);\n+\tif (cb_param.retval != RTE_PMD_I40E_MB_EVENT_PROCEED) {\n+\t\tPMD_DRV_LOG(WARNING, \"VF to PF message(%d) is not permitted!\",\n+\t\t\t opcode);\n+\t\tb_op = FALSE;\n+\t}\n+\n \tswitch (opcode) {\n \tcase I40E_VIRTCHNL_OP_VERSION :\n \t\tPMD_DRV_LOG(INFO, \"OP_VERSION received\");\n-\t\ti40e_pf_host_process_cmd_version(vf);\n+\t\ti40e_pf_host_process_cmd_version(vf, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_RESET_VF :\n \t\tPMD_DRV_LOG(INFO, \"OP_RESET_VF received\");\n@@ -948,61 +1097,72 @@ i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev,\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_GET_VF_RESOURCES:\n \t\tPMD_DRV_LOG(INFO, \"OP_GET_VF_RESOURCES received\");\n-\t\ti40e_pf_host_process_cmd_get_vf_resource(vf);\n+\t\ti40e_pf_host_process_cmd_get_vf_resource(vf, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES:\n \t\tPMD_DRV_LOG(INFO, \"OP_CONFIG_VSI_QUEUES received\");\n-\t\ti40e_pf_host_process_cmd_config_vsi_queues(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_config_vsi_queues(vf, msg,\n+\t\t\t\t\t\t\t msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT:\n \t\tPMD_DRV_LOG(INFO, \"OP_CONFIG_VSI_QUEUES_EXT received\");\n \t\ti40e_pf_host_process_cmd_config_vsi_queues_ext(vf, msg,\n-\t\t\t\t\t\t\t\tmsglen);\n+\t\t\t\t\t\t\t msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_CONFIG_IRQ_MAP:\n \t\tPMD_DRV_LOG(INFO, \"OP_CONFIG_IRQ_MAP received\");\n-\t\ti40e_pf_host_process_cmd_config_irq_map(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_config_irq_map(vf, msg, msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_ENABLE_QUEUES:\n \t\tPMD_DRV_LOG(INFO, \"OP_ENABLE_QUEUES received\");\n-\t\ti40e_pf_host_process_cmd_enable_queues(vf, msg, msglen);\n-\t\ti40e_notify_vf_link_status(dev, vf);\n+\t\tif (b_op) {\n+\t\t\ti40e_pf_host_process_cmd_enable_queues(vf, msg, msglen);\n+\t\t\ti40e_notify_vf_link_status(dev, vf);\n+\t\t} else {\n+\t\t\ti40e_pf_host_send_msg_to_vf(\n+\t\t\t\tvf, I40E_VIRTCHNL_OP_ENABLE_QUEUES,\n+\t\t\t\tI40E_NOT_SUPPORTED, NULL, 0);\n+\t\t}\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_DISABLE_QUEUES:\n \t\tPMD_DRV_LOG(INFO, \"OP_DISABLE_QUEUE received\");\n-\t\ti40e_pf_host_process_cmd_disable_queues(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_disable_queues(vf, msg, msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_ADD_ETHER_ADDRESS:\n \t\tPMD_DRV_LOG(INFO, \"OP_ADD_ETHER_ADDRESS received\");\n-\t\ti40e_pf_host_process_cmd_add_ether_address(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_add_ether_address(vf, msg,\n+\t\t\t\t\t\t\t msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_DEL_ETHER_ADDRESS:\n \t\tPMD_DRV_LOG(INFO, \"OP_DEL_ETHER_ADDRESS received\");\n-\t\ti40e_pf_host_process_cmd_del_ether_address(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_del_ether_address(vf, msg,\n+\t\t\t\t\t\t\t msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_ADD_VLAN:\n \t\tPMD_DRV_LOG(INFO, \"OP_ADD_VLAN received\");\n-\t\ti40e_pf_host_process_cmd_add_vlan(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_add_vlan(vf, msg, msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_DEL_VLAN:\n \t\tPMD_DRV_LOG(INFO, \"OP_DEL_VLAN received\");\n-\t\ti40e_pf_host_process_cmd_del_vlan(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_del_vlan(vf, msg, msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE:\n \t\tPMD_DRV_LOG(INFO, \"OP_CONFIG_PROMISCUOUS_MODE received\");\n-\t\ti40e_pf_host_process_cmd_config_promisc_mode(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_config_promisc_mode(vf, msg,\n+\t\t\t\t\t\t\t msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_GET_STATS:\n \t\tPMD_DRV_LOG(INFO, \"OP_GET_STATS received\");\n-\t\ti40e_pf_host_process_cmd_get_stats(vf);\n+\t\ti40e_pf_host_process_cmd_get_stats(vf, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_CFG_VLAN_OFFLOAD:\n \t\tPMD_DRV_LOG(INFO, \"OP_CFG_VLAN_OFFLOAD received\");\n-\t\ti40e_pf_host_process_cmd_cfg_vlan_offload(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_cfg_vlan_offload(vf, msg,\n+\t\t\t\t\t\t\t msglen, b_op);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_CFG_VLAN_PVID:\n \t\tPMD_DRV_LOG(INFO, \"OP_CFG_VLAN_PVID received\");\n-\t\ti40e_pf_host_process_cmd_cfg_pvid(vf, msg, msglen);\n+\t\ti40e_pf_host_process_cmd_cfg_pvid(vf, msg, msglen, b_op);\n \t\tbreak;\n \t/* Don't add command supported below, which will\n \t * return an error code.\ndiff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h\nindex 14852f2..eb7a72b 100644\n--- a/drivers/net/i40e/rte_pmd_i40e.h\n+++ b/drivers/net/i40e/rte_pmd_i40e.h\n@@ -42,6 +42,27 @@\n #include <rte_ethdev.h>\n \n /**\n+ * Response sent back to i40e driver from user app after callback\n+ */\n+enum rte_pmd_i40e_mb_event_rsp {\n+\tRTE_PMD_I40E_MB_EVENT_NOOP_ACK, /**< skip mbox request and ACK */\n+\tRTE_PMD_I40E_MB_EVENT_NOOP_NACK, /**< skip mbox request and NACK */\n+\tRTE_PMD_I40E_MB_EVENT_PROCEED, /**< proceed with mbox request */\n+\tRTE_PMD_I40E_MB_EVENT_MAX /**< max value of this enum */\n+};\n+\n+/**\n+ * Data sent to the user application when the callback is executed.\n+ */\n+struct rte_pmd_i40e_mb_event_param {\n+\tuint16_t vfid; /**< Virtual Function number */\n+\tuint16_t msg_type; /**< VF to PF message type, see i40e_virtchnl_ops */\n+\tuint16_t retval; /**< return value */\n+\tvoid *msg; /**< pointer to message */\n+\tuint16_t msglen; /**< length of the message */\n+};\n+\n+/**\n * Notify VF when PF link status changes.\n *\n * @param port\n", "prefixes": [ "dpdk-dev", "v3", "02/29" ] }