Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1793/?format=api
https://patches.dpdk.org/api/patches/1793/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1418019716-4962-4-git-send-email-changchun.ouyang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1418019716-4962-4-git-send-email-changchun.ouyang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1418019716-4962-4-git-send-email-changchun.ouyang@intel.com", "date": "2014-12-08T06:21:42", "name": "[dpdk-dev,RFC,03/17] virtio: Allow starting with link down", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "a0d8516d9ac0ea93c77a67512c78335ca4388b18", "submitter": { "id": 31, "url": "https://patches.dpdk.org/api/people/31/?format=api", "name": "Ouyang Changchun", "email": "changchun.ouyang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1418019716-4962-4-git-send-email-changchun.ouyang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1793/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1793/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B5CBE8065;\n\tMon, 8 Dec 2014 07:22:41 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 1A9C08066\n\tfor <dev@dpdk.org>; Mon, 8 Dec 2014 07:22:35 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 07 Dec 2014 22:22:33 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 07 Dec 2014 22:22:09 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sB86M7YY019083;\n\tMon, 8 Dec 2014 14:22:07 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sB86M5Wd005024; Mon, 8 Dec 2014 14:22:07 +0800", "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sB86M5hv005020; \n\tMon, 8 Dec 2014 14:22:05 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,536,1413270000\"; d=\"scan'208\";a=\"634270770\"", "From": "Ouyang Changchun <changchun.ouyang@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 8 Dec 2014 14:21:42 +0800", "Message-Id": "<1418019716-4962-4-git-send-email-changchun.ouyang@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1418019716-4962-1-git-send-email-changchun.ouyang@intel.com>", "References": "<1418019716-4962-1-git-send-email-changchun.ouyang@intel.com>", "Subject": "[dpdk-dev] [RFC PATCH 03/17] virtio: Allow starting with link down", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Starting driver with link down should be ok, it is with every\nother driver. So just allow it.\n\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_pmd_virtio/virtio_ethdev.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c\nindex 78018f9..4bff0fe 100644\n--- a/lib/librte_pmd_virtio/virtio_ethdev.c\n+++ b/lib/librte_pmd_virtio/virtio_ethdev.c\n@@ -1057,14 +1057,12 @@ virtio_dev_start(struct rte_eth_dev *dev)\n \t\tvtpci_read_dev_config(hw,\n \t\t\t\toffsetof(struct virtio_net_config, status),\n \t\t\t\t&status, sizeof(status));\n-\t\tif ((status & VIRTIO_NET_S_LINK_UP) == 0) {\n+\t\tif ((status & VIRTIO_NET_S_LINK_UP) == 0)\n \t\t\tPMD_INIT_LOG(ERR, \"Port: %d Link is DOWN\",\n \t\t\t\t dev->data->port_id);\n-\t\t\treturn -EIO;\n-\t\t} else {\n+\t\telse\n \t\t\tPMD_INIT_LOG(DEBUG, \"Port: %d Link is UP\",\n \t\t\t\t dev->data->port_id);\n-\t\t}\n \t}\n \tvtpci_reinit_complete(hw);\n \n", "prefixes": [ "dpdk-dev", "RFC", "03/17" ] }{ "id": 1793, "url": "